From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 781ACC43334 for ; Thu, 7 Jul 2022 06:29:03 +0000 (UTC) Received: from localhost ([::1]:58088 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9L0X-0000ne-TK for qemu-devel@archiver.kernel.org; Thu, 07 Jul 2022 02:29:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33258) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9KvW-0007Lf-5j for qemu-devel@nongnu.org; Thu, 07 Jul 2022 02:23:50 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:42372) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9KvS-0004G5-Cm for qemu-devel@nongnu.org; Thu, 07 Jul 2022 02:23:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657175023; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1z7R9czkd7FGjw1l0NnLiF8MH0ueargNiy1fLciM8PE=; b=NlN27Wr7PcW4BzpbrVYsORBM3fkm9MYs1cG92ahZJBgT6pwav9SXChvV9urY0q0jjLMxVZ 6FAxUbI9ayqSrEbPJEjS1UAhavYHUvuLIFVHHOoIhUXPM+Bjsctu/L1JgsAFjsWXFZ1nJB 5jkUbRlXQbrnWI0g6dsTmvwybiz6T3w= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-592-ijep5A-TNxCgDkfT3Ru3tw-1; Thu, 07 Jul 2022 02:23:40 -0400 X-MC-Unique: ijep5A-TNxCgDkfT3Ru3tw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0232E185A7A4; Thu, 7 Jul 2022 06:23:40 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.195.112]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B856F40466D4; Thu, 7 Jul 2022 06:23:39 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 849D421E690D; Thu, 7 Jul 2022 08:23:38 +0200 (CEST) From: Markus Armbruster To: Eugenio =?utf-8?Q?P=C3=A9rez?= Cc: qemu-devel@nongnu.org, Liuxiangdong , Harpreet Singh Anand , Eric Blake , Laurent Vivier , Parav Pandit , Cornelia Huck , Paolo Bonzini , Gautam Dawar , Eli Cohen , "Gonglei (Arei)" , Zhu Lingshan , "Michael S. Tsirkin" , Cindy Lu , Jason Wang Subject: Re: [RFC PATCH v9 23/23] vdpa: Add x-svq to NetdevVhostVDPAOptions References: <20220706184008.1649478-1-eperezma@redhat.com> <20220706184008.1649478-24-eperezma@redhat.com> Date: Thu, 07 Jul 2022 08:23:38 +0200 In-Reply-To: <20220706184008.1649478-24-eperezma@redhat.com> ("Eugenio =?utf-8?Q?P=C3=A9rez=22's?= message of "Wed, 6 Jul 2022 20:40:08 +0200") Message-ID: <87ilo9igph.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Eugenio P=C3=A9rez writes: > Finally offering the possibility to enable SVQ from the command line. QMP, too, I guess. > > Signed-off-by: Eugenio P=C3=A9rez > --- > qapi/net.json | 9 +++++- > net/vhost-vdpa.c | 72 ++++++++++++++++++++++++++++++++++++++++++++++-- > 2 files changed, 77 insertions(+), 4 deletions(-) > > diff --git a/qapi/net.json b/qapi/net.json > index 9af11e9a3b..75ba2cb989 100644 > --- a/qapi/net.json > +++ b/qapi/net.json > @@ -445,12 +445,19 @@ > # @queues: number of queues to be created for multiqueue vhost-vdpa > # (default: 1) > # > +# @x-svq: Start device with (experimental) shadow virtqueue. (Since 7.1) > +# (default: false) > +# > +# Features: > +# @unstable: Member @x-svq is experimental. > +# > # Since: 5.1 > ## > { 'struct': 'NetdevVhostVDPAOptions', > 'data': { > '*vhostdev': 'str', > - '*queues': 'int' } } > + '*queues': 'int', > + '*x-svq': {'type': 'bool', 'features' : [ 'unstable'] } } } >=20=20 > ## QAPI schema: Acked-by: Markus Armbruster [...]