Re: [Intel-gfx] [PATCH 1/3] drm/i915: Use short PCH names consistently

[Jani Nikula <jani.nikula@linux.intel.com>]

On Thu, 30 Jun 2022, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Thu, Jun 30, 2022 at 03:50:15PM +0000, Murthy, Arun R wrote:
>> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> > 
>> > The comments regarding PCH compatibility use long vs.
>> > short names inconsistently. Just use short names always.
>> > 
>> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> > ---
>> >  drivers/gpu/drm/i915/intel_pch.c | 10 +++++-----
>> >  1 file changed, 5 insertions(+), 5 deletions(-)
>> > 
>> > diff --git a/drivers/gpu/drm/i915/intel_pch.c
>> > b/drivers/gpu/drm/i915/intel_pch.c
>> > index e2b2bbdc0714..94446cac6605 100644
>> > --- a/drivers/gpu/drm/i915/intel_pch.c
>> > +++ b/drivers/gpu/drm/i915/intel_pch.c
>> > @@ -25,7 +25,7 @@ intel_pch_type(const struct drm_i915_private
>> > *dev_priv, unsigned short id)
>> >  		drm_dbg_kms(&dev_priv->drm, "Found PantherPoint
>> > PCH\n");
>> >  		drm_WARN_ON(&dev_priv->drm,
>> >  			    GRAPHICS_VER(dev_priv) != 6 &&
>> > !IS_IVYBRIDGE(dev_priv));
>> > -		/* PantherPoint is CPT compatible */
>> > +		/* PPT is CPT compatible */
>> 
>> 
>> This is not the code but only comment, I feel elaborated names makes it more readable than abbreviation.
>
> We rarely type out the full names for anything.

And we still keep debug logging the full names right there.

Reviewed-by: Jani Nikula <jani.nikula@intel.com>


-- 
Jani Nikula, Intel Open Source Graphics Center