From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D3B4C433EF for ; Mon, 16 May 2022 16:44:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 15D584B2B2; Mon, 16 May 2022 12:44:39 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QClT8IGrzgIF; Mon, 16 May 2022 12:44:37 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id B3EE14B2A7; Mon, 16 May 2022 12:44:37 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 9CBCB4B2A4 for ; Mon, 16 May 2022 12:44:36 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SsiVetoMSCdJ for ; Mon, 16 May 2022 12:44:35 -0400 (EDT) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 161664B2A1 for ; Mon, 16 May 2022 12:44:35 -0400 (EDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 427DBB81258; Mon, 16 May 2022 16:44:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4206C385AA; Mon, 16 May 2022 16:44:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652719472; bh=CYEvraFOukMkXu6WJZExhFsNqffzBStRQaubVucF2VE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hQ3raqWSwFK4Im/gQu5BrQ4j5EyxbLqHUz+Thyw+Air6BDVAOJuI4kc6nzyOZ25OU b1AY5WRVxEfX6D07dcOBR9dytT7129POMhLMkPhRECoHIpow/eHniKQmN8v6TxqUJV tJixyVk71SO7PdcAHVfTeXZiyZVkkd5CwEajyv+QDZqiavEnxLHiwL/2xdBqhdWSmN 4A3s5b1Svfd80b2zJy//vKyhJqZOMOaPIwhpcG+FpUJYzDEkcVA7zm4loAzpNzjGFT Dleu4A7zeI1r9OS5GBL1rbamw5P5i4i0d7rnznuEpn/KsRQ8jpMJhqvFRfO1ZSnsZQ 1f1tFAW7qheOA== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nqdpc-00Bfyr-Tm; Mon, 16 May 2022 17:44:29 +0100 Date: Mon, 16 May 2022 17:44:28 +0100 Message-ID: <87ilq55swj.wl-maz@kernel.org> From: Marc Zyngier To: Raghavendra Rao Ananta Subject: Re: [PATCH v7 0/9] KVM: arm64: Add support for hypercall services selection In-Reply-To: References: <20220502233853.1233742-1-rananta@google.com> <878rri8r78.wl-maz@kernel.org> <878rriicez.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: rananta@google.com, drjones@redhat.com, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, pbonzini@redhat.com, catalin.marinas@arm.com, will@kernel.org, pshier@google.com, ricarkol@google.com, oupton@google.com, reijiw@google.com, jingzhangos@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, kvm@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: kvm@vger.kernel.org, Will Deacon , Catalin Marinas , Peter Shier , linux-kernel@vger.kernel.org, Paolo Bonzini , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu T24gVHVlLCAwMyBNYXkgMjAyMiAyMjowOToyOSArMDEwMCwKUmFnaGF2ZW5kcmEgUmFvIEFuYW50 YSA8cmFuYW50YUBnb29nbGUuY29tPiB3cm90ZToKPiAKPiBPbiBUdWUsIE1heSAzLCAyMDIyIGF0 IDE6MzMgUE0gTWFyYyBaeW5naWVyIDxtYXpAa2VybmVsLm9yZz4gd3JvdGU6Cj4gPgo+ID4gT24g VHVlLCAwMyBNYXkgMjAyMiAxOTo0OToxMyArMDEwMCwKPiA+IFJhZ2hhdmVuZHJhIFJhbyBBbmFu dGEgPHJhbmFudGFAZ29vZ2xlLmNvbT4gd3JvdGU6Cj4gPiA+Cj4gPiA+IEhpIE1hcmMsCj4gPiA+ Cj4gPiA+IE9uIFR1ZSwgTWF5IDMsIDIwMjIgYXQgMTA6MjQgQU0gTWFyYyBaeW5naWVyIDxtYXpA a2VybmVsLm9yZz4gd3JvdGU6Cj4gPiA+ID4KPiA+ID4gPiBPbiBUdWUsIDAzIE1heSAyMDIyIDAw OjM4OjQ0ICswMTAwLAo+ID4gPiA+IFJhZ2hhdmVuZHJhIFJhbyBBbmFudGEgPHJhbmFudGFAZ29v Z2xlLmNvbT4gd3JvdGU6Cj4gPiA+ID4gPgo+ID4gPiA+ID4gSGVsbG8sCj4gPiA+ID4gPgo+ID4g PiA+ID4gQ29udGludWluZyB0aGUgZGlzY3Vzc2lvbiBmcm9tIFsxXSwgdGhlIHNlcmllcyB0cmll cyB0byBhZGQgc3VwcG9ydAo+ID4gPiA+ID4gZm9yIHRoZSB1c2Vyc3BhY2UgdG8gZWxlY3QgdGhl IGh5cGVyY2FsbCBzZXJ2aWNlcyB0aGF0IGl0IHdpc2hlcwo+ID4gPiA+ID4gdG8gZXhwb3NlIHRv IHRoZSBndWVzdCwgcmF0aGVyIHRoYW4gdGhlIGd1ZXN0IGRpc2NvdmVyaW5nIHRoZW0KPiA+ID4g PiA+IHVuY29uZGl0aW9uYWxseS4gVGhlIGlkZWEgZW1wbG95ZWQgYnkgdGhlIHNlcmllcyB3YXMg dGFrZW4gZnJvbQo+ID4gPiA+ID4gWzFdIGFzIHN1Z2dlc3RlZCBieSBNYXJjIFouCj4gPiA+ID4K PiA+ID4gPiBBcyBpdCB0b29rIHNvbWUgdGltZSB0byBnZXQgdGhlcmUsIGFuZCB0aGF0IHRoZXJl IHdhcyBzdGlsbCBhIGJ1bmNoIG9mCj4gPiA+ID4gdGhpbmdzIHRvIGFkZHJlc3MsIEkndmUgdGFr ZW4gdGhlIGxpYmVydHkgdG8gYXBwbHkgbXkgb3duIGZpeGVzIHRvIHRoZQo+ID4gPiA+IHNlcmll cy4KPiA+ID4gPgo+ID4gPiA+IFBsZWFzZSBoYXZlIGEgbG9vayBhdCBbMV0sIGFuZCBsZXQgbWUg a25vdyBpZiB5b3UncmUgT0sgd2l0aCB0aGUKPiA+ID4gPiByZXN1bHQuIElmIHlvdSBhcmUsIEkn bGwgbWVyZ2UgdGhlIHNlcmllcyBmb3IgNS4xOS4KPiA+ID4gPgo+ID4gPiA+IFRoYW5rcywKPiA+ ID4gPgo+ID4gPiA+ICAgICAgICAgTS4KPiA+ID4gPgo+ID4gPiBUaGFuayB5b3UgZm9yIHNwZWVk aW5nIHVwIHRoZSBwcm9jZXNzOyBhcHByZWNpYXRlIGl0LiBIb3dldmVyLCB0aGUKPiA+ID4gc2Vy aWVzJ3Mgc2VsZnRlc3QgcGF0Y2hlcyBoYXZlIGEgZGVwZW5kZW5jeSBvbiBPbGl2ZXIncwo+ID4g PiBQU0NJX1NZU1RFTV9TVVNQRU5EJ3Mgc2VsZnRlc3QgcGF0Y2hlcyBbMV1bMl0uIENhbiB3ZSBw dWxsIHRoZW0gaW4KPiA+ID4gdG9vPwo+ID4KPiA+IFVyZ2guLi4gSSBndWVzcyB0aGlzIGlzIHRo ZSB0aW1lIHRvIHNldCBzb21lIGdyb3VuZCBydWxlczoKPiA+Cj4gPiAtIFBsZWFzZSBkb24ndCBp bnRyb2R1Y2UgZGVwZW5kZW5jaWVzIGJldHdlZW4gc2VyaWVzLCB0aGF0J3MKPiA+ICAgdW5tYW5h Z2VhYmxlLiBJIHJlYWxseSBuZWVkIHRvIHNlZSBlYWNoIHNlcmllcyBpbmRlcGVuZGVudGx5LCBh bmQgaWYKPiA+ICAgdGhlcmUgaXMgYSBtZXJnZSBjb25mbGljdCwgdGhhdCdzIG15IGpvYiB0byBm aXggKGFuZCBJIGRvbid0IHJlYWxseQo+ID4gICBtaW5kKS4KPiA+Cj4gPiAtIElmIHRoZXJlIGlz IGEgZGVwZW5kZW5jeSBiZXR3ZWVuIHNlcmllcywgcGxlYXNlIHBvc3QgYSB2ZXJzaW9uIG9mCj4g PiAgIHRoZSByZXF1aXJlZCBwYXRjaGVzIGFzIGEgcHJlZml4IHRvIHlvdXIgc2VyaWVzLCBhc3N1 bWluZyB0aGlzCj4gPiAgIHByZWZpeCBpcyBpdHNlbGYgc3RhbmRhbG9uZS4gSWYgaXQgaXNuJ3Qs IHRoZW4gc29tZXRoaW5nIHJlYWxseSBpcwo+ID4gICB3cm9uZywgYW5kIHRoZSBzZXJpZXMgc2hv dWxkIGJlIHJlc3BsaXQuCj4gPgo+ID4gLSBZb3UgYWxzbyBzaG91bGQgYmUgYmFzaW5nIHlvdXIg c2VyaWVzIG9uIGFuICpvZmZpY2lhbCogdGFnIGZyb20KPiA+ICAgTGludXMnIHRyZWUgKHByZWZl cmFibHkgLXJjMSwgLXJjMiBvciAtcmMzKSwgYW5kIG5vdCBzb21ldGhpbmcKPiA+ICAgcmFuZG9t IGxpa2UgYW55IG9kZCBjb21taXQgZnJvbSB0aGUgS1ZNIHRyZWUgKEkgaGFkIGNvbmZsaWN0cyB3 aGlsZQo+ID4gICBhcHBseWluZyB0aGlzIG9uIC1yYzMsIHByb2JhYmx5IGR1ZSB0byB0aGUgbm9u LWFkdmVydGlzZWQgZGVwZW5kZW5jeQo+ID4gICBvbiBPbGl2ZXIncyBzZXJpZXMpLgo+ID4KPiBU aGFua3MgZm9yIHBpY2tpbmcgdGhlIGRlcGVuZGVuY3kgcGF0Y2hlcy4gSSdsbCBrZWVwIHRoZXNl IG1pbmQgdGhlCj4gbmV4dCB0aW1lIEkgcHVzaCBjaGFuZ2VzLgo+IAo+ID4gPgo+ID4gPiBhYXJj aDY0L2h5cGVyY2FsbHMuYzogSW4gZnVuY3Rpb24g4oCYZ3Vlc3RfdGVzdF9odmPigJk6Cj4gPiA+ IGFhcmNoNjQvaHlwZXJjYWxscy5jOjk1OjMwOiBlcnJvcjogc3RvcmFnZSBzaXplIG9mIOKAmHJl c+KAmSBpc27igJl0IGtub3duCj4gPiA+ICAgIDk1IHwgICAgICAgICBzdHJ1Y3QgYXJtX3NtY2Nj X3JlcyByZXM7Cj4gPiA+ICAgICAgIHwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBefn4K PiA+ID4gYWFyY2g2NC9oeXBlcmNhbGxzLmM6MTAzOjE3OiB3YXJuaW5nOiBpbXBsaWNpdCBkZWNs YXJhdGlvbiBvZiBmdW5jdGlvbgo+ID4gPiDigJhzbWNjY19odmPigJkgWy1XaW1wbGljaXQtZnVu Y3Rpb24tZGVjbGFyYXRpb25dCj4gPiA+ICAgMTAzIHwgICAgICAgICAgICAgICAgIHNtY2NjX2h2 YyhoY19pbmZvLT5mdW5jX2lkLCBoY19pbmZvLT5hcmcxLCAwLAo+ID4gPiAwLCAwLCAwLCAwLCAw LCAmcmVzKTsKPiA+ID4gICAgICAgfCAgICAgICAgICAgICAgICAgXn5+fn5+fn5+Cj4gPiA+Cj4g Pgo+ID4gSSd2ZSBwaWNrZWQgdGhlIHR3byBwYXRjaGVzLCB3aGljaCBtZWFucyB0aGV5IHdpbGwg bW9zdCBsaWtlbHkgYXBwZWFyCj4gPiB0d2ljZSBpbiB0aGUgaGlzdG9yeS4gSW4gdGhlIGZ1dHVy ZSwgcGxlYXNlIHJlYWNoIG91dCBzbyB0aGF0IHdlIGNhbgo+ID4gb3JnYW5pc2UgdGhpcyBiZXR0 ZXIuCj4gPgo+ID4gPiBBbHNvLCBqdXN0IGEgY291cGxlIG9mIHJlYWRhYmlsaXR5IG5pdHMgaW4g dGhlIGZpeGVkIHZlcnNpb246Cj4gPiA+Cj4gPiA+IDEuIFBhdGNoLTIvOSwgaHlwZXJjYWxsLmM6 a3ZtX2h2Y19jYWxsX2RlZmF1bHRfYWxsb3dlZCgpLCBpbiB0aGUKPiA+ID4gJ2RlZmF1bHQnIGNh c2UsIGRvIHlvdSB0aGluayB3ZSBzaG91bGQgcHJvYmFibHkgYWRkIGEgc21hbGwgY29tbWVudAo+ ID4gPiB0aGF0IG1lbnRpb25zIHdlIGFyZSBjaGVja2luZyBmb3IgZnVuY19pZCBpbiB0aGUgUFND SSByYW5nZT8KPiA+Cj4gPiBEdW1wZWQgYSBvbmUtbGluZXIgdGhlcmUuCj4gPgo+ID4gPiAyLiBQ YXRjaC0yLzksIGFybV9oeXBlcmNhbGwuaCwgY2xlYXIgYWxsIHRoZSBtYWNyb3MgaW4gdGhpcyBw YXRjaAo+ID4gPiBpdHNlbGYgaW5zdGVhZCBvZiBkb2luZyBpdCBpbiBpbmNyZW1lbnRzICh1bmxl c3MgdGhlcmUncyBzb21lIHJlYXNvbgo+ID4gPiB0aGF0IEknbSBtaXNzaW5nKT8KPiA+Cj4gPiBB aCwgcmViYXNpbmcgbGVmdG92ZXJzLCBub3cgZ29uZS4KPiA+Cj4gPiBJJ3ZlIHB1c2hlZCBhbiB1 cGRhdGVkIGJyYW5jaCBhZ2FpbiwgcGxlYXNlIGhhdmUgYSBsb29rLgo+ID4KPiBUaGFua3MgZm9y IGFkZHJlc3NpbmcgdGhlc2UuIFRoZSBzZXJpZXMgbG9va3MgZ29vZCBub3cuCgpFeGNlcHQgaXQg ZG9lc24ndC4KCkkgaW50cm9kdWNlZCBhIGJ1ZyBieSBvdmVybHkgc2ltcGxpZnlpbmcga3ZtX2Fy bV9zZXRfZndfcmVnX2JtYXAoKSwgYXMKd2UgaGF2ZSB0byBhbGxvdyB1c2Vyc3BhY2Ugd3JpdGlu ZyB0aGUgKnNhbWUqIHZhbHVlLiBBcyBpdCB0dXJucyBvdXQsClFFTVUgcmVzdG9yZXMgYWxsIHRo ZSByZWdpc3RlcnMgb24gZWFjaCByZWJvb3QuIFdoaWNoIGFzIHRoZSB2Y3B1cwpoYXZlIGFsbCBy dW4uIFRoaXMgaW4gdHVybnMgdHJpZ2dlcnMgYW5vdGhlciBpc3N1ZSBpbiBRRU1VLCB3aGljaApp bnN0ZWFkIG9mIHRha2luZyB0aGUgaGludCBhbnMgc3RvcHBpbmcgdGhlcmUsIHNlbmRzIGFsbCB0 aGUgdmNwdXMKaW50byB0aGUgZ3Vlc3QgaW4gb25lIGdvIHdpdGggcmFuZG9tIHN0YXRlcy4uLiBD cmFwIGhhcHBlbnMuCgpJJ2xsIHdlYXIgYSBicm93biBwYXBlciBiYWcgZm9yIHRoZSByZXN0IG9m IHRoZSBkYXkgYW5kIGFkZCB0aGUKZm9sbG93aW5nIHBhdGNoIHRvIHRoZSBicmFuY2guCgpUaGFu a3MsCgoJTS4KCkZyb20gNTI4YWRhMjgxMWJhMGJiMmIyZGI1YmYwZjgyOWI0OGM1MGYzYzEzYyBN b24gU2VwIDE3IDAwOjAwOjAwIDIwMDEKRnJvbTogTWFyYyBaeW5naWVyIDxtYXpAa2VybmVsLm9y Zz4KRGF0ZTogTW9uLCAxNiBNYXkgMjAyMiAxNzozMjo1NCArMDEwMApTdWJqZWN0OiBbUEFUQ0hd IEtWTTogYXJtNjQ6IEZpeCBoeXBlcmNhbGwgYml0bWFwIHdyaXRlYmFjayB3aGVuIHZjcHVzIGhh dmUKIGFscmVhZHkgcnVuCgpXZSBnZW5lcmFsbHkgd2FudCB0byBkaXNhbGxvdyBoeXBlcmNhbGwg Yml0bWFwcyBiZWluZyBjaGFuZ2VkCm9uY2UgdmNwdXMgaGF2ZSBhbHJlYWR5IHJ1bi4gQnV0IHdl IG11c3QgYWxsb3cgdGhlIHdyaXRlIGlmCnRoZSB3cml0dGVuIHZhbHVlIGlzIHVuY2hhbmdlZCBz byB0aGF0IHVzZXJzcGFjZSBjYW4gcmV3cml0ZQp0aGUgcmVnaXN0ZXIgZmlsZSBvbiByZWJvb3Qs IGZvciBleGFtcGxlLgoKV2l0aG91dCB0aGlzLCBhIFFFTVUtYmFzZWQgVk0gd2lsbCBmYWlsIHRv IHJlYm9vdCBjb3JyZWN0bHkuCgpUaGUgb3JpZ2luYWwgY29kZSB3YXMgY29ycmVjdCwgYW5kIGl0 IGlzIG1lIHRoYXQgaW50cm9kdWNlZAp0aGUgcmVncmVzc2lvbi4KCkZpeGVzOiAwNTcxNGNhYjdk NjMgKCJLVk06IGFybTY0OiBTZXR1cCBhIGZyYW1ld29yayBmb3IgaHlwZXJjYWxsIGJpdG1hcCBm aXJtd2FyZSByZWdpc3RlcnMiKQpTaWduZWQtb2ZmLWJ5OiBNYXJjIFp5bmdpZXIgPG1hekBrZXJu ZWwub3JnPgotLS0KIGFyY2gvYXJtNjQva3ZtL2h5cGVyY2FsbHMuYyB8IDMgKystCiAxIGZpbGUg Y2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvYXJj aC9hcm02NC9rdm0vaHlwZXJjYWxscy5jIGIvYXJjaC9hcm02NC9rdm0vaHlwZXJjYWxscy5jCmlu ZGV4IGNjYmQzY2VmYjkxYS4uYzlmNDAxZmEwMWE5IDEwMDY0NAotLS0gYS9hcmNoL2FybTY0L2t2 bS9oeXBlcmNhbGxzLmMKKysrIGIvYXJjaC9hcm02NC9rdm0vaHlwZXJjYWxscy5jCkBAIC0zNzks NyArMzc5LDggQEAgc3RhdGljIGludCBrdm1fYXJtX3NldF9md19yZWdfYm1hcChzdHJ1Y3Qga3Zt X3ZjcHUgKnZjcHUsIHU2NCByZWdfaWQsIHU2NCB2YWwpCiAKIAltdXRleF9sb2NrKCZrdm0tPmxv Y2spOwogCi0JaWYgKHRlc3RfYml0KEtWTV9BUkNIX0ZMQUdfSEFTX1JBTl9PTkNFLCAma3ZtLT5h cmNoLmZsYWdzKSkgeworCWlmICh0ZXN0X2JpdChLVk1fQVJDSF9GTEFHX0hBU19SQU5fT05DRSwg Jmt2bS0+YXJjaC5mbGFncykgJiYKKwkgICAgdmFsICE9ICpmd19yZWdfYm1hcCkgewogCQlyZXQg PSAtRUJVU1k7CiAJCWdvdG8gb3V0OwogCX0KLS0gCjIuMzQuMQoKCi0tIApXaXRob3V0IGRldmlh dGlvbiBmcm9tIHRoZSBub3JtLCBwcm9ncmVzcyBpcyBub3QgcG9zc2libGUuCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmt2bWFybSBtYWlsaW5nIGxpc3QK a3ZtYXJtQGxpc3RzLmNzLmNvbHVtYmlhLmVkdQpodHRwczovL2xpc3RzLmNzLmNvbHVtYmlhLmVk dS9tYWlsbWFuL2xpc3RpbmZvL2t2bWFybQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 524D9C43219 for ; Mon, 16 May 2022 16:46:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5fVOkbKnAnn7qnD8x2yPhmxZlobBHDr7C6XEAdZL0KM=; b=LyE6XjPrmPKczX eZDJ6Q4nD+Rk83Wu5URa/gKqWAyGAagRlY4gHr3TjKONO5u17voItECOPLgEOcxhvDToJupXDijFC 2yoBOdhIgHqD2Uog0zDTSog4JPtpbolAomfPWYKIjjtUx9xT7WFv9HDgRu499tsicofHBfzxsn4xn 4EaWKlVih0DbQZPfRdR9ARrAXHtkdGFBPh+zek6SXn2/D3mopeK8Vq3xxS+MDow+I3tvMZG+8Uk0K DXXnQae/GaGVzZPxEBJXlRqDgq+jJWah+Q7mCTPYvV4ZMoDPqY7Ny/9ayrajSvhxlDozZ8+LurVjE UiGcPnToaGO5fDkNH4dg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqdpv-0097mI-FB; Mon, 16 May 2022 16:44:49 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqdpj-0097iY-Lz for linux-arm-kernel@lists.infradead.org; Mon, 16 May 2022 16:44:37 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 427DBB81258; Mon, 16 May 2022 16:44:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4206C385AA; Mon, 16 May 2022 16:44:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652719472; bh=CYEvraFOukMkXu6WJZExhFsNqffzBStRQaubVucF2VE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hQ3raqWSwFK4Im/gQu5BrQ4j5EyxbLqHUz+Thyw+Air6BDVAOJuI4kc6nzyOZ25OU b1AY5WRVxEfX6D07dcOBR9dytT7129POMhLMkPhRECoHIpow/eHniKQmN8v6TxqUJV tJixyVk71SO7PdcAHVfTeXZiyZVkkd5CwEajyv+QDZqiavEnxLHiwL/2xdBqhdWSmN 4A3s5b1Svfd80b2zJy//vKyhJqZOMOaPIwhpcG+FpUJYzDEkcVA7zm4loAzpNzjGFT Dleu4A7zeI1r9OS5GBL1rbamw5P5i4i0d7rnznuEpn/KsRQ8jpMJhqvFRfO1ZSnsZQ 1f1tFAW7qheOA== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nqdpc-00Bfyr-Tm; Mon, 16 May 2022 17:44:29 +0100 Date: Mon, 16 May 2022 17:44:28 +0100 Message-ID: <87ilq55swj.wl-maz@kernel.org> From: Marc Zyngier To: Raghavendra Rao Ananta Cc: Andrew Jones , James Morse , Alexandru Elisei , Suzuki K Poulose , Paolo Bonzini , Catalin Marinas , Will Deacon , Peter Shier , Ricardo Koller , Oliver Upton , Reiji Watanabe , Jing Zhang , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v7 0/9] KVM: arm64: Add support for hypercall services selection In-Reply-To: References: <20220502233853.1233742-1-rananta@google.com> <878rri8r78.wl-maz@kernel.org> <878rriicez.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: rananta@google.com, drjones@redhat.com, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, pbonzini@redhat.com, catalin.marinas@arm.com, will@kernel.org, pshier@google.com, ricarkol@google.com, oupton@google.com, reijiw@google.com, jingzhangos@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, kvm@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220516_094436_152985_CE84360B X-CRM114-Status: GOOD ( 60.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAwMyBNYXkgMjAyMiAyMjowOToyOSArMDEwMCwKUmFnaGF2ZW5kcmEgUmFvIEFuYW50 YSA8cmFuYW50YUBnb29nbGUuY29tPiB3cm90ZToKPiAKPiBPbiBUdWUsIE1heSAzLCAyMDIyIGF0 IDE6MzMgUE0gTWFyYyBaeW5naWVyIDxtYXpAa2VybmVsLm9yZz4gd3JvdGU6Cj4gPgo+ID4gT24g VHVlLCAwMyBNYXkgMjAyMiAxOTo0OToxMyArMDEwMCwKPiA+IFJhZ2hhdmVuZHJhIFJhbyBBbmFu dGEgPHJhbmFudGFAZ29vZ2xlLmNvbT4gd3JvdGU6Cj4gPiA+Cj4gPiA+IEhpIE1hcmMsCj4gPiA+ Cj4gPiA+IE9uIFR1ZSwgTWF5IDMsIDIwMjIgYXQgMTA6MjQgQU0gTWFyYyBaeW5naWVyIDxtYXpA a2VybmVsLm9yZz4gd3JvdGU6Cj4gPiA+ID4KPiA+ID4gPiBPbiBUdWUsIDAzIE1heSAyMDIyIDAw OjM4OjQ0ICswMTAwLAo+ID4gPiA+IFJhZ2hhdmVuZHJhIFJhbyBBbmFudGEgPHJhbmFudGFAZ29v Z2xlLmNvbT4gd3JvdGU6Cj4gPiA+ID4gPgo+ID4gPiA+ID4gSGVsbG8sCj4gPiA+ID4gPgo+ID4g PiA+ID4gQ29udGludWluZyB0aGUgZGlzY3Vzc2lvbiBmcm9tIFsxXSwgdGhlIHNlcmllcyB0cmll cyB0byBhZGQgc3VwcG9ydAo+ID4gPiA+ID4gZm9yIHRoZSB1c2Vyc3BhY2UgdG8gZWxlY3QgdGhl IGh5cGVyY2FsbCBzZXJ2aWNlcyB0aGF0IGl0IHdpc2hlcwo+ID4gPiA+ID4gdG8gZXhwb3NlIHRv IHRoZSBndWVzdCwgcmF0aGVyIHRoYW4gdGhlIGd1ZXN0IGRpc2NvdmVyaW5nIHRoZW0KPiA+ID4g PiA+IHVuY29uZGl0aW9uYWxseS4gVGhlIGlkZWEgZW1wbG95ZWQgYnkgdGhlIHNlcmllcyB3YXMg dGFrZW4gZnJvbQo+ID4gPiA+ID4gWzFdIGFzIHN1Z2dlc3RlZCBieSBNYXJjIFouCj4gPiA+ID4K PiA+ID4gPiBBcyBpdCB0b29rIHNvbWUgdGltZSB0byBnZXQgdGhlcmUsIGFuZCB0aGF0IHRoZXJl IHdhcyBzdGlsbCBhIGJ1bmNoIG9mCj4gPiA+ID4gdGhpbmdzIHRvIGFkZHJlc3MsIEkndmUgdGFr ZW4gdGhlIGxpYmVydHkgdG8gYXBwbHkgbXkgb3duIGZpeGVzIHRvIHRoZQo+ID4gPiA+IHNlcmll cy4KPiA+ID4gPgo+ID4gPiA+IFBsZWFzZSBoYXZlIGEgbG9vayBhdCBbMV0sIGFuZCBsZXQgbWUg a25vdyBpZiB5b3UncmUgT0sgd2l0aCB0aGUKPiA+ID4gPiByZXN1bHQuIElmIHlvdSBhcmUsIEkn bGwgbWVyZ2UgdGhlIHNlcmllcyBmb3IgNS4xOS4KPiA+ID4gPgo+ID4gPiA+IFRoYW5rcywKPiA+ ID4gPgo+ID4gPiA+ICAgICAgICAgTS4KPiA+ID4gPgo+ID4gPiBUaGFuayB5b3UgZm9yIHNwZWVk aW5nIHVwIHRoZSBwcm9jZXNzOyBhcHByZWNpYXRlIGl0LiBIb3dldmVyLCB0aGUKPiA+ID4gc2Vy aWVzJ3Mgc2VsZnRlc3QgcGF0Y2hlcyBoYXZlIGEgZGVwZW5kZW5jeSBvbiBPbGl2ZXIncwo+ID4g PiBQU0NJX1NZU1RFTV9TVVNQRU5EJ3Mgc2VsZnRlc3QgcGF0Y2hlcyBbMV1bMl0uIENhbiB3ZSBw dWxsIHRoZW0gaW4KPiA+ID4gdG9vPwo+ID4KPiA+IFVyZ2guLi4gSSBndWVzcyB0aGlzIGlzIHRo ZSB0aW1lIHRvIHNldCBzb21lIGdyb3VuZCBydWxlczoKPiA+Cj4gPiAtIFBsZWFzZSBkb24ndCBp bnRyb2R1Y2UgZGVwZW5kZW5jaWVzIGJldHdlZW4gc2VyaWVzLCB0aGF0J3MKPiA+ICAgdW5tYW5h Z2VhYmxlLiBJIHJlYWxseSBuZWVkIHRvIHNlZSBlYWNoIHNlcmllcyBpbmRlcGVuZGVudGx5LCBh bmQgaWYKPiA+ICAgdGhlcmUgaXMgYSBtZXJnZSBjb25mbGljdCwgdGhhdCdzIG15IGpvYiB0byBm aXggKGFuZCBJIGRvbid0IHJlYWxseQo+ID4gICBtaW5kKS4KPiA+Cj4gPiAtIElmIHRoZXJlIGlz IGEgZGVwZW5kZW5jeSBiZXR3ZWVuIHNlcmllcywgcGxlYXNlIHBvc3QgYSB2ZXJzaW9uIG9mCj4g PiAgIHRoZSByZXF1aXJlZCBwYXRjaGVzIGFzIGEgcHJlZml4IHRvIHlvdXIgc2VyaWVzLCBhc3N1 bWluZyB0aGlzCj4gPiAgIHByZWZpeCBpcyBpdHNlbGYgc3RhbmRhbG9uZS4gSWYgaXQgaXNuJ3Qs IHRoZW4gc29tZXRoaW5nIHJlYWxseSBpcwo+ID4gICB3cm9uZywgYW5kIHRoZSBzZXJpZXMgc2hv dWxkIGJlIHJlc3BsaXQuCj4gPgo+ID4gLSBZb3UgYWxzbyBzaG91bGQgYmUgYmFzaW5nIHlvdXIg c2VyaWVzIG9uIGFuICpvZmZpY2lhbCogdGFnIGZyb20KPiA+ICAgTGludXMnIHRyZWUgKHByZWZl cmFibHkgLXJjMSwgLXJjMiBvciAtcmMzKSwgYW5kIG5vdCBzb21ldGhpbmcKPiA+ICAgcmFuZG9t IGxpa2UgYW55IG9kZCBjb21taXQgZnJvbSB0aGUgS1ZNIHRyZWUgKEkgaGFkIGNvbmZsaWN0cyB3 aGlsZQo+ID4gICBhcHBseWluZyB0aGlzIG9uIC1yYzMsIHByb2JhYmx5IGR1ZSB0byB0aGUgbm9u LWFkdmVydGlzZWQgZGVwZW5kZW5jeQo+ID4gICBvbiBPbGl2ZXIncyBzZXJpZXMpLgo+ID4KPiBU aGFua3MgZm9yIHBpY2tpbmcgdGhlIGRlcGVuZGVuY3kgcGF0Y2hlcy4gSSdsbCBrZWVwIHRoZXNl IG1pbmQgdGhlCj4gbmV4dCB0aW1lIEkgcHVzaCBjaGFuZ2VzLgo+IAo+ID4gPgo+ID4gPiBhYXJj aDY0L2h5cGVyY2FsbHMuYzogSW4gZnVuY3Rpb24g4oCYZ3Vlc3RfdGVzdF9odmPigJk6Cj4gPiA+ IGFhcmNoNjQvaHlwZXJjYWxscy5jOjk1OjMwOiBlcnJvcjogc3RvcmFnZSBzaXplIG9mIOKAmHJl c+KAmSBpc27igJl0IGtub3duCj4gPiA+ICAgIDk1IHwgICAgICAgICBzdHJ1Y3QgYXJtX3NtY2Nj X3JlcyByZXM7Cj4gPiA+ICAgICAgIHwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBefn4K PiA+ID4gYWFyY2g2NC9oeXBlcmNhbGxzLmM6MTAzOjE3OiB3YXJuaW5nOiBpbXBsaWNpdCBkZWNs YXJhdGlvbiBvZiBmdW5jdGlvbgo+ID4gPiDigJhzbWNjY19odmPigJkgWy1XaW1wbGljaXQtZnVu Y3Rpb24tZGVjbGFyYXRpb25dCj4gPiA+ICAgMTAzIHwgICAgICAgICAgICAgICAgIHNtY2NjX2h2 YyhoY19pbmZvLT5mdW5jX2lkLCBoY19pbmZvLT5hcmcxLCAwLAo+ID4gPiAwLCAwLCAwLCAwLCAw LCAmcmVzKTsKPiA+ID4gICAgICAgfCAgICAgICAgICAgICAgICAgXn5+fn5+fn5+Cj4gPiA+Cj4g Pgo+ID4gSSd2ZSBwaWNrZWQgdGhlIHR3byBwYXRjaGVzLCB3aGljaCBtZWFucyB0aGV5IHdpbGwg bW9zdCBsaWtlbHkgYXBwZWFyCj4gPiB0d2ljZSBpbiB0aGUgaGlzdG9yeS4gSW4gdGhlIGZ1dHVy ZSwgcGxlYXNlIHJlYWNoIG91dCBzbyB0aGF0IHdlIGNhbgo+ID4gb3JnYW5pc2UgdGhpcyBiZXR0 ZXIuCj4gPgo+ID4gPiBBbHNvLCBqdXN0IGEgY291cGxlIG9mIHJlYWRhYmlsaXR5IG5pdHMgaW4g dGhlIGZpeGVkIHZlcnNpb246Cj4gPiA+Cj4gPiA+IDEuIFBhdGNoLTIvOSwgaHlwZXJjYWxsLmM6 a3ZtX2h2Y19jYWxsX2RlZmF1bHRfYWxsb3dlZCgpLCBpbiB0aGUKPiA+ID4gJ2RlZmF1bHQnIGNh c2UsIGRvIHlvdSB0aGluayB3ZSBzaG91bGQgcHJvYmFibHkgYWRkIGEgc21hbGwgY29tbWVudAo+ ID4gPiB0aGF0IG1lbnRpb25zIHdlIGFyZSBjaGVja2luZyBmb3IgZnVuY19pZCBpbiB0aGUgUFND SSByYW5nZT8KPiA+Cj4gPiBEdW1wZWQgYSBvbmUtbGluZXIgdGhlcmUuCj4gPgo+ID4gPiAyLiBQ YXRjaC0yLzksIGFybV9oeXBlcmNhbGwuaCwgY2xlYXIgYWxsIHRoZSBtYWNyb3MgaW4gdGhpcyBw YXRjaAo+ID4gPiBpdHNlbGYgaW5zdGVhZCBvZiBkb2luZyBpdCBpbiBpbmNyZW1lbnRzICh1bmxl c3MgdGhlcmUncyBzb21lIHJlYXNvbgo+ID4gPiB0aGF0IEknbSBtaXNzaW5nKT8KPiA+Cj4gPiBB aCwgcmViYXNpbmcgbGVmdG92ZXJzLCBub3cgZ29uZS4KPiA+Cj4gPiBJJ3ZlIHB1c2hlZCBhbiB1 cGRhdGVkIGJyYW5jaCBhZ2FpbiwgcGxlYXNlIGhhdmUgYSBsb29rLgo+ID4KPiBUaGFua3MgZm9y IGFkZHJlc3NpbmcgdGhlc2UuIFRoZSBzZXJpZXMgbG9va3MgZ29vZCBub3cuCgpFeGNlcHQgaXQg ZG9lc24ndC4KCkkgaW50cm9kdWNlZCBhIGJ1ZyBieSBvdmVybHkgc2ltcGxpZnlpbmcga3ZtX2Fy bV9zZXRfZndfcmVnX2JtYXAoKSwgYXMKd2UgaGF2ZSB0byBhbGxvdyB1c2Vyc3BhY2Ugd3JpdGlu ZyB0aGUgKnNhbWUqIHZhbHVlLiBBcyBpdCB0dXJucyBvdXQsClFFTVUgcmVzdG9yZXMgYWxsIHRo ZSByZWdpc3RlcnMgb24gZWFjaCByZWJvb3QuIFdoaWNoIGFzIHRoZSB2Y3B1cwpoYXZlIGFsbCBy dW4uIFRoaXMgaW4gdHVybnMgdHJpZ2dlcnMgYW5vdGhlciBpc3N1ZSBpbiBRRU1VLCB3aGljaApp bnN0ZWFkIG9mIHRha2luZyB0aGUgaGludCBhbnMgc3RvcHBpbmcgdGhlcmUsIHNlbmRzIGFsbCB0 aGUgdmNwdXMKaW50byB0aGUgZ3Vlc3QgaW4gb25lIGdvIHdpdGggcmFuZG9tIHN0YXRlcy4uLiBD cmFwIGhhcHBlbnMuCgpJJ2xsIHdlYXIgYSBicm93biBwYXBlciBiYWcgZm9yIHRoZSByZXN0IG9m IHRoZSBkYXkgYW5kIGFkZCB0aGUKZm9sbG93aW5nIHBhdGNoIHRvIHRoZSBicmFuY2guCgpUaGFu a3MsCgoJTS4KCkZyb20gNTI4YWRhMjgxMWJhMGJiMmIyZGI1YmYwZjgyOWI0OGM1MGYzYzEzYyBN b24gU2VwIDE3IDAwOjAwOjAwIDIwMDEKRnJvbTogTWFyYyBaeW5naWVyIDxtYXpAa2VybmVsLm9y Zz4KRGF0ZTogTW9uLCAxNiBNYXkgMjAyMiAxNzozMjo1NCArMDEwMApTdWJqZWN0OiBbUEFUQ0hd IEtWTTogYXJtNjQ6IEZpeCBoeXBlcmNhbGwgYml0bWFwIHdyaXRlYmFjayB3aGVuIHZjcHVzIGhh dmUKIGFscmVhZHkgcnVuCgpXZSBnZW5lcmFsbHkgd2FudCB0byBkaXNhbGxvdyBoeXBlcmNhbGwg Yml0bWFwcyBiZWluZyBjaGFuZ2VkCm9uY2UgdmNwdXMgaGF2ZSBhbHJlYWR5IHJ1bi4gQnV0IHdl IG11c3QgYWxsb3cgdGhlIHdyaXRlIGlmCnRoZSB3cml0dGVuIHZhbHVlIGlzIHVuY2hhbmdlZCBz byB0aGF0IHVzZXJzcGFjZSBjYW4gcmV3cml0ZQp0aGUgcmVnaXN0ZXIgZmlsZSBvbiByZWJvb3Qs IGZvciBleGFtcGxlLgoKV2l0aG91dCB0aGlzLCBhIFFFTVUtYmFzZWQgVk0gd2lsbCBmYWlsIHRv IHJlYm9vdCBjb3JyZWN0bHkuCgpUaGUgb3JpZ2luYWwgY29kZSB3YXMgY29ycmVjdCwgYW5kIGl0 IGlzIG1lIHRoYXQgaW50cm9kdWNlZAp0aGUgcmVncmVzc2lvbi4KCkZpeGVzOiAwNTcxNGNhYjdk NjMgKCJLVk06IGFybTY0OiBTZXR1cCBhIGZyYW1ld29yayBmb3IgaHlwZXJjYWxsIGJpdG1hcCBm aXJtd2FyZSByZWdpc3RlcnMiKQpTaWduZWQtb2ZmLWJ5OiBNYXJjIFp5bmdpZXIgPG1hekBrZXJu ZWwub3JnPgotLS0KIGFyY2gvYXJtNjQva3ZtL2h5cGVyY2FsbHMuYyB8IDMgKystCiAxIGZpbGUg Y2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvYXJj aC9hcm02NC9rdm0vaHlwZXJjYWxscy5jIGIvYXJjaC9hcm02NC9rdm0vaHlwZXJjYWxscy5jCmlu ZGV4IGNjYmQzY2VmYjkxYS4uYzlmNDAxZmEwMWE5IDEwMDY0NAotLS0gYS9hcmNoL2FybTY0L2t2 bS9oeXBlcmNhbGxzLmMKKysrIGIvYXJjaC9hcm02NC9rdm0vaHlwZXJjYWxscy5jCkBAIC0zNzks NyArMzc5LDggQEAgc3RhdGljIGludCBrdm1fYXJtX3NldF9md19yZWdfYm1hcChzdHJ1Y3Qga3Zt X3ZjcHUgKnZjcHUsIHU2NCByZWdfaWQsIHU2NCB2YWwpCiAKIAltdXRleF9sb2NrKCZrdm0tPmxv Y2spOwogCi0JaWYgKHRlc3RfYml0KEtWTV9BUkNIX0ZMQUdfSEFTX1JBTl9PTkNFLCAma3ZtLT5h cmNoLmZsYWdzKSkgeworCWlmICh0ZXN0X2JpdChLVk1fQVJDSF9GTEFHX0hBU19SQU5fT05DRSwg Jmt2bS0+YXJjaC5mbGFncykgJiYKKwkgICAgdmFsICE9ICpmd19yZWdfYm1hcCkgewogCQlyZXQg PSAtRUJVU1k7CiAJCWdvdG8gb3V0OwogCX0KLS0gCjIuMzQuMQoKCi0tIApXaXRob3V0IGRldmlh dGlvbiBmcm9tIHRoZSBub3JtLCBwcm9ncmVzcyBpcyBub3QgcG9zc2libGUuCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1h aWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 666DCC433F5 for ; Mon, 16 May 2022 16:44:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343815AbiEPQoh (ORCPT ); Mon, 16 May 2022 12:44:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244534AbiEPQog (ORCPT ); Mon, 16 May 2022 12:44:36 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B78763C4B1; Mon, 16 May 2022 09:44:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 603BAB81263; Mon, 16 May 2022 16:44:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4206C385AA; Mon, 16 May 2022 16:44:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652719472; bh=CYEvraFOukMkXu6WJZExhFsNqffzBStRQaubVucF2VE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hQ3raqWSwFK4Im/gQu5BrQ4j5EyxbLqHUz+Thyw+Air6BDVAOJuI4kc6nzyOZ25OU b1AY5WRVxEfX6D07dcOBR9dytT7129POMhLMkPhRECoHIpow/eHniKQmN8v6TxqUJV tJixyVk71SO7PdcAHVfTeXZiyZVkkd5CwEajyv+QDZqiavEnxLHiwL/2xdBqhdWSmN 4A3s5b1Svfd80b2zJy//vKyhJqZOMOaPIwhpcG+FpUJYzDEkcVA7zm4loAzpNzjGFT Dleu4A7zeI1r9OS5GBL1rbamw5P5i4i0d7rnznuEpn/KsRQ8jpMJhqvFRfO1ZSnsZQ 1f1tFAW7qheOA== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nqdpc-00Bfyr-Tm; Mon, 16 May 2022 17:44:29 +0100 Date: Mon, 16 May 2022 17:44:28 +0100 Message-ID: <87ilq55swj.wl-maz@kernel.org> From: Marc Zyngier To: Raghavendra Rao Ananta Cc: Andrew Jones , James Morse , Alexandru Elisei , Suzuki K Poulose , Paolo Bonzini , Catalin Marinas , Will Deacon , Peter Shier , Ricardo Koller , Oliver Upton , Reiji Watanabe , Jing Zhang , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v7 0/9] KVM: arm64: Add support for hypercall services selection In-Reply-To: References: <20220502233853.1233742-1-rananta@google.com> <878rri8r78.wl-maz@kernel.org> <878rriicez.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: rananta@google.com, drjones@redhat.com, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, pbonzini@redhat.com, catalin.marinas@arm.com, will@kernel.org, pshier@google.com, ricarkol@google.com, oupton@google.com, reijiw@google.com, jingzhangos@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, kvm@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, 03 May 2022 22:09:29 +0100, Raghavendra Rao Ananta wrote: >=20 > On Tue, May 3, 2022 at 1:33 PM Marc Zyngier wrote: > > > > On Tue, 03 May 2022 19:49:13 +0100, > > Raghavendra Rao Ananta wrote: > > > > > > Hi Marc, > > > > > > On Tue, May 3, 2022 at 10:24 AM Marc Zyngier wrote: > > > > > > > > On Tue, 03 May 2022 00:38:44 +0100, > > > > Raghavendra Rao Ananta wrote: > > > > > > > > > > Hello, > > > > > > > > > > Continuing the discussion from [1], the series tries to add suppo= rt > > > > > for the userspace to elect the hypercall services that it wishes > > > > > to expose to the guest, rather than the guest discovering them > > > > > unconditionally. The idea employed by the series was taken from > > > > > [1] as suggested by Marc Z. > > > > > > > > As it took some time to get there, and that there was still a bunch= of > > > > things to address, I've taken the liberty to apply my own fixes to = the > > > > series. > > > > > > > > Please have a look at [1], and let me know if you're OK with the > > > > result. If you are, I'll merge the series for 5.19. > > > > > > > > Thanks, > > > > > > > > M. > > > > > > > Thank you for speeding up the process; appreciate it. However, the > > > series's selftest patches have a dependency on Oliver's > > > PSCI_SYSTEM_SUSPEND's selftest patches [1][2]. Can we pull them in > > > too? > > > > Urgh... I guess this is the time to set some ground rules: > > > > - Please don't introduce dependencies between series, that's > > unmanageable. I really need to see each series independently, and if > > there is a merge conflict, that's my job to fix (and I don't really > > mind). > > > > - If there is a dependency between series, please post a version of > > the required patches as a prefix to your series, assuming this > > prefix is itself standalone. If it isn't, then something really is > > wrong, and the series should be resplit. > > > > - You also should be basing your series on an *official* tag from > > Linus' tree (preferably -rc1, -rc2 or -rc3), and not something > > random like any odd commit from the KVM tree (I had conflicts while > > applying this on -rc3, probably due to the non-advertised dependency > > on Oliver's series). > > > Thanks for picking the dependency patches. I'll keep these mind the > next time I push changes. >=20 > > > > > > aarch64/hypercalls.c: In function =E2=80=98guest_test_hvc=E2=80=99: > > > aarch64/hypercalls.c:95:30: error: storage size of =E2=80=98res=E2=80= =99 isn=E2=80=99t known > > > 95 | struct arm_smccc_res res; > > > | ^~~ > > > aarch64/hypercalls.c:103:17: warning: implicit declaration of function > > > =E2=80=98smccc_hvc=E2=80=99 [-Wimplicit-function-declaration] > > > 103 | smccc_hvc(hc_info->func_id, hc_info->arg1, 0, > > > 0, 0, 0, 0, 0, &res); > > > | ^~~~~~~~~ > > > > > > > I've picked the two patches, which means they will most likely appear > > twice in the history. In the future, please reach out so that we can > > organise this better. > > > > > Also, just a couple of readability nits in the fixed version: > > > > > > 1. Patch-2/9, hypercall.c:kvm_hvc_call_default_allowed(), in the > > > 'default' case, do you think we should probably add a small comment > > > that mentions we are checking for func_id in the PSCI range? > > > > Dumped a one-liner there. > > > > > 2. Patch-2/9, arm_hypercall.h, clear all the macros in this patch > > > itself instead of doing it in increments (unless there's some reason > > > that I'm missing)? > > > > Ah, rebasing leftovers, now gone. > > > > I've pushed an updated branch again, please have a look. > > > Thanks for addressing these. The series looks good now. Except it doesn't. I introduced a bug by overly simplifying kvm_arm_set_fw_reg_bmap(), as we have to allow userspace writing the *same* value. As it turns out, QEMU restores all the registers on each reboot. Which as the vcpus have all run. This in turns triggers another issue in QEMU, which instead of taking the hint ans stopping there, sends all the vcpus into the guest in one go with random states... Crap happens. I'll wear a brown paper bag for the rest of the day and add the following patch to the branch. Thanks, M. =46rom 528ada2811ba0bb2b2db5bf0f829b48c50f3c13c Mon Sep 17 00:00:00 2001 From: Marc Zyngier Date: Mon, 16 May 2022 17:32:54 +0100 Subject: [PATCH] KVM: arm64: Fix hypercall bitmap writeback when vcpus have already run We generally want to disallow hypercall bitmaps being changed once vcpus have already run. But we must allow the write if the written value is unchanged so that userspace can rewrite the register file on reboot, for example. Without this, a QEMU-based VM will fail to reboot correctly. The original code was correct, and it is me that introduced the regression. Fixes: 05714cab7d63 ("KVM: arm64: Setup a framework for hypercall bitmap fi= rmware registers") Signed-off-by: Marc Zyngier --- arch/arm64/kvm/hypercalls.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm64/kvm/hypercalls.c b/arch/arm64/kvm/hypercalls.c index ccbd3cefb91a..c9f401fa01a9 100644 --- a/arch/arm64/kvm/hypercalls.c +++ b/arch/arm64/kvm/hypercalls.c @@ -379,7 +379,8 @@ static int kvm_arm_set_fw_reg_bmap(struct kvm_vcpu *vcp= u, u64 reg_id, u64 val) =20 mutex_lock(&kvm->lock); =20 - if (test_bit(KVM_ARCH_FLAG_HAS_RAN_ONCE, &kvm->arch.flags)) { + if (test_bit(KVM_ARCH_FLAG_HAS_RAN_ONCE, &kvm->arch.flags) && + val !=3D *fw_reg_bmap) { ret =3D -EBUSY; goto out; } --=20 2.34.1 --=20 Without deviation from the norm, progress is not possible.