From: Jani Nikula <jani.nikula@linux.intel.com>
To: Jiri Slaby <jslaby@suse.cz>, Jiri Slaby <jirislaby@kernel.org>,
Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: remove circ_buf.h includes
Date: Thu, 23 Dec 2021 12:52:45 +0200 [thread overview]
Message-ID: <87ilvfy4n6.fsf@intel.com> (raw)
In-Reply-To: <871r2b34gd.fsf@intel.com>
On Fri, 17 Dec 2021, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Thu, 16 Dec 2021, Patchwork <patchwork@emeril.freedesktop.org> wrote:
>> == Series Details ==
>>
>> Series: drm/i915: remove circ_buf.h includes
>> URL : https://patchwork.freedesktop.org/series/98130/
>> State : warning
>>
>> == Summary ==
>>
>> $ dim checkpatch origin/drm-tip
>> 24a5cb6b532c drm/i915: remove circ_buf.h includes
>> -:44: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jiri Slaby <jirislaby@kernel.org>' != 'Signed-off-by: Jiri Slaby <jslaby@suse.cz>'
>>
>> total: 0 errors, 1 warnings, 0 checks, 14 lines checked
>
> Now, this is interesting. The patch email has no mention of
> jirislaby@kernel.org.
>
> However, .mailmap in kernel source root has line:
>
> Jiri Slaby <jirislaby@kernel.org> <jslaby@suse.cz>
>
> indicating that you prefer jirislaby@kernel.org. When I apply the patch,
> git am looks that up, and sets:
>
> Author: Jiri Slaby <jirislaby@kernel.org>
>
> With that, we end up with an Author/Signed-off-by mismatch.
>
> If you prefer Jiri Slaby <jirislaby@kernel.org>, I think you should have
> that in git config too.
Ping.
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2021-12-23 10:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 11:59 [Intel-gfx] [PATCH] drm/i915: remove circ_buf.h includes Jiri Slaby
2021-12-16 11:59 ` Jiri Slaby
2021-12-16 11:59 ` Jiri Slaby
2021-12-16 12:23 ` [Intel-gfx] " Jani Nikula
2021-12-16 12:23 ` Jani Nikula
2021-12-16 12:23 ` Jani Nikula
2021-12-16 18:26 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2021-12-17 10:34 ` Jani Nikula
2021-12-23 10:52 ` Jani Nikula [this message]
2021-12-16 18:55 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-12-16 20:55 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilvfy4n6.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jirislaby@kernel.org \
--cc=jslaby@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.