Re: [PATCH] rtw88: 8822c: add ieee80211_ops::hw_scan

[Kalle Valo <kvalo@kernel.org>]

Ping-Ke Shih <pkshih@realtek.com> writes:

> From: Po-Hao Huang <phhuang@realtek.com>
>
> Declare this function allows us to use customized scanning policy.
> By doing so we can be more time efficient on each scan. In order to
> make existing coex mechanism work as usual, firmware notifies driver
> on each channel switch event, then decide antenna ownership based on
> the current channel/band. Do note that this new mechanism affects
> throughput more than the sw_scan we used to have, but the overall
> average throughput is not affected since each scan take less time.
> Since the firmware size is limited, we only support probe requests
> with custom IEs length under 128 bytes for now, if any user space
> tools requires more than that, we'll introduce related changes
> afterwards. For backward compatibility, we fallback to sw_scan when
> using older firmware that does not support this feature.
>
> Signed-off-by: Po-Hao Huang <phhuang@realtek.com>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>

[...]

> +void rtw_hw_scan_start(struct rtw_dev *rtwdev, struct ieee80211_vif *vif,
> +		       struct ieee80211_scan_request *scan_req)
> +{
> +	struct rtw_vif *rtwvif = (struct rtw_vif *)vif->drv_priv;
> +	struct cfg80211_scan_request *req = &scan_req->req;
> +	u8 mac_addr[ETH_ALEN];
> +
> +	rtwdev->scan_info.scanning_vif = vif;
> +	rtwvif->scan_ies = &scan_req->ies;
> +	rtwvif->scan_req = req;
> +	ieee80211_stop_queues(rtwdev->hw);
> +	if (req->flags & NL80211_SCAN_FLAG_RANDOM_ADDR)
> +		get_random_mask_addr(mac_addr, req->mac_addr,
> +				     req->mac_addr_mask);
> +	else
> +		ether_addr_copy(mac_addr, vif->addr);
> +	rtw_core_scan_start(rtwdev, rtwvif, mac_addr, true);
> +	rtwdev->hal.rcr &= ~BIT_CBSSID_BCN;
> +	rtw_write32(rtwdev, REG_RCR, rtwdev->hal.rcr);
> +}

quite a few functions in this patch are not using empty lines which
makes it harder to read the code it's like trying to read english
without punctuation please use more empty lines and send v2 :)

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches