From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 031BDC433EF for ; Tue, 7 Dec 2021 12:47:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236623AbhLGMvK (ORCPT ); Tue, 7 Dec 2021 07:51:10 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:52798 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236624AbhLGMvJ (ORCPT ); Tue, 7 Dec 2021 07:51:09 -0500 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1638881258; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rfvMhKPhb1o//czxJpD8hEyO6OfjVQhOJc2oIhKZDZw=; b=1QK7A5Quf6kWCtw53J7LvMSn21VoC3/a3rTC4N/K9KOL4NOIZguih61ltj5o2xfGP8fosF BeQwVchpb12p0y5ddl73SUOzMBu6gIMOsGkxFdl5DJrfmj1Eim1xbeRkUgaFost/P/l1rc R2cgY1UjJCMU1gjgvFUxFmbrR1966LIsSNzq5oGXncv5V0Y5vYAuEeLPzjweMxQI48uHLx MdMtGCM3OlYqjQpPgR4EUu0q413CYfgQ72I0nJ6osdk/lVoifAMucYRoeBo63dPfAw6clb UTcRGoe1SrHcnbJssHPqCjL3MC2C5BTHwEW6fNyn25OsD54B/nKqidN8WpkUhw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1638881258; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rfvMhKPhb1o//czxJpD8hEyO6OfjVQhOJc2oIhKZDZw=; b=iWRt10cM8F7Z6E8RZ9a3abFTVEBRiybM6wE8GDhsSLisml9tvmBdzmeYXcqagp5wZeqokg ZkJiPjEuHtHx+wCA== To: =?utf-8?Q?C=C3=A9dric?= Le Goater , LKML Cc: Bjorn Helgaas , Marc Zygnier , Alex Williamson , Kevin Tian , Jason Gunthorpe , Megha Dey , Ashok Raj , linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, Juergen Gross , Greg Kroah-Hartman , Will Deacon , Santosh Shilimkar , iommu@lists.linux-foundation.org, dmaengine@vger.kernel.org, Stuart Yoder , Laurentiu Tudor , Nishanth Menon , Tero Kristo , linux-arm-kernel@lists.infradead.org, Vinod Koul , Mark Rutland , Robin Murphy , Sinan Kaya Subject: Re: [patch V2 18/36] genirq/msi: Add msi_device_data::properties In-Reply-To: <6f06c9f0-1f8f-e467-b0fb-2f9985d5be0d@kaod.org> References: <20211206210307.625116253@linutronix.de> <20211206210438.634566968@linutronix.de> <6f06c9f0-1f8f-e467-b0fb-2f9985d5be0d@kaod.org> Date: Tue, 07 Dec 2021 13:47:37 +0100 Message-ID: <87ilw037km.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On Tue, Dec 07 2021 at 10:04, C=C3=A9dric Le Goater wrote: >> +/** >> + * msi_device_set_properties - Set device specific MSI properties >> + * @dev: Pointer to the device which is queried >> + * @prop: Properties to set >> + */ >> +void msi_device_set_properties(struct device *dev, unsigned long prop) >> +{ >> + if (WARN_ON_ONCE(!dev->msi.data)) >> + return ; >> + dev->msi.data->properties =3D 0; > It would work better if the prop variable was used instead of 0. > > With that fixed, Indeed. Copy & pasta w/o brain usage ... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 43C33C433F5 for ; Tue, 7 Dec 2021 12:47:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id D065C82CC7; Tue, 7 Dec 2021 12:47:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AhFA9dyyotVj; Tue, 7 Dec 2021 12:47:46 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id 9022382C61; Tue, 7 Dec 2021 12:47:45 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 5C1A1C002F; Tue, 7 Dec 2021 12:47:45 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 22C02C0012 for ; Tue, 7 Dec 2021 12:47:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id F139660680 for ; Tue, 7 Dec 2021 12:47:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=linutronix.de header.b="1QK7A5Qu"; dkim=neutral reason="invalid (unsupported algorithm ed25519-sha256)" header.d=linutronix.de header.b="iWRt10cM" Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iFpq11d08KoT for ; Tue, 7 Dec 2021 12:47:42 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by smtp3.osuosl.org (Postfix) with ESMTPS id DBE67605E3 for ; Tue, 7 Dec 2021 12:47:41 +0000 (UTC) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1638881258; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rfvMhKPhb1o//czxJpD8hEyO6OfjVQhOJc2oIhKZDZw=; b=1QK7A5Quf6kWCtw53J7LvMSn21VoC3/a3rTC4N/K9KOL4NOIZguih61ltj5o2xfGP8fosF BeQwVchpb12p0y5ddl73SUOzMBu6gIMOsGkxFdl5DJrfmj1Eim1xbeRkUgaFost/P/l1rc R2cgY1UjJCMU1gjgvFUxFmbrR1966LIsSNzq5oGXncv5V0Y5vYAuEeLPzjweMxQI48uHLx MdMtGCM3OlYqjQpPgR4EUu0q413CYfgQ72I0nJ6osdk/lVoifAMucYRoeBo63dPfAw6clb UTcRGoe1SrHcnbJssHPqCjL3MC2C5BTHwEW6fNyn25OsD54B/nKqidN8WpkUhw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1638881258; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rfvMhKPhb1o//czxJpD8hEyO6OfjVQhOJc2oIhKZDZw=; b=iWRt10cM8F7Z6E8RZ9a3abFTVEBRiybM6wE8GDhsSLisml9tvmBdzmeYXcqagp5wZeqokg ZkJiPjEuHtHx+wCA== To: =?utf-8?Q?C=C3=A9dric?= Le Goater , LKML Subject: Re: [patch V2 18/36] genirq/msi: Add msi_device_data::properties In-Reply-To: <6f06c9f0-1f8f-e467-b0fb-2f9985d5be0d@kaod.org> References: <20211206210307.625116253@linutronix.de> <20211206210438.634566968@linutronix.de> <6f06c9f0-1f8f-e467-b0fb-2f9985d5be0d@kaod.org> Date: Tue, 07 Dec 2021 13:47:37 +0100 Message-ID: <87ilw037km.ffs@tglx> MIME-Version: 1.0 Cc: Nishanth Menon , Mark Rutland , Stuart Yoder , linux-pci@vger.kernel.org, Will Deacon , Ashok Raj , Marc Zygnier , Sinan Kaya , iommu@lists.linux-foundation.org, Bjorn Helgaas , Megha Dey , Jason Gunthorpe , xen-devel@lists.xenproject.org, Kevin Tian , Alex Williamson , Santosh Shilimkar , linux-arm-kernel@lists.infradead.org, Juergen Gross , Tero Kristo , Greg Kroah-Hartman , Vinod Koul , dmaengine@vger.kernel.org, Robin Murphy X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" T24gVHVlLCBEZWMgMDcgMjAyMSBhdCAxMDowNCwgQ8OpZHJpYyBMZSBHb2F0ZXIgd3JvdGU6Cj4+ ICsvKioKPj4gKyAqIG1zaV9kZXZpY2Vfc2V0X3Byb3BlcnRpZXMgLSBTZXQgZGV2aWNlIHNwZWNp ZmljIE1TSSBwcm9wZXJ0aWVzCj4+ICsgKiBAZGV2OglQb2ludGVyIHRvIHRoZSBkZXZpY2Ugd2hp Y2ggaXMgcXVlcmllZAo+PiArICogQHByb3A6CVByb3BlcnRpZXMgdG8gc2V0Cj4+ICsgKi8KPj4g K3ZvaWQgbXNpX2RldmljZV9zZXRfcHJvcGVydGllcyhzdHJ1Y3QgZGV2aWNlICpkZXYsIHVuc2ln bmVkIGxvbmcgcHJvcCkKPj4gK3sKPj4gKwlpZiAoV0FSTl9PTl9PTkNFKCFkZXYtPm1zaS5kYXRh KSkKPj4gKwkJcmV0dXJuIDsKPj4gKwlkZXYtPm1zaS5kYXRhLT5wcm9wZXJ0aWVzID0gMDsKPiBJ dCB3b3VsZCB3b3JrIGJldHRlciBpZiB0aGUgcHJvcCB2YXJpYWJsZSB3YXMgdXNlZCBpbnN0ZWFk IG9mIDAuCj4KPiBXaXRoIHRoYXQgZml4ZWQsCgpJbmRlZWQuIENvcHkgJiBwYXN0YSB3L28gYnJh aW4gdXNhZ2UgLi4uCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmlvbW11IG1haWxpbmcgbGlzdAppb21tdUBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpo dHRwczovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby9pb21tdQ== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC27EC433EF for ; Tue, 7 Dec 2021 12:50:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CpPMMM517D8TRs5VGHxgOwk0MGuI+nxjc8l9ek3J5Dg=; b=zBGnHHuT3zE3Ny fJTY/M2oSTb1/rSUGdbd/hHR3+PQ1yvjjd4ZcPtE0CBvJfL61Mozfki6srycGV+Dxod87sqymeyfX +J9JmGd/i2WvTW+5k9diIT+tM01Ohm88bgBzncrn2BjDTDlxU8CbK4ba/rlLE8uziLUs4tCgSKbji Bxym2oneW7rNx7DELy5VYc6sc7mHZEwQ8S3iZACJNGl0+ugdKHuVx4PKdLMWLY7SuCs+kHNxL3+jm MZd2qPwf97aqqPAYhqPKrjBbhE2fKlel9P9dX9AQa1hHyr2isiiD/EoEteVip2FXGoz9orEN1DB10 zR395ZPXzN6c5nmk8nKg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1muZtn-008WcX-Ls; Tue, 07 Dec 2021 12:48:48 +0000 Received: from galois.linutronix.de ([193.142.43.55]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1muZsh-008W9w-Vs for linux-arm-kernel@lists.infradead.org; Tue, 07 Dec 2021 12:47:41 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1638881258; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rfvMhKPhb1o//czxJpD8hEyO6OfjVQhOJc2oIhKZDZw=; b=1QK7A5Quf6kWCtw53J7LvMSn21VoC3/a3rTC4N/K9KOL4NOIZguih61ltj5o2xfGP8fosF BeQwVchpb12p0y5ddl73SUOzMBu6gIMOsGkxFdl5DJrfmj1Eim1xbeRkUgaFost/P/l1rc R2cgY1UjJCMU1gjgvFUxFmbrR1966LIsSNzq5oGXncv5V0Y5vYAuEeLPzjweMxQI48uHLx MdMtGCM3OlYqjQpPgR4EUu0q413CYfgQ72I0nJ6osdk/lVoifAMucYRoeBo63dPfAw6clb UTcRGoe1SrHcnbJssHPqCjL3MC2C5BTHwEW6fNyn25OsD54B/nKqidN8WpkUhw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1638881258; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rfvMhKPhb1o//czxJpD8hEyO6OfjVQhOJc2oIhKZDZw=; b=iWRt10cM8F7Z6E8RZ9a3abFTVEBRiybM6wE8GDhsSLisml9tvmBdzmeYXcqagp5wZeqokg ZkJiPjEuHtHx+wCA== To: =?utf-8?Q?C=C3=A9dric?= Le Goater , LKML Cc: Bjorn Helgaas , Marc Zygnier , Alex Williamson , Kevin Tian , Jason Gunthorpe , Megha Dey , Ashok Raj , linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, Juergen Gross , Greg Kroah-Hartman , Will Deacon , Santosh Shilimkar , iommu@lists.linux-foundation.org, dmaengine@vger.kernel.org, Stuart Yoder , Laurentiu Tudor , Nishanth Menon , Tero Kristo , linux-arm-kernel@lists.infradead.org, Vinod Koul , Mark Rutland , Robin Murphy , Sinan Kaya Subject: Re: [patch V2 18/36] genirq/msi: Add msi_device_data::properties In-Reply-To: <6f06c9f0-1f8f-e467-b0fb-2f9985d5be0d@kaod.org> References: <20211206210307.625116253@linutronix.de> <20211206210438.634566968@linutronix.de> <6f06c9f0-1f8f-e467-b0fb-2f9985d5be0d@kaod.org> Date: Tue, 07 Dec 2021 13:47:37 +0100 Message-ID: <87ilw037km.ffs@tglx> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211207_044740_213285_D6394A60 X-CRM114-Status: UNSURE ( 9.55 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBEZWMgMDcgMjAyMSBhdCAxMDowNCwgQ8OpZHJpYyBMZSBHb2F0ZXIgd3JvdGU6Cj4+ ICsvKioKPj4gKyAqIG1zaV9kZXZpY2Vfc2V0X3Byb3BlcnRpZXMgLSBTZXQgZGV2aWNlIHNwZWNp ZmljIE1TSSBwcm9wZXJ0aWVzCj4+ICsgKiBAZGV2OglQb2ludGVyIHRvIHRoZSBkZXZpY2Ugd2hp Y2ggaXMgcXVlcmllZAo+PiArICogQHByb3A6CVByb3BlcnRpZXMgdG8gc2V0Cj4+ICsgKi8KPj4g K3ZvaWQgbXNpX2RldmljZV9zZXRfcHJvcGVydGllcyhzdHJ1Y3QgZGV2aWNlICpkZXYsIHVuc2ln bmVkIGxvbmcgcHJvcCkKPj4gK3sKPj4gKwlpZiAoV0FSTl9PTl9PTkNFKCFkZXYtPm1zaS5kYXRh KSkKPj4gKwkJcmV0dXJuIDsKPj4gKwlkZXYtPm1zaS5kYXRhLT5wcm9wZXJ0aWVzID0gMDsKPiBJ dCB3b3VsZCB3b3JrIGJldHRlciBpZiB0aGUgcHJvcCB2YXJpYWJsZSB3YXMgdXNlZCBpbnN0ZWFk IG9mIDAuCj4KPiBXaXRoIHRoYXQgZml4ZWQsCgpJbmRlZWQuIENvcHkgJiBwYXN0YSB3L28gYnJh aW4gdXNhZ2UgLi4uCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3Rz LmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5m by9saW51eC1hcm0ta2VybmVsCg==