Re: [Buildroot] [PATCH v2 1/1] utils/getdeveloperlib.py: explicitly set devs document encoding

[Peter Korsgaard <peter@korsgaard.com>]

>>>>> "James" == James Knight <james.d.knight@live.com> writes:

 > Explicitly indicate the file encoding to UTF-8 for the DEVELOPERS
 > document. This prevents Unicode decoding errors when printing E-Mail
 > entries with Unicode characters on systems using an alternative default
 > encoding (e.g. 'CP1252').

 > This corrects the following observed error:

 >     $ ./utils/get-developers outgoing/*
 >     Traceback (most recent call last):
 >       File "utils\get-developers", line 105, in <module>
 >         __main__()
 >       File "utils\get-developers", line 47, in __main__
 >         devs = getdeveloperlib.parse_developers()
 >       File "...\buildroot\utils\getdeveloperlib.py", line 239, in parse_developers
 >         for line in f:
 >       File "...\Python<ver>\lib\encodings\cp1252.py", line 23, in decode
 >         return codecs.charmap_decode(input,self.errors,decoding_table)[0]
 >     UnicodeDecodeError: 'charmap' codec can't decode byte 0x81 in position 6659: character maps to <undefined>

 > Signed-off-by: James Knight <james.d.knight@live.com>

Hmm, this doesn't quite seem to work when stdout is not a UTF-8 console
(E.G. when using as git send-email --cc-cmd):

echo $LANG
en_DK.UTF-8

./utils/get-developers -p libyang
Heiko Thiery <heiko.thiery@gmail.com>
Jan Kundrát <jan.kundrat@cesnet.cz>

LANG=C ./utils/get-developers -p libyang
Heiko Thiery <heiko.thiery@gmail.com>
Traceback (most recent call last):
  File "./utils/get-developers", line 105, in <module>
    __main__()
  File "./utils/get-developers", line 68, in __main__
    print(dev.name)
UnicodeEncodeError: 'ascii' codec can't encode character u'\xe1' in position 9: ordinal not in range(128)

./utils/get-developers -p libyang | cat
Traceback (most recent call last):
  File "./utils/get-developers", line 105, in <module>
    __main__()
  File "./utils/get-developers", line 68, in __main__
    Heiko Thiery <heiko.thiery@gmail.com>
print(dev.name)
UnicodeEncodeError: 'ascii' codec can't encode character u'\xe1' in position 9: ordinal not in range(128)


Reverting 9f127cc420884ad fixes it:

./utils/get-developers -p libyang
Heiko Thiery <heiko.thiery@gmail.com>
Jan Kundrát <jan.kundrat@cesnet.cz>

LANG=C ./utils/get-developers -p libyang
Heiko Thiery <heiko.thiery@gmail.com>
Jan Kundrát <jan.kundrat@cesnet.cz>

./utils/get-developers -p libyang | cat
Heiko Thiery <heiko.thiery@gmail.com>
Jan Kundrát <jan.kundrat@cesnet.cz>


Any idea about how to fix this, or should it just be reverted?

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot