All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Lukas Jünger" <lukas.junger@greensocs.com>
Cc: erdnaxe@crans.org, ma.mandourr@gmail.com, qemu-devel@nongnu.org
Subject: Re: [PATCH 0/1] Add missing function names to symbol list
Date: Tue, 07 Sep 2021 12:43:57 +0100	[thread overview]
Message-ID: <87ilzcy593.fsf@linaro.org> (raw)
In-Reply-To: <20210905140939.638928-1-lukas.junger@greensocs.com>


Lukas Jünger <lukas.junger@greensocs.com> writes:

> Hi all,
>
> I have been trying to use the hwprofile and cache plugin on
> qemu-system-riscv64. They failed to load with an undefined
> symbol error. It looks like some of the plugin API functions
> are missing from the symbol list, so I added them.

Heh I had a similar patch in plugins/next but yours includes more
symbols so queued to plugins/next, thanks. Not sure how I missed it
before - I think we might not have been honouring the symbol list
before.

> Afterwards
> the plugins worked (eventhough the cache plugin is segfaulting
> on shutdown, but that is a separate, unrelated issue).

Has this been tracked down yet? There is a fix f7e68c9c99 (tcg/plugins:
implement a qemu_plugin_user_exit helper) which was for user mode. At
the time I didn't think system mode would be affected due to the atexit
callback only being called once vCPUs had shutdown.

>
> Hope that's okay.
>
> BR,
> Lukas
>
> Lukas Jünger (1):
>   plugins/: Add missing functions to symbol list
>
>  plugins/qemu-plugins.symbols | 3 +++
>  1 file changed, 3 insertions(+)


-- 
Alex Bennée


  parent reply	other threads:[~2021-09-07 11:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-05 14:09 [PATCH 0/1] Add missing function names to symbol list Lukas Jünger
2021-09-05 14:09 ` [PATCH 1/1] plugins/: Add missing functions " Lukas Jünger
2021-09-07 11:43 ` Alex Bennée [this message]
2021-10-18 10:55   ` [PATCH 0/1] Add missing function names " Lukas Jünger
2021-10-18 11:18     ` Alex Bennée
2021-10-18 12:16       ` Lukas Jünger
2021-10-18 12:49         ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ilzcy593.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=erdnaxe@crans.org \
    --cc=lukas.junger@greensocs.com \
    --cc=ma.mandourr@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.