From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by gabe.freedesktop.org (Postfix) with ESMTPS id B526B6E979
 for <igt-dev@lists.freedesktop.org>; Tue,  3 Aug 2021 23:07:10 +0000 (UTC)
Date: Tue, 03 Aug 2021 16:07:07 -0700
Message-ID: <87im0mku04.wl-ashutosh.dixit@intel.com>
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
In-Reply-To: <20210726200026.4815-2-zbigniew.kempczynski@intel.com>
References: <20210726200026.4815-1-zbigniew.kempczynski@intel.com>
 <20210726200026.4815-2-zbigniew.kempczynski@intel.com>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=ISO-8859-2
Content-Transfer-Encoding: quoted-printable
Subject: Re: [igt-dev] [PATCH i-g-t v3 01/52] lib/igt_dummyload: Add support
 of using allocator in igt spinner
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
To: Zbigniew =?ISO-8859-2?Q?Kempczy=F1ski?= <zbigniew.kempczynski@intel.com>
Cc: igt-dev@lists.freedesktop.org, Petri Latvala <petri.latvala@intel.com>, Chris Wilson <chris@chris-wilson.co.uk>
List-ID: <igt-dev@lists.freedesktop.org>

On Mon, 26 Jul 2021 12:59:35 -0700, Zbigniew Kempczy=F1ski wrote:
>
> @@ -164,16 +171,34 @@ emit_recursive_batch(igt_spin_t *spin,
>	execbuf->buffer_count++;
>	cs =3D spin->batch;
>
> -	obj[BATCH].offset =3D addr;
> +	if (ahnd)
> +		addr =3D intel_allocator_alloc_with_strategy(ahnd, obj[BATCH].handle,
> +							   BATCH_SIZE, 0,
> +							   ALLOC_STRATEGY_LOW_TO_HIGH);

Is the strategy argument just for debug, so that spin offsets look
different from offsets for other objects? Since everyone should be
allocating from the same allocator which is managing offsets this should
probably not be needed?

In any case, the patch is great, so this is:

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>