diff for duplicates of <87im1a2i5k.fsf@linux.ibm.com> diff --git a/a/1.txt b/N1/1.txt index 34c0bb9..7a61495 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -68,7 +68,7 @@ Extra line here. > + int ret = 0; > + > + t_buf = kmalloc(MAX_BUF_SZ, GFP_KERNEL); -> + if (t_buf = NULL) +> + if (t_buf == NULL) > + return -ENOMEM; > + > + ret = plpar_hcall_norets(H_GET_ENERGY_SCALE_INFO, ESI_FLAGS_SINGLE, @@ -108,7 +108,7 @@ Extra line here. > + int ret = 0; > + > + t_buf = kmalloc(MAX_BUF_SZ, GFP_KERNEL); -> + if (t_buf = NULL) +> + if (t_buf == NULL) > + return -ENOMEM; > + > + ret = plpar_hcall_norets(H_GET_ENERGY_SCALE_INFO, ESI_FLAGS_SINGLE, @@ -150,7 +150,7 @@ Extra line here. > + int ret = 0; > + > + t_buf = kmalloc(MAX_BUF_SZ, GFP_KERNEL); -> + if (t_buf = NULL) +> + if (t_buf == NULL) > + return -ENOMEM; > + > + ret = plpar_hcall_norets(H_GET_ENERGY_SCALE_INFO, ESI_FLAGS_SINGLE, @@ -227,7 +227,7 @@ Could use MAX_ATTRS directly. > + return -ENXIO; > + > + esi_buf = kmalloc(MAX_BUF_SZ, GFP_KERNEL); -> + if (esi_buf = NULL) +> + if (esi_buf == NULL) > + return -ENOMEM; > + /* > + * hcall( @@ -284,13 +284,13 @@ What about the attrs allocated during the previous iterations? > + > + pgs[idx].pg.name = kasprintf(GFP_KERNEL, "%lld", > + be64_to_cpu(esi_attrs[idx].id)); -> + if (pgs[idx].pg.name = NULL) { +> + if (pgs[idx].pg.name == NULL) { > + for (i = idx; i >= 0; i--) > + kfree(pgs[i].pg.attrs); > + goto out_ekobj; > + } > + /* Do not add the value description if it does not exist */ -> + if (strlen(esi_attrs[idx].value_desc) = 0) +> + if (strlen(esi_attrs[idx].value_desc) == 0) strnlen diff --git a/a/content_digest b/N1/content_digest index acc880f..409c0ff 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\020210716152133.72455-2-psampat@linux.ibm.com\0" "From\0Fabiano Rosas <farosas@linux.ibm.com>\0" "Subject\0Re: [PATCH v4 1/1] powerpc/pseries: Interface to represent PAPR firmware attributes\0" - "Date\0Fri, 16 Jul 2021 19:05:59 +0000\0" + "Date\0Fri, 16 Jul 2021 16:05:59 -0300\0" "To\0Pratik R. Sampat <psampat@linux.ibm.com>" mpe@ellerman.id.au benh@kernel.crashing.org @@ -84,7 +84,7 @@ "> +\tint ret = 0;\n" "> +\n" "> +\tt_buf = kmalloc(MAX_BUF_SZ, GFP_KERNEL);\n" - "> +\tif (t_buf = NULL)\n" + "> +\tif (t_buf == NULL)\n" "> +\t\treturn -ENOMEM;\n" "> +\n" "> +\tret = plpar_hcall_norets(H_GET_ENERGY_SCALE_INFO, ESI_FLAGS_SINGLE,\n" @@ -124,7 +124,7 @@ "> +\tint ret = 0;\n" "> +\n" "> +\tt_buf = kmalloc(MAX_BUF_SZ, GFP_KERNEL);\n" - "> +\tif (t_buf = NULL)\n" + "> +\tif (t_buf == NULL)\n" "> +\t\treturn -ENOMEM;\n" "> +\n" "> +\tret = plpar_hcall_norets(H_GET_ENERGY_SCALE_INFO, ESI_FLAGS_SINGLE,\n" @@ -166,7 +166,7 @@ "> +\tint ret = 0;\n" "> +\n" "> +\tt_buf = kmalloc(MAX_BUF_SZ, GFP_KERNEL);\n" - "> +\tif (t_buf = NULL)\n" + "> +\tif (t_buf == NULL)\n" "> +\t\treturn -ENOMEM;\n" "> +\n" "> +\tret = plpar_hcall_norets(H_GET_ENERGY_SCALE_INFO, ESI_FLAGS_SINGLE,\n" @@ -243,7 +243,7 @@ "> +\t\treturn -ENXIO;\n" "> +\n" "> +\tesi_buf = kmalloc(MAX_BUF_SZ, GFP_KERNEL);\n" - "> +\tif (esi_buf = NULL)\n" + "> +\tif (esi_buf == NULL)\n" "> +\t\treturn -ENOMEM;\n" "> +\t/*\n" "> +\t * hcall(\n" @@ -300,13 +300,13 @@ "> +\n" "> +\t\tpgs[idx].pg.name = kasprintf(GFP_KERNEL, \"%lld\",\n" "> +\t\t\t\t\t be64_to_cpu(esi_attrs[idx].id));\n" - "> +\t\tif (pgs[idx].pg.name = NULL) {\n" + "> +\t\tif (pgs[idx].pg.name == NULL) {\n" "> +\t\t\tfor (i = idx; i >= 0; i--)\n" "> +\t\t\t\tkfree(pgs[i].pg.attrs);\n" "> +\t\t\tgoto out_ekobj;\n" "> +\t\t}\n" "> +\t\t/* Do not add the value description if it does not exist */\n" - "> +\t\tif (strlen(esi_attrs[idx].value_desc) = 0)\n" + "> +\t\tif (strlen(esi_attrs[idx].value_desc) == 0)\n" "\n" "strnlen\n" "\n" @@ -345,4 +345,4 @@ "> +\n" > +machine_device_initcall(pseries, papr_init); -3add382f71c96acca14865d6639f2fae978e68cb63809cdca35bdfa78e8111fa +8ef9d9a430f9c232965e74a348a3df25c9f234b4dcd72a721652e39ad8133b99
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.