From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00112C433ED for ; Fri, 23 Apr 2021 11:02:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3788661461 for ; Fri, 23 Apr 2021 11:02:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3788661461 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41514 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZtaI-0003pu-M7 for qemu-devel@archiver.kernel.org; Fri, 23 Apr 2021 07:02:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59536) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZtYR-0003Ap-9E for qemu-devel@nongnu.org; Fri, 23 Apr 2021 07:01:00 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:43807) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZtYK-0004Zz-Pu for qemu-devel@nongnu.org; Fri, 23 Apr 2021 07:00:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619175651; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GZgREW0Nq8tZqCAT28DFkDPbyTcBL7gWXHpM3hw4ph4=; b=WKKGCVfBo3F3zWLDQnVWL5Km9vlVL5GR1OVUE5V9ZA0EbznCDtcu8RflloEeWZ5CxiDv1i 137a5KfpmT0xfamI3oCE7MhQf4IsJIzXp37W1VxqLwk06SLCvyK7Uh+HqvgxNTnhtyNKf9 KJ0WDIPy+NQTELwy2X4txpr/b5aaZNo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-497-Od3U1gdsPP2hrjhHpHJ6Cg-1; Fri, 23 Apr 2021 07:00:47 -0400 X-MC-Unique: Od3U1gdsPP2hrjhHpHJ6Cg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C2DF5107ACC7; Fri, 23 Apr 2021 11:00:46 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-114-17.ams2.redhat.com [10.36.114.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5BF1760CEC; Fri, 23 Apr 2021 11:00:32 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id CD444113525D; Fri, 23 Apr 2021 13:00:30 +0200 (CEST) From: Markus Armbruster To: David Hildenbrand Subject: Re: [PATCH v6 14/15] qmp: Include "reserve" property of memory backends References: <20210421122624.12292-1-david@redhat.com> <20210421122624.12292-15-david@redhat.com> Date: Fri, 23 Apr 2021 13:00:30 +0200 In-Reply-To: <20210421122624.12292-15-david@redhat.com> (David Hildenbrand's message of "Wed, 21 Apr 2021 14:26:23 +0200") Message-ID: <87im4di7u9.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=216.205.24.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marcel Apfelbaum , Eduardo Habkost , "Michael S. Tsirkin" , Richard Henderson , qemu-devel@nongnu.org, Peter Xu , "Dr. David Alan Gilbert" , Greg Kurz , Paolo Bonzini , Stefan Hajnoczi , Murilo Opsfelder Araujo , Igor Mammedov , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" David Hildenbrand writes: > Let's include the new property. > > Reviewed-by: Philippe Mathieu-Daud=C3=A9 > Cc: Eric Blake > Cc: Markus Armbruster > Cc: Igor Mammedov > Signed-off-by: David Hildenbrand > --- > hw/core/machine-qmp-cmds.c | 1 + > qapi/machine.json | 4 ++++ > 2 files changed, 5 insertions(+) > > diff --git a/hw/core/machine-qmp-cmds.c b/hw/core/machine-qmp-cmds.c > index d41db5b93b..2d135ecdd0 100644 > --- a/hw/core/machine-qmp-cmds.c > +++ b/hw/core/machine-qmp-cmds.c > @@ -175,6 +175,7 @@ static int query_memdev(Object *obj, void *opaque) > m->dump =3D object_property_get_bool(obj, "dump", &error_abort); > m->prealloc =3D object_property_get_bool(obj, "prealloc", &error= _abort); > m->share =3D object_property_get_bool(obj, "share", &error_abort= ); > + m->reserve =3D object_property_get_bool(obj, "reserve", &error_a= bort); > m->policy =3D object_property_get_enum(obj, "policy", "HostMemPo= licy", > &error_abort); > host_nodes =3D object_property_get_qobject(obj, > diff --git a/qapi/machine.json b/qapi/machine.json > index 32650bfe9e..5932139d20 100644 > --- a/qapi/machine.json > +++ b/qapi/machine.json > @@ -798,6 +798,9 @@ > # > # @share: whether memory is private to QEMU or shared (since 6.1) > # > +# @reserve: whether swap space (or huge pages) was reserved if applicabl= e > +# (since 6.1) > +# > # @host-nodes: host nodes for its memory policy > # > # @policy: memory policy of memory backend > @@ -812,6 +815,7 @@ > 'dump': 'bool', > 'prealloc': 'bool', > 'share': 'bool', > + 'reserve': 'bool', > 'host-nodes': ['uint16'], > 'policy': 'HostMemPolicy' }} Double-checking: true means definitely reserved, and false means definitely not reserved. Correct? I'm asking because the discussion of v4 + passage of time =3D me uncertain.