From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7F74C433ED for ; Tue, 6 Apr 2021 13:02:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B839613CD for ; Tue, 6 Apr 2021 13:02:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239139AbhDFNCw convert rfc822-to-8bit (ORCPT ); Tue, 6 Apr 2021 09:02:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:52512 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233048AbhDFNCw (ORCPT ); Tue, 6 Apr 2021 09:02:52 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 19E9F613CA; Tue, 6 Apr 2021 13:02:44 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lTlLu-005rUM-0s; Tue, 06 Apr 2021 14:02:42 +0100 Date: Tue, 06 Apr 2021 14:02:41 +0100 Message-ID: <87im4zpnv2.wl-maz@kernel.org> From: Marc Zyngier To: Geert Uytterhoeven Cc: Linux ARM , Linux Kernel Mailing List , "open list:BROADCOM NVRAM DRIVER" , linuxppc-dev , Linux-sh list , Daniel Mack , Robert Jarzmik , Haojian Zhuang , Yoshinori Sato , Rich Felker , Thomas Bogendoerfer , Michael Ellerman , Thomas Gleixner Subject: Re: [PATCH 4/9] sh: intc: Drop the use of irq_create_identity_mapping() In-Reply-To: References: <20210406093557.1073423-1-maz@kernel.org> <20210406093557.1073423-5-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: geert@linux-m68k.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, daniel@zonque.org, robert.jarzmik@free.fr, haojian.zhuang@gmail.com, ysato@users.sourceforge.jp, dalias@libc.org, tsbogend@alpha.franken.de, mpe@ellerman.id.au, tglx@linutronix.de X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Tue, 06 Apr 2021 11:32:13 +0100, Geert Uytterhoeven wrote: > > Hi Marc, > > On Tue, Apr 6, 2021 at 11:44 AM Marc Zyngier wrote: > > Instead of playing games with using irq_create_identity_mapping() > > and irq_domain_associate(), drop the use of the former and only > > use the latter, together with the allocation of the irq_desc > > as needed. > > > > It doesn't make the code less awful, but at least the intent > > is clearer. > > > > Signed-off-by: Marc Zyngier > > Thanks for your patch! > > > --- a/drivers/sh/intc/core.c > > +++ b/drivers/sh/intc/core.c > > @@ -179,6 +179,23 @@ static unsigned int __init save_reg(struct intc_desc_int *d, > > return 0; > > } > > > > +static bool __init intc_map(struct irq_domain *domain, int irq) > > +{ > > + int res; > > warning: unused variable ‘res’ [-Wunused-variable] > > > + > > + if (!irq_to_desc(irq) && irq_alloc_desc_at(irq, NUMA_NO_NODE) != irq) { > > + pr_err("uname to allocate IRQ %d\n", irq); > > + return false; > > + } > > + > > + if (irq_domain_associate(domain, irq, irq)) { > > + pr_err("domain association failure\n"); > > + return false; > > + } > > + > > + return true; > > +} > > + > > int __init register_intc_controller(struct intc_desc *desc) > > { > > unsigned int i, k, smp; > > @@ -316,19 +333,8 @@ int __init register_intc_controller(struct intc_desc *desc) > > warning: unused variable ‘res’ [-Wunused-variable] Ah, thanks for spotting these. > > > if (!vect->enum_id) > > continue; > > > > - res = irq_create_identity_mapping(d->domain, irq); > > > > - if (unlikely(res)) { > > - if (res == -EEXIST) { > > - res = irq_domain_associate(d->domain, irq, irq); > > - if (unlikely(res)) { > > - pr_err("domain association failure\n"); > > - continue; > > - } > > - } else { > > - pr_err("can't identity map IRQ %d\n", irq); > > - continue; > > - } > > - } > > + if (!intc_map(d->domain, irq)) > > + continue; > > > > intc_irq_xlate_set(irq, vect->enum_id, d); > > intc_register_irq(desc, d, vect->enum_id, irq); > > Otherwise this seems to work fine on real hardware (landisk) and qemu > (rts7751r2d). I did verify that the new function intc_map() is called. > > Tested-by: Geert Uytterhoeven Awesome, thanks Geert. M. -- Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FCD6C433ED for ; Tue, 6 Apr 2021 13:03:10 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 69F8C6117A for ; Tue, 6 Apr 2021 13:03:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69F8C6117A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FF74C5G8Dz3bvX for ; Tue, 6 Apr 2021 23:03:07 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=maz@kernel.org; receiver=) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FF73q24Hlz2yxq for ; Tue, 6 Apr 2021 23:02:47 +1000 (AEST) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 19E9F613CA; Tue, 6 Apr 2021 13:02:44 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lTlLu-005rUM-0s; Tue, 06 Apr 2021 14:02:42 +0100 Date: Tue, 06 Apr 2021 14:02:41 +0100 Message-ID: <87im4zpnv2.wl-maz@kernel.org> From: Marc Zyngier To: Geert Uytterhoeven Subject: Re: [PATCH 4/9] sh: intc: Drop the use of irq_create_identity_mapping() In-Reply-To: References: <20210406093557.1073423-1-maz@kernel.org> <20210406093557.1073423-5-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: geert@linux-m68k.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, daniel@zonque.org, robert.jarzmik@free.fr, haojian.zhuang@gmail.com, ysato@users.sourceforge.jp, dalias@libc.org, tsbogend@alpha.franken.de, mpe@ellerman.id.au, tglx@linutronix.de X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , Yoshinori Sato , Linux-sh list , Robert Jarzmik , Linux Kernel Mailing List , Haojian Zhuang , "open list:BROADCOM NVRAM DRIVER" , Thomas Bogendoerfer , Linux ARM , Thomas Gleixner , linuxppc-dev , Daniel Mack Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, 06 Apr 2021 11:32:13 +0100, Geert Uytterhoeven wrote: >=20 > Hi Marc, >=20 > On Tue, Apr 6, 2021 at 11:44 AM Marc Zyngier wrote: > > Instead of playing games with using irq_create_identity_mapping() > > and irq_domain_associate(), drop the use of the former and only > > use the latter, together with the allocation of the irq_desc > > as needed. > > > > It doesn't make the code less awful, but at least the intent > > is clearer. > > > > Signed-off-by: Marc Zyngier >=20 > Thanks for your patch! >=20 > > --- a/drivers/sh/intc/core.c > > +++ b/drivers/sh/intc/core.c > > @@ -179,6 +179,23 @@ static unsigned int __init save_reg(struct intc_de= sc_int *d, > > return 0; > > } > > > > +static bool __init intc_map(struct irq_domain *domain, int irq) > > +{ > > + int res; >=20 > warning: unused variable =E2=80=98res=E2=80=99 [-Wunused-variable] >=20 > > + > > + if (!irq_to_desc(irq) && irq_alloc_desc_at(irq, NUMA_NO_NODE) != =3D irq) { > > + pr_err("uname to allocate IRQ %d\n", irq); > > + return false; > > + } > > + > > + if (irq_domain_associate(domain, irq, irq)) { > > + pr_err("domain association failure\n"); > > + return false; > > + } > > + > > + return true; > > +} > > + > > int __init register_intc_controller(struct intc_desc *desc) > > { > > unsigned int i, k, smp; > > @@ -316,19 +333,8 @@ int __init register_intc_controller(struct intc_de= sc *desc) >=20 > warning: unused variable =E2=80=98res=E2=80=99 [-Wunused-variable] Ah, thanks for spotting these. >=20 > > if (!vect->enum_id) > > continue; > > > > - res =3D irq_create_identity_mapping(d->domain, irq); >=20 >=20 > > - if (unlikely(res)) { > > - if (res =3D=3D -EEXIST) { > > - res =3D irq_domain_associate(d->domain,= irq, irq); > > - if (unlikely(res)) { > > - pr_err("domain association fail= ure\n"); > > - continue; > > - } > > - } else { > > - pr_err("can't identity map IRQ %d\n", i= rq); > > - continue; > > - } > > - } > > + if (!intc_map(d->domain, irq)) > > + continue; > > > > intc_irq_xlate_set(irq, vect->enum_id, d); > > intc_register_irq(desc, d, vect->enum_id, irq); >=20 > Otherwise this seems to work fine on real hardware (landisk) and qemu > (rts7751r2d). I did verify that the new function intc_map() is called. >=20 > Tested-by: Geert Uytterhoeven Awesome, thanks Geert. M. --=20 Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FCA1C433B4 for ; Tue, 6 Apr 2021 13:04:45 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1302B613A3 for ; Tue, 6 Apr 2021 13:04:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1302B613A3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:Cc:To: From:Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vT2ppFgTm0NCmju2995gOpIaZfDLcqkmvcblrWF42IM=; b=ZhCg9DHGfHfJpfFlyW/9RX26/ W0W8+CuraMWqPpnoUEt1oo3nv0o/DifQ+Gnu4NT13R7C4EqmfWNKrR15Qb52td72FXktJ5oBXqhS9 t2ovQDHkGYtL9DI0sgSkj/rlqjOuaLFYatmP6YGwBzKVksu6MiI7p3kUfcLddcV24WDCWDMkLu7/D eE2QlbzXWaNA/V7m9MplzRNawCAeEqoevk5PfH29jyH3pDV8eDJbOhG35tY/X030j6Fk6qbhggLaN n2EIg0d9+iXjNPJMNyEgJ/ds1PRAN1n3ky4LkyYqtq8xpV9IKYv6Kz+nKV7JLFj4QOjuFak0iDaXu jNHsmZxmQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lTlM2-002eaH-LH; Tue, 06 Apr 2021 13:02:50 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lTlLx-002eYa-Kx for linux-arm-kernel@lists.infradead.org; Tue, 06 Apr 2021 13:02:47 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 19E9F613CA; Tue, 6 Apr 2021 13:02:44 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lTlLu-005rUM-0s; Tue, 06 Apr 2021 14:02:42 +0100 Date: Tue, 06 Apr 2021 14:02:41 +0100 Message-ID: <87im4zpnv2.wl-maz@kernel.org> From: Marc Zyngier To: Geert Uytterhoeven Cc: Linux ARM , Linux Kernel Mailing List , "open list:BROADCOM NVRAM DRIVER" , linuxppc-dev , Linux-sh list , Daniel Mack , Robert Jarzmik , Haojian Zhuang , Yoshinori Sato , Rich Felker , Thomas Bogendoerfer , Michael Ellerman , Thomas Gleixner Subject: Re: [PATCH 4/9] sh: intc: Drop the use of irq_create_identity_mapping() In-Reply-To: References: <20210406093557.1073423-1-maz@kernel.org> <20210406093557.1073423-5-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: geert@linux-m68k.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, daniel@zonque.org, robert.jarzmik@free.fr, haojian.zhuang@gmail.com, ysato@users.sourceforge.jp, dalias@libc.org, tsbogend@alpha.franken.de, mpe@ellerman.id.au, tglx@linutronix.de X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210406_140246_042109_4B6886BC X-CRM114-Status: GOOD ( 27.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAwNiBBcHIgMjAyMSAxMTozMjoxMyArMDEwMCwKR2VlcnQgVXl0dGVyaG9ldmVuIDxn ZWVydEBsaW51eC1tNjhrLm9yZz4gd3JvdGU6Cj4gCj4gSGkgTWFyYywKPiAKPiBPbiBUdWUsIEFw ciA2LCAyMDIxIGF0IDExOjQ0IEFNIE1hcmMgWnluZ2llciA8bWF6QGtlcm5lbC5vcmc+IHdyb3Rl Ogo+ID4gSW5zdGVhZCBvZiBwbGF5aW5nIGdhbWVzIHdpdGggdXNpbmcgaXJxX2NyZWF0ZV9pZGVu dGl0eV9tYXBwaW5nKCkKPiA+IGFuZCBpcnFfZG9tYWluX2Fzc29jaWF0ZSgpLCBkcm9wIHRoZSB1 c2Ugb2YgdGhlIGZvcm1lciBhbmQgb25seQo+ID4gdXNlIHRoZSBsYXR0ZXIsIHRvZ2V0aGVyIHdp dGggdGhlIGFsbG9jYXRpb24gb2YgdGhlIGlycV9kZXNjCj4gPiBhcyBuZWVkZWQuCj4gPgo+ID4g SXQgZG9lc24ndCBtYWtlIHRoZSBjb2RlIGxlc3MgYXdmdWwsIGJ1dCBhdCBsZWFzdCB0aGUgaW50 ZW50Cj4gPiBpcyBjbGVhcmVyLgo+ID4KPiA+IFNpZ25lZC1vZmYtYnk6IE1hcmMgWnluZ2llciA8 bWF6QGtlcm5lbC5vcmc+Cj4gCj4gVGhhbmtzIGZvciB5b3VyIHBhdGNoIQo+IAo+ID4gLS0tIGEv ZHJpdmVycy9zaC9pbnRjL2NvcmUuYwo+ID4gKysrIGIvZHJpdmVycy9zaC9pbnRjL2NvcmUuYwo+ ID4gQEAgLTE3OSw2ICsxNzksMjMgQEAgc3RhdGljIHVuc2lnbmVkIGludCBfX2luaXQgc2F2ZV9y ZWcoc3RydWN0IGludGNfZGVzY19pbnQgKmQsCj4gPiAgICAgICAgIHJldHVybiAwOwo+ID4gIH0K PiA+Cj4gPiArc3RhdGljIGJvb2wgX19pbml0IGludGNfbWFwKHN0cnVjdCBpcnFfZG9tYWluICpk b21haW4sIGludCBpcnEpCj4gPiArewo+ID4gKyAgICAgICBpbnQgcmVzOwo+IAo+IHdhcm5pbmc6 IHVudXNlZCB2YXJpYWJsZSDigJhyZXPigJkgWy1XdW51c2VkLXZhcmlhYmxlXQo+IAo+ID4gKwo+ ID4gKyAgICAgICBpZiAoIWlycV90b19kZXNjKGlycSkgJiYgaXJxX2FsbG9jX2Rlc2NfYXQoaXJx LCBOVU1BX05PX05PREUpICE9IGlycSkgewo+ID4gKyAgICAgICAgICAgICAgIHByX2VycigidW5h bWUgdG8gYWxsb2NhdGUgSVJRICVkXG4iLCBpcnEpOwo+ID4gKyAgICAgICAgICAgICAgIHJldHVy biBmYWxzZTsKPiA+ICsgICAgICAgfQo+ID4gKwo+ID4gKyAgICAgICBpZiAoaXJxX2RvbWFpbl9h c3NvY2lhdGUoZG9tYWluLCBpcnEsIGlycSkpIHsKPiA+ICsgICAgICAgICAgICAgICBwcl9lcnIo ImRvbWFpbiBhc3NvY2lhdGlvbiBmYWlsdXJlXG4iKTsKPiA+ICsgICAgICAgICAgICAgICByZXR1 cm4gZmFsc2U7Cj4gPiArICAgICAgIH0KPiA+ICsKPiA+ICsgICAgICAgcmV0dXJuIHRydWU7Cj4g PiArfQo+ID4gKwo+ID4gIGludCBfX2luaXQgcmVnaXN0ZXJfaW50Y19jb250cm9sbGVyKHN0cnVj dCBpbnRjX2Rlc2MgKmRlc2MpCj4gPiAgewo+ID4gICAgICAgICB1bnNpZ25lZCBpbnQgaSwgaywg c21wOwo+ID4gQEAgLTMxNiwxOSArMzMzLDggQEAgaW50IF9faW5pdCByZWdpc3Rlcl9pbnRjX2Nv bnRyb2xsZXIoc3RydWN0IGludGNfZGVzYyAqZGVzYykKPiAKPiB3YXJuaW5nOiB1bnVzZWQgdmFy aWFibGUg4oCYcmVz4oCZIFstV3VudXNlZC12YXJpYWJsZV0KCkFoLCB0aGFua3MgZm9yIHNwb3R0 aW5nIHRoZXNlLgoKPiAKPiA+ICAgICAgICAgICAgICAgICBpZiAoIXZlY3QtPmVudW1faWQpCj4g PiAgICAgICAgICAgICAgICAgICAgICAgICBjb250aW51ZTsKPiA+Cj4gPiAtICAgICAgICAgICAg ICAgcmVzID0gaXJxX2NyZWF0ZV9pZGVudGl0eV9tYXBwaW5nKGQtPmRvbWFpbiwgaXJxKTsKPiAK PiAKPiA+IC0gICAgICAgICAgICAgICBpZiAodW5saWtlbHkocmVzKSkgewo+ID4gLSAgICAgICAg ICAgICAgICAgICAgICAgaWYgKHJlcyA9PSAtRUVYSVNUKSB7Cj4gPiAtICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHJlcyA9IGlycV9kb21haW5fYXNzb2NpYXRlKGQtPmRvbWFpbiwgaXJx LCBpcnEpOwo+ID4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpZiAodW5saWtlbHko cmVzKSkgewo+ID4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHByX2Vy cigiZG9tYWluIGFzc29jaWF0aW9uIGZhaWx1cmVcbiIpOwo+ID4gLSAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOwo+ID4gLSAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICB9Cj4gPiAtICAgICAgICAgICAgICAgICAgICAgICB9IGVsc2Ugewo+ID4gLSAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwcl9lcnIoImNhbid0IGlkZW50aXR5IG1hcCBJ UlEgJWRcbiIsIGlycSk7Cj4gPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnRp bnVlOwo+ID4gLSAgICAgICAgICAgICAgICAgICAgICAgfQo+ID4gLSAgICAgICAgICAgICAgIH0K PiA+ICsgICAgICAgICAgICAgICBpZiAoIWludGNfbWFwKGQtPmRvbWFpbiwgaXJxKSkKPiA+ICsg ICAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOwo+ID4KPiA+ICAgICAgICAgICAgICAgICBp bnRjX2lycV94bGF0ZV9zZXQoaXJxLCB2ZWN0LT5lbnVtX2lkLCBkKTsKPiA+ICAgICAgICAgICAg ICAgICBpbnRjX3JlZ2lzdGVyX2lycShkZXNjLCBkLCB2ZWN0LT5lbnVtX2lkLCBpcnEpOwo+IAo+ IE90aGVyd2lzZSB0aGlzIHNlZW1zIHRvIHdvcmsgZmluZSBvbiByZWFsIGhhcmR3YXJlIChsYW5k aXNrKSBhbmQgcWVtdQo+IChydHM3NzUxcjJkKS4gIEkgZGlkIHZlcmlmeSB0aGF0IHRoZSBuZXcg ZnVuY3Rpb24gaW50Y19tYXAoKSBpcyBjYWxsZWQuCj4gCj4gVGVzdGVkLWJ5OiBHZWVydCBVeXR0 ZXJob2V2ZW4gPGdlZXJ0K3JlbmVzYXNAZ2xpZGVyLmJlPgoKQXdlc29tZSwgdGhhbmtzIEdlZXJ0 LgoKCU0uCgotLSAKV2l0aG91dCBkZXZpYXRpb24gZnJvbSB0aGUgbm9ybSwgcHJvZ3Jlc3MgaXMg bm90IHBvc3NpYmxlLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtYXJtLWtlcm5lbAo=