From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D98C3C433E0 for ; Tue, 23 Feb 2021 19:50:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9E8A964E7A for ; Tue, 23 Feb 2021 19:50:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232730AbhBWTux (ORCPT ); Tue, 23 Feb 2021 14:50:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230201AbhBWTul (ORCPT ); Tue, 23 Feb 2021 14:50:41 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CE6EC061574 for ; Tue, 23 Feb 2021 11:50:00 -0800 (PST) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lEdgz-0000LO-3A; Tue, 23 Feb 2021 20:49:57 +0100 Received: from pengutronix.de (unknown [IPv6:2a03:f580:87bc:d400:484:a2a1:2383:f11e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 2C9465E7D48; Tue, 23 Feb 2021 19:49:56 +0000 (UTC) Date: Tue, 23 Feb 2021 20:49:55 +0100 From: Marc Kleine-Budde To: Vincent Mailhol Cc: linux-can , Oliver Hartkopp , Wolfgang Grandegger Subject: Re: [PATCH v1 3/5] can: netlink: move '=' operators back to previous line (checkpatch fix) Message-ID: <87im6id0o3.fsf@hardanger.blackshift.org> References: <20210223162852.218041-1-mailhol.vincent@wanadoo.fr> <20210223162852.218041-4-mailhol.vincent@wanadoo.fr> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xsq4c4ibpji4meiw" Content-Disposition: inline In-Reply-To: <20210223162852.218041-4-mailhol.vincent@wanadoo.fr> X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-can@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-can@vger.kernel.org --xsq4c4ibpji4meiw Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 24.02.2021 01:28:50, Vincent Mailhol wrote: [...] > --- a/drivers/net/can/dev/netlink.c > +++ b/drivers/net/can/dev/netlink.c > @@ -8,20 +8,18 @@ > #include > =20 > static const struct nla_policy can_policy[IFLA_CAN_MAX + 1] =3D { > - [IFLA_CAN_STATE] =3D { .type =3D NLA_U32 }, > - [IFLA_CAN_CTRLMODE] =3D { .len =3D sizeof(struct can_ctrlmode) }, > - [IFLA_CAN_RESTART_MS] =3D { .type =3D NLA_U32 }, > - [IFLA_CAN_RESTART] =3D { .type =3D NLA_U32 }, > - [IFLA_CAN_BITTIMING] =3D { .len =3D sizeof(struct can_bittiming) }, > - [IFLA_CAN_BITTIMING_CONST] > - =3D { .len =3D sizeof(struct can_bittiming_const) }, > - [IFLA_CAN_CLOCK] =3D { .len =3D sizeof(struct can_clock) }, > - [IFLA_CAN_BERR_COUNTER] =3D { .len =3D sizeof(struct can_berr_counter) = }, > - [IFLA_CAN_DATA_BITTIMING] > - =3D { .len =3D sizeof(struct can_bittiming) }, > - [IFLA_CAN_DATA_BITTIMING_CONST] > - =3D { .len =3D sizeof(struct can_bittiming_const) }, > - [IFLA_CAN_TERMINATION] =3D { .type =3D NLA_U16 }, > + [IFLA_CAN_STATE] =3D { .type =3D NLA_U32 }, > + [IFLA_CAN_CTRLMODE] =3D { .len =3D sizeof(struct can_ctrlmode) }, > + [IFLA_CAN_RESTART_MS] =3D { .type =3D NLA_U32 }, > + [IFLA_CAN_RESTART] =3D { .type =3D NLA_U32 }, > + [IFLA_CAN_BITTIMING] =3D { .len =3D sizeof(struct can_bittiming) }, > + [IFLA_CAN_BITTIMING_CONST] =3D { .len =3D sizeof(struct can_bittiming_c= onst) }, > + [IFLA_CAN_CLOCK] =3D { .len =3D sizeof(struct can_clock) }, > + [IFLA_CAN_BERR_COUNTER] =3D { .len =3D sizeof(struct can_berr_counter)= }, > + [IFLA_CAN_DATA_BITTIMING] =3D { .len =3D sizeof(struct can_bittiming) }, > + [IFLA_CAN_DATA_BITTIMING_CONST] =3D { .len =3D sizeof(struct can_bittim= ing_const) }, > + [IFLA_CAN_TERMINATION] =3D { .type =3D NLA_U16 }, > + [IFLA_CAN_TERMINATION] =3D { .type =3D NLA_U16 }, You doubled the last entry by mistake. Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --xsq4c4ibpji4meiw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAmA1XGAACgkQqclaivrt 76lHVQf7BYCalp19NgPiq1b8PxtWCo1Uanx+06KLszmfvquTwXdurtcq5fjlYG3y mvcpaTYuwMyODCymMSuJ9uYIBRaWv46cfrqgo9S/7o4Qc08sWmhcW9f5z8OreBRN G1WICVxjtTkOme31EN+Ya62IYrDyU5FFnmhTCRbZAEIFlJT/cMJfz8GZKIr6H9Qa OyauXTpDgSn8jgRagT/0NGTyn5l1pdH+3WzFZuHr92cvnMR9xl2BMMpPzhvLe0ch 2drNM71qsz+00iVi6+wsACcgtmmJElJjxXOv5cAqwQw4MAQ6O6ev6AfmaQQC6qdc M57E7Ob7gOox9VOg4cLPAKNvYlwqXg== =uT+K -----END PGP SIGNATURE----- --xsq4c4ibpji4meiw--