From: Philippe Gerum <rpm@xenomai.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: xenomai@xenomai.org
Subject: Re: [PATCH Dovetail 0/4] Get rid of the APC interface
Date: Mon, 11 Jan 2021 14:07:33 +0100 [thread overview]
Message-ID: <87im83k4fe.fsf@xenomai.org> (raw)
In-Reply-To: <6632491e-7834-1a6e-f488-9b9077111adf@siemens.com>
Jan Kiszka <jan.kiszka@siemens.com> writes:
> On 09.01.21 17:02, Philippe Gerum wrote:
>> From: Philippe Gerum <rpm@xenomai.org>
>>
>> This patch starts a series aiming at dropping the (functionally
>> redundant) APC interface entirely.
>>
>> APCs are a relic from the Dark Ages, with no upside compared to open
>> coded requests triggering virtual/synthetic IRQs to be handled by the
>> root domain. As a matter of fact, an APC does run as a client handler
>> of a synthetic IRQ under the hood. In other words, the APC
>> encapsulation adds nothing but useless overhead.
>>
>> Philippe Gerum (4):
>> cobalt/pipe: drop dependency on APCs
>> cobalt/registry: drop dependency on APCs
>> cobalt/select: drop dependency on APCs
>> cobalt/apc: drop obsolete APC mechanism
>>
>> include/cobalt/kernel/apc.h | 32 ---
>> .../cobalt/kernel/ipipe/pipeline/machine.h | 2 -
>> include/cobalt/kernel/rtdm/driver.h | 1 -
>> kernel/cobalt/ipipe/Makefile | 2 +-
>> kernel/cobalt/ipipe/apc.c | 202 ------------------
>> kernel/cobalt/ipipe/init.c | 19 --
>> kernel/cobalt/pipe.c | 26 ++-
>> kernel/cobalt/procfs.c | 42 ----
>> kernel/cobalt/registry.c | 30 +--
>> kernel/cobalt/rtdm/core.c | 1 -
>> kernel/cobalt/select.c | 23 +-
>> 11 files changed, 49 insertions(+), 331 deletions(-)
>> delete mode 100644 include/cobalt/kernel/apc.h
>> delete mode 100644 kernel/cobalt/ipipe/apc.c
>>
>
> Would it make sense to introduce the pipeline abstraction of those
> services first? Then you won't touch the core code twice, once again for
> removing all the ipipe references.
>
I'd rather do it the way it is: first we prove that there is no
regression in open coding APCs based on virtual IRQs, then we do a 1:1
mapping from the I-pipe virtual IRQs to Dovetail's synthetic IRQs which
have the very same semantics.
--
Philippe.
prev parent reply other threads:[~2021-01-11 13:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-09 16:02 [PATCH Dovetail 0/4] Get rid of the APC interface Philippe Gerum
2021-01-09 16:02 ` [PATCH Dovetail 1/4] cobalt/pipe: drop dependency on APCs Philippe Gerum
2021-01-09 16:02 ` [PATCH Dovetail 2/4] cobalt/registry: " Philippe Gerum
2021-01-09 16:02 ` [PATCH Dovetail 3/4] cobalt/select: " Philippe Gerum
2021-01-09 16:02 ` [PATCH Dovetail 4/4] cobalt/apc: drop obsolete APC mechanism Philippe Gerum
2021-01-11 12:10 ` [PATCH Dovetail 0/4] Get rid of the APC interface Jan Kiszka
2021-01-11 13:07 ` Philippe Gerum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87im83k4fe.fsf@xenomai.org \
--to=rpm@xenomai.org \
--cc=jan.kiszka@siemens.com \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.