From: Jani Nikula <jani.nikula@intel.com>
To: Zhenyu Wang <zhenyuw@linux.intel.com>
Cc: Hang Yuan <hang.yuan@linux.intel.com>,
intel-gfx@lists.freedesktop.org, chris@chris-wilson.co.uk,
intel-gvt-dev@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v3 09/10] drm/i915/gvt: replace I915_WRITE with intel_uncore_write
Date: Wed, 02 Dec 2020 11:57:00 +0200 [thread overview]
Message-ID: <87im9kcyz7.fsf@intel.com> (raw)
In-Reply-To: <20201202022913.GU16939@zhen-hp.sh.intel.com>
On Wed, 02 Dec 2020, Zhenyu Wang <zhenyuw@linux.intel.com> wrote:
> On 2020.12.01 18:16:35 +0200, Jani Nikula wrote:
>> On Mon, 30 Nov 2020, Jani Nikula <jani.nikula@intel.com> wrote:
>> > Let's avoid adding new I915_WRITE uses while we try to get rid of them.
>> >
>> > Fixes: 5f60b12edcd0 ("drm/i915/gvt: Save/restore HW status to support GVT suspend/resume")
>> > Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
>> > Cc: Hang Yuan <hang.yuan@linux.intel.com>
>> > Cc: Colin Xu <colin.xu@intel.com>
>> > Cc: Zhi Wang <zhi.a.wang@intel.com>
>> > Cc: intel-gvt-dev@lists.freedesktop.org
>> > Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>
>> Pushed up to, but *excluding* this patch to dinq. Thanks for the
>> reviews.
>>
>> Zhenyu, Zhi, may I have your review/ack for merging this one directly
>> via dinq to not add a dependency on the gvt tree?
>>
>
> Yep, that's fine to me.
>
> Reviewed-by: Zhenyu Wang <zhenyuw@linux.intel.com>
Thanks, pushed to dinq.
BR,
Jani.
>
>>
>> BR,
>> Jani.
>>
>>
>> > ---
>> > drivers/gpu/drm/i915/gvt/handlers.c | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/gpu/drm/i915/gvt/handlers.c b/drivers/gpu/drm/i915/gvt/handlers.c
>> > index 6f0706e885cb..eba626ba640f 100644
>> > --- a/drivers/gpu/drm/i915/gvt/handlers.c
>> > +++ b/drivers/gpu/drm/i915/gvt/handlers.c
>> > @@ -3693,7 +3693,7 @@ static inline int mmio_pm_restore_handler(struct intel_gvt *gvt,
>> > struct drm_i915_private *dev_priv = gvt->gt->i915;
>> >
>> > if (gvt->mmio.mmio_attribute[offset >> 2] & F_PM_SAVE)
>> > - I915_WRITE(_MMIO(offset), vgpu_vreg(vgpu, offset));
>> > + intel_uncore_write(&dev_priv->uncore, _MMIO(offset), vgpu_vreg(vgpu, offset));
>> >
>> > return 0;
>> > }
>>
>> --
>> Jani Nikula, Intel Open Source Graphics Center
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-12-02 9:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 11:15 [Intel-gfx] [PATCH v3 01/10] drm/i915/debugfs: remove RPS autotuning details from i915_rps_boost_info Jani Nikula
2020-11-30 11:15 ` [Intel-gfx] [PATCH v3 02/10] drm/i915: remove last traces of I915_READ_FW() and I915_WRITE_FW() Jani Nikula
2020-11-30 11:15 ` [Intel-gfx] [PATCH v3 03/10] drm/i915/cdclk: prefer intel_de_write() over I915_WRITE() Jani Nikula
2020-11-30 11:15 ` [Intel-gfx] [PATCH v3 04/10] drm/i915/debugfs: remove the i915_cache_sharing debugfs file Jani Nikula
2020-11-30 11:15 ` [Intel-gfx] [PATCH v3 05/10] drm/i915/debugfs: replace I915_READ() with intel_uncore_read() Jani Nikula
2020-11-30 11:15 ` [Intel-gfx] [PATCH v3 06/10] drm/i915/suspend: replace I915_READ()/WRITE() with intel_de_read()/write() Jani Nikula
2020-11-30 11:15 ` [Intel-gfx] [PATCH v3 07/10] drm/i915/pm: replace I915_READ()/WRITE() with intel_uncore_read()/write() Jani Nikula
2020-11-30 11:15 ` [Intel-gfx] [PATCH v3 08/10] drm/i915/irq: " Jani Nikula
2020-11-30 11:16 ` [Intel-gfx] [PATCH v3 09/10] drm/i915/gvt: replace I915_WRITE with intel_uncore_write Jani Nikula
2020-12-01 16:16 ` Jani Nikula
2020-12-02 2:29 ` Zhenyu Wang
2020-12-02 9:57 ` Jani Nikula [this message]
2020-11-30 11:16 ` [Intel-gfx] [PATCH v3 10/10] drm/i915: remove last traces of I915_READ(), I915_WRITE() and POSTING_READ() Jani Nikula
2020-12-02 15:45 ` Jani Nikula
2020-11-30 16:31 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,01/10] drm/i915/debugfs: remove RPS autotuning details from i915_rps_boost_info Patchwork
2020-11-30 17:01 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-12-01 8:15 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87im9kcyz7.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=hang.yuan@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=zhenyuw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.