From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Ayaz A Siddiqui <ayaz.siddiqui@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 1/2] lib/igt_device_scan: Fix device selection filter
Date: Mon, 28 Sep 2020 13:53:35 -0700 [thread overview]
Message-ID: <87imbx7hdc.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20200903110110.2403699-2-ayaz.siddiqui@intel.com>
On Thu, 03 Sep 2020 04:01:09 -0700, Ayaz A Siddiqui wrote:
>
> DRM subsystem filter in intel_gpu_top was not working due to missing
> PCI_SLOT_NAME property. Using the parent device in case of drm subsystem
> leads to fix this issue.
>
> Signed-off-by: Ayaz A Siddiqui <ayaz.siddiqui@intel.com>
> ---
> lib/igt_device_scan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
> index 345bae76d..3583c69c7 100644
> --- a/lib/igt_device_scan.c
> +++ b/lib/igt_device_scan.c
> @@ -1263,7 +1263,7 @@ bool igt_device_card_match(const char *filter, struct igt_device_card *card)
> /* We take first one if more than one card matches filter */
> dev = igt_list_first_entry(&igt_devs.filtered, dev, link);
>
> - __copy_dev_to_card(dev, card);
> + __copy_dev_to_card(is_pci_subsystem(dev) ? dev : dev->parent, card);
Also I am wondering if this is required for only drm system then should
this line be:
__copy_dev_to_card(is_drm_subsystem(dev) ? dev->parent : dev, card)
Also does lsgpu (the only other caller of igt_device_card_match()) work
with this change?
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-09-28 20:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200903110110.2403699-1-ayaz.siddiqui@intel.com>
2020-09-03 11:01 ` [igt-dev] [PATCH i-g-t 1/2] lib/igt_device_scan: Fix device selection filter Ayaz A Siddiqui
2020-09-03 11:54 ` Zbigniew Kempczyński
2020-09-04 7:31 ` Siddiqui, Ayaz A
2020-09-11 5:49 ` Petri Latvala
2020-09-28 21:13 ` Dixit, Ashutosh
2020-09-29 4:26 ` Zbigniew Kempczyński
2020-09-28 20:53 ` Dixit, Ashutosh [this message]
2020-09-29 4:22 ` Zbigniew Kempczyński
2020-09-03 11:01 ` [igt-dev] [PATCH i-g-t 2/2] lib/igt_device_scan: Select intel as default vendor for intel_gpu_top Ayaz A Siddiqui
2020-09-03 11:57 ` Zbigniew Kempczyński
2020-09-03 11:29 ` [igt-dev] [PATCH i-g-t 0/2] Fix for device detection issues with intel gpu top Petri Latvala
2020-09-03 19:51 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
2020-09-04 6:03 ` Siddiqui, Ayaz A
2020-09-04 7:55 ` Petri Latvala
2020-09-04 14:11 ` Vudum, Lakshminarayana
2020-09-04 14:00 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imbx7hdc.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=ayaz.siddiqui@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.