From: Markus Armbruster <armbru@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: qemu-pr-helper -v suppresses errors, isn't that weird?
Date: Thu, 18 Jun 2020 07:32:08 +0200 [thread overview]
Message-ID: <87imfpszvr.fsf@dusky.pond.sub.org> (raw)
prh_co_entry() reports reports errors reading requests / writing
responses only when @verbose (command line -v); relevant code appended
for you convenience.
Sure these are *errors*? The program recovers and continues, and this
is deemed normal enough to inform the user only when he specifically
asks for it. Yet when we inform, we format it as an error. Should we
tune it down to warnings?
static void coroutine_fn prh_co_entry(void *opaque)
{
[...]
while (atomic_read(&state) == RUNNING) {
[...]
sz = prh_read_request(client, &req, &resp, &local_err);
if (sz < 0) {
break;
}
[...]
if (prh_write_response(client, &req, &resp, &local_err) < 0) {
break;
}
}
if (local_err) {
if (verbose == 0) {
error_free(local_err);
} else {
error_report_err(local_err);
}
}
out:
qio_channel_detach_aio_context(QIO_CHANNEL(client->ioc));
object_unref(OBJECT(client->ioc));
g_free(client);
}
next reply other threads:[~2020-06-18 5:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 5:32 Markus Armbruster [this message]
2020-06-18 12:15 ` qemu-pr-helper -v suppresses errors, isn't that weird? Paolo Bonzini
2020-06-22 8:28 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imfpszvr.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.