From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: David Ahern <dsahern@kernel.org>, daniel@iogearbox.net, ast@kernel.org
Cc: netdev@vger.kernel.org, David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH bpf] xdp: Reset prog in dev_change_xdp_fd when fd is negative
Date: Tue, 14 Apr 2020 09:17:32 +0200 [thread overview]
Message-ID: <87imi2pmcz.fsf@toke.dk> (raw)
In-Reply-To: <20200412133204.43847-1-dsahern@kernel.org>
David Ahern <dsahern@kernel.org> writes:
> From: David Ahern <dsahern@gmail.com>
>
> The commit mentioned in the Fixes tag reuses the local prog variable
> when looking up an expected_fd. The variable is not reset when fd < 0
> causing a detach with the expected_fd set to actually call
> dev_xdp_install for the existing program. The end result is that the
> detach does not happen.
>
> Fixes: 92234c8f15c8 ("xdp: Support specifying expected existing program when attaching XDP")
> Signed-off-by: David Ahern <dsahern@gmail.com>
> Cc: Toke Høiland-Jørgensen <toke@redhat.com>
Ugh, my bad (obviously!). Thanks for the fix! I'll send an update to the
selftest to catch errors like this...
Reviewed-by: Toke Høiland-Jørgensen <toke@redhat.com>
next prev parent reply other threads:[~2020-04-14 7:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-12 13:32 [PATCH bpf] xdp: Reset prog in dev_change_xdp_fd when fd is negative David Ahern
2020-04-12 18:11 ` Jakub Kicinski
2020-04-13 22:08 ` Alexei Starovoitov
2020-04-14 7:17 ` Toke Høiland-Jørgensen [this message]
2020-04-14 19:45 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imi2pmcz.fsf@toke.dk \
--to=toke@redhat.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.