From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE817C43331 for ; Tue, 31 Mar 2020 13:09:24 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B72F9206F5 for ; Tue, 31 Mar 2020 13:09:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B72F9206F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5760A6E323; Tue, 31 Mar 2020 13:09:24 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1F7E76E323 for ; Tue, 31 Mar 2020 13:09:23 +0000 (UTC) IronPort-SDR: MZlamVjl2BxKI6KF64TwcqAzDmIcoVExtSMexonUFsVZsWqcNXqxGd08KQTO0kbzp9DYI8mxmU VS2CE9/9GD5A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2020 06:09:22 -0700 IronPort-SDR: DdGVX40j+lPfGyTKLGGZ97/euhkWZjVwykgF3KSJAdoAwqkmhfvOpvZGLpnAQg66MfRWMJEB+s aGaMUmenCvFQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,327,1580803200"; d="scan'208";a="395486369" Received: from gaia.fi.intel.com ([10.237.72.192]) by orsmga004.jf.intel.com with ESMTP; 31 Mar 2020 06:09:21 -0700 Received: by gaia.fi.intel.com (Postfix, from userid 1000) id 369255C0D7B; Tue, 31 Mar 2020 16:07:44 +0300 (EEST) From: Mika Kuoppala To: Chris Wilson , intel-gfx@lists.freedesktop.org In-Reply-To: <20200331091459.29179-1-chris@chris-wilson.co.uk> References: <20200331091459.29179-1-chris@chris-wilson.co.uk> Date: Tue, 31 Mar 2020 16:07:44 +0300 Message-ID: <87imikpt9b.fsf@gaia.fi.intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 1/4] drm/i915/selftests: Tidy up an error message for live_error_interrupt X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chris Wilson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Chris Wilson writes: > Since we don't wait for the error interrupt to reset, restart and then > complete the guilty request, clean up the error messages. > > Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/gt/selftest_lrc.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c > index d3e163c93e22..b929e52a8f5a 100644 > --- a/drivers/gpu/drm/i915/gt/selftest_lrc.c > +++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c > @@ -649,9 +649,9 @@ static int live_error_interrupt(void *arg) > error_repr(p->error[i])); > > if (!i915_request_started(client[i])) { > - pr_debug("%s: %s request not stated!\n", > - engine->name, > - error_repr(p->error[i])); > + pr_err("%s: %s request not started!\n", > + engine->name, > + error_repr(p->error[i])); > err = -ETIME; > goto out; > } > @@ -659,9 +659,10 @@ static int live_error_interrupt(void *arg) > /* Kick the tasklet to process the error */ > intel_engine_flush_submission(engine); > if (client[i]->fence.error != p->error[i]) { > - pr_err("%s: %s request completed with wrong error code: %d\n", > + pr_err("%s: %s request (%s) with wrong error code: %d\n", > engine->name, > error_repr(p->error[i]), > + i915_request_completed(client[i]) ? "completed" : "running", > client[i]->fence.error); > err = -EINVAL; > goto out; > -- > 2.20.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx