From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1icTa3-0007oF-S7 for mharc-qemu-trivial@gnu.org; Wed, 04 Dec 2019 07:16:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50641) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icTZq-0007kx-4A for qemu-trivial@nongnu.org; Wed, 04 Dec 2019 07:16:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1icTZo-0005TW-0j for qemu-trivial@nongnu.org; Wed, 04 Dec 2019 07:16:16 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:49402 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1icTZn-00059I-So for qemu-trivial@nongnu.org; Wed, 04 Dec 2019 07:16:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575461773; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0lhELDBp2p7kSZYzziYGeg4mIOq150GA1nTJ88AVdZ4=; b=duPcoHNKIHSCI2p8RsLEgSUYvE8f0UkHQTu2dOr5PRpZoJubzzX6dJNG88ebh2E+Vkz19y ir7QXdo0i3kjiqD8Id2ixGQWBSJpRM7BTK0wUXEGv3lGlovGTbh4NcCKkGXXImnRHBwoNT MocS+vUUWIxP1tuDpRsmPC8KegOsHkw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-132-rjDh1BFNNfikRkjb436bSg-1; Wed, 04 Dec 2019 07:16:10 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E3C601005502; Wed, 4 Dec 2019 12:16:09 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-134.ams2.redhat.com [10.36.116.134]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A33531001901; Wed, 4 Dec 2019 12:16:09 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 18DB51138606; Wed, 4 Dec 2019 13:16:08 +0100 (CET) From: Markus Armbruster To: Han Han Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org, laurent@vivier.eu, dgilbert@redhat.com Subject: Re: [PATCH] Revert "qemu-options.hx: Update for reboot-timeout parameter" References: <20191204085628.2892-1-hhan@redhat.com> Date: Wed, 04 Dec 2019 13:16:08 +0100 In-Reply-To: <20191204085628.2892-1-hhan@redhat.com> (Han Han's message of "Wed, 4 Dec 2019 16:56:28 +0800") Message-ID: <87immwb81j.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: rjDh1BFNNfikRkjb436bSg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Dec 2019 12:16:31 -0000 Han Han writes: > This reverts commit bbd9e6985ff342cbe15b9cb7eb30e842796fbbe8. > > In 20a1922032 we allowed reboot-timeout=3D-1 again, so update the doc > accordingly. > --- > qemu-options.hx | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/qemu-options.hx b/qemu-options.hx > index 65c9473b73..e14d88e9b2 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -327,8 +327,8 @@ format(true color). The resolution should be supporte= d by the SVGA mode, so > the recommended is 320x240, 640x480, 800x640. > =20 > A timeout could be passed to bios, guest will pause for @var{rb_timeout}= ms > -when boot failed, then reboot. If @option{reboot-timeout} is not set, > -guest will not reboot by default. Currently Seabios for X86 > +when boot failed, then reboot. If @var{rb_timeout} is '-1', guest will n= ot > +reboot, qemu passes '-1' to bios by default. Currently Seabios for X86 > system support it. > =20 > Do strict boot via @option{strict=3Don} as far as firmware/BIOS Reviewed-by: Markus Armbruster From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4D30C2BD09 for ; Wed, 4 Dec 2019 12:46:34 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 933CE2081B for ; Wed, 4 Dec 2019 12:46:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="duPcoHNK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 933CE2081B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38256 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icU37-0008Cx-L2 for qemu-devel@archiver.kernel.org; Wed, 04 Dec 2019 07:46:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50639) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icTa2-0007kp-SB for qemu-devel@nongnu.org; Wed, 04 Dec 2019 07:16:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1icTZn-0005St-TA for qemu-devel@nongnu.org; Wed, 04 Dec 2019 07:16:16 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:35063 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1icTZn-0005A1-OE for qemu-devel@nongnu.org; Wed, 04 Dec 2019 07:16:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575461773; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0lhELDBp2p7kSZYzziYGeg4mIOq150GA1nTJ88AVdZ4=; b=duPcoHNKIHSCI2p8RsLEgSUYvE8f0UkHQTu2dOr5PRpZoJubzzX6dJNG88ebh2E+Vkz19y ir7QXdo0i3kjiqD8Id2ixGQWBSJpRM7BTK0wUXEGv3lGlovGTbh4NcCKkGXXImnRHBwoNT MocS+vUUWIxP1tuDpRsmPC8KegOsHkw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-132-rjDh1BFNNfikRkjb436bSg-1; Wed, 04 Dec 2019 07:16:10 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E3C601005502; Wed, 4 Dec 2019 12:16:09 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-134.ams2.redhat.com [10.36.116.134]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A33531001901; Wed, 4 Dec 2019 12:16:09 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 18DB51138606; Wed, 4 Dec 2019 13:16:08 +0100 (CET) From: Markus Armbruster To: Han Han Subject: Re: [PATCH] Revert "qemu-options.hx: Update for reboot-timeout parameter" References: <20191204085628.2892-1-hhan@redhat.com> Date: Wed, 04 Dec 2019 13:16:08 +0100 In-Reply-To: <20191204085628.2892-1-hhan@redhat.com> (Han Han's message of "Wed, 4 Dec 2019 16:56:28 +0800") Message-ID: <87immwb81j.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: rjDh1BFNNfikRkjb436bSg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, dgilbert@redhat.com, laurent@vivier.eu Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Han Han writes: > This reverts commit bbd9e6985ff342cbe15b9cb7eb30e842796fbbe8. > > In 20a1922032 we allowed reboot-timeout=3D-1 again, so update the doc > accordingly. > --- > qemu-options.hx | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/qemu-options.hx b/qemu-options.hx > index 65c9473b73..e14d88e9b2 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -327,8 +327,8 @@ format(true color). The resolution should be supporte= d by the SVGA mode, so > the recommended is 320x240, 640x480, 800x640. > =20 > A timeout could be passed to bios, guest will pause for @var{rb_timeout}= ms > -when boot failed, then reboot. If @option{reboot-timeout} is not set, > -guest will not reboot by default. Currently Seabios for X86 > +when boot failed, then reboot. If @var{rb_timeout} is '-1', guest will n= ot > +reboot, qemu passes '-1' to bios by default. Currently Seabios for X86 > system support it. > =20 > Do strict boot via @option{strict=3Don} as far as firmware/BIOS Reviewed-by: Markus Armbruster