All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>,
	dri-devel@lists.freedesktop.org,
	Thierry Reding <treding@nvidia.com>,
	David Airlie <airlied@linux.ie>, Sean Paul <sean@poorly.run>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/scdc: Fix typo in bit definition of SCDC_STATUS_FLAGS
Date: Tue, 22 Oct 2019 12:51:00 +0300	[thread overview]
Message-ID: <87imohf6rf.fsf@intel.com> (raw)
In-Reply-To: <20191022084423.GB1531961@ulmo>

On Tue, 22 Oct 2019, Thierry Reding <thierry.reding@gmail.com> wrote:
> On Tue, Oct 22, 2019 at 11:16:51AM +0300, Jani Nikula wrote:
>> On Wed, 16 Oct 2019, Patrik Jakobsson <patrik.r.jakobsson@gmail.com> wrote:
>> > Fix typo where bits got compared (x < y) instead of shifted (x << y).
>> 
>> Fixes: 3ad33ae2bc80 ("drm: Add SCDC helpers")
>> Cc: Thierry Reding <treding@nvidia.com>
>
> I'm not sure we really need the Fixes: tag here. These defines aren't
> used anywhere, so technically there's no bug.

Yeah well, I just logged it here as I happened to do the drive-by git
blame.

BR,
Jani.



>
> Thierry
>
>> 
>> > Signed-off-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
>> > ---
>> >  include/drm/drm_scdc_helper.h | 6 +++---
>> >  1 file changed, 3 insertions(+), 3 deletions(-)
>> >
>> > diff --git a/include/drm/drm_scdc_helper.h b/include/drm/drm_scdc_helper.h
>> > index f92eb2094d6b..6a483533aae4 100644
>> > --- a/include/drm/drm_scdc_helper.h
>> > +++ b/include/drm/drm_scdc_helper.h
>> > @@ -50,9 +50,9 @@
>> >  #define  SCDC_READ_REQUEST_ENABLE (1 << 0)
>> >  
>> >  #define SCDC_STATUS_FLAGS_0 0x40
>> > -#define  SCDC_CH2_LOCK (1 < 3)
>> > -#define  SCDC_CH1_LOCK (1 < 2)
>> > -#define  SCDC_CH0_LOCK (1 < 1)
>> > +#define  SCDC_CH2_LOCK (1 << 3)
>> > +#define  SCDC_CH1_LOCK (1 << 2)
>> > +#define  SCDC_CH0_LOCK (1 << 1)
>> >  #define  SCDC_CH_LOCK_MASK (SCDC_CH2_LOCK | SCDC_CH1_LOCK | SCDC_CH0_LOCK)
>> >  #define  SCDC_CLOCK_DETECT (1 << 0)
>> 
>> -- 
>> Jani Nikula, Intel Open Source Graphics Center
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Jani Nikula, Intel Open Source Graphics Center

  reply	other threads:[~2019-10-22  9:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-16 12:33 [PATCH] drm/scdc: Fix typo in bit definition of SCDC_STATUS_FLAGS Patrik Jakobsson
2019-10-22  8:16 ` Jani Nikula
2019-10-22  8:44   ` Thierry Reding
2019-10-22  8:44     ` Thierry Reding
2019-10-22  9:51     ` Jani Nikula [this message]
2019-10-22 15:53       ` Patrik Jakobsson
2019-10-22 15:53         ` Patrik Jakobsson
2019-11-04 17:05         ` Patrik Jakobsson
2019-11-04 17:05           ` Patrik Jakobsson
2019-10-22  8:41 ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87imohf6rf.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patrik.r.jakobsson@gmail.com \
    --cc=sean@poorly.run \
    --cc=thierry.reding@gmail.com \
    --cc=treding@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.