Re: [PATCH for 4.2 v6 00/54] Support for TCG plugins

["Alex Bennée" <alex.bennee@linaro.org>]

Alex Bennée <alex.bennee@linaro.org> writes:

> Hi,
>
> This is the latest iteration of the TCG plugins series. From the documentation:
>
>   QEMU TCG plugins provide a way for users to run experiments taking
>   advantage of the total system control emulation can have over a guest.
>   It provides a mechanism for plugins to subscribe to events during
>   translation and execution and optionally callback into the plugin
>   during these events. TCG plugins are unable to change the system state
>   only monitor it passively. However they can do this down to an
>   individual instruction granularity including potentially subscribing
>   to all load and store operations.
>
> This is mostly a adding signoffs and some patch re-organisation and
> splitting. For reference the longer notes about what API tweaks didn't
> make it into this iteration can be found in the previous series:
>
>   Subject: [PATCH for 4.2 v5 00/55] Support for TCG plugins
>   Date: Mon, 14 Oct 2019 11:48:53 +0100
>   Message-Id: <20191014104948.4291-1-alex.bennee@linaro.org>
>
> Changes of note:
>
>   - now use gmodule to load symbols instead of dlsym
>   - re-jigged translator_ld to avoid creating more alias functions
>   - moved configure change to final place
>   - moved additional API bits to before examples
>   - merged api changes to examples into final single commit versions
>   - tweaked hwaddr API to talk of device_offset
>
> Most of the checkpatch formatting complaints I think are overly picky
> given the attempt to make table look nice or not wrap for the sake of
> going one character over. I've included a checkpatch patch to stop
> bothering me about (foo, /* empty */) comments. As ever there are more
> details bellow the ---
>
> Only a few more un-reviewed patches before I can send the PR:
>
>    02 - trace add mmu_index to mem_info
>    37 - plugin expand the plugin_init function to include
>    39 - plugin add qemu_plugin_outs helper
>    54 - scripts chec.pl don t complain about foo em

Ping?

I've made two minor changes which you can currently see in:

  https://github.com/stsquad/qemu/tree/plugins/plugins-v7

I've made a tweak to translator_ld which takes advantage of the cputlb
cleanup:

  Subject: [PATCH v2] cputlb: ensure _cmmu helper functions follow the naming standard
  Date: Mon, 21 Oct 2019 16:09:10 +0100
  Message-Id: <20191021150910.23216-1-alex.bennee@linaro.org>

and I've added a MAINTAINERS entry. I didn't think it was worth spamming
the list before I sent my PR. Let me know if you want a final v7
posting to the list.

--
Alex Bennée