From: Markus Armbruster <armbru@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] net: Deprecate tap backend's parameter "helper"
Date: Tue, 18 Jun 2019 07:32:27 +0200 [thread overview]
Message-ID: <87imt3zces.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <10f1a64b-cbc7-600f-7a52-cdd57ec5f71f@redhat.com> (Jason Wang's message of "Tue, 18 Jun 2019 11:31:00 +0800")
Jason Wang <jasowang@redhat.com> writes:
> On 2019/6/4 下午7:52, Markus Armbruster wrote:
>> -netdev tap,helper=... is a useless duplicate of -netdev bridge.
>> Deprecate and de-document.
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>
>
> This requires more thought as TAP could be used independently. Force
> using a "bridge" backend may lead some confusion.
Can you explain your qualms in a bit more detail?
The thoughts that led to this patch:
https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg03164.html
Consensus back then:
1. Add qemu-bridge-helper.c to Jason's "Network device backends"
2. Deprecate -netdev tap parameter "helper"
3. Improve documentation of -netdev bridge
4. Create a manual page for qemu-bridge-helper that also covers
/etc/qemu/bridge.conf.
5. Fix the nutty error handling in parse_acl_file()
This series covers the first two [PATCH 1+2], and records the remaining
three more permanently [PATCH 3].
next prev parent reply other threads:[~2019-06-18 5:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 11:52 [Qemu-devel] [PATCH 0/3] Some qemu-bridge-helper work Markus Armbruster
2019-06-04 11:52 ` [Qemu-devel] [PATCH 1/3] MAINTAINERS: Add qemu-bridge-helper.c to "Network device backends" Markus Armbruster
2019-06-04 11:52 ` [Qemu-devel] [PATCH 2/3] net: Deprecate tap backend's parameter "helper" Markus Armbruster
2019-06-18 3:31 ` Jason Wang
2019-06-18 5:32 ` Markus Armbruster [this message]
2019-06-18 5:48 ` Jason Wang
2019-06-04 11:52 ` [Qemu-devel] [PATCH 3/3] qemu-bridge-helper: Document known shortcomings Markus Armbruster
2019-06-18 3:31 ` [Qemu-devel] [PATCH 0/3] Some qemu-bridge-helper work Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imt3zces.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.