From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hZ74P-0002G9-Td for ath11k@lists.infradead.org; Fri, 07 Jun 2019 05:05:43 +0000 From: Kalle Valo Subject: Re: [PATCH] ath11k: Fix the rate mask value for legacy and peer fixed rate References: <1559648239-16220-1-git-send-email-mkenna@codeaurora.org> <20190606165407.65AC460DAB@smtp.codeaurora.org> <04d8be7e61dad763b8526bf615af4730@codeaurora.org> Date: Fri, 07 Jun 2019 08:05:38 +0300 In-Reply-To: <04d8be7e61dad763b8526bf615af4730@codeaurora.org> (Maharaja Kennadyrajan's message of "Fri, 07 Jun 2019 10:31:31 +0530") Message-ID: <87imtit271.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath11k" Errors-To: ath11k-bounces+kvalo=adurom.com@lists.infradead.org To: Maharaja Kennadyrajan Cc: ath11k@lists.infradead.org Maharaja Kennadyrajan writes: > On 2019-06-06 10:24 pm, Kalle Valo wrote: >> Maharaja Kennadyrajan wrote: >> >>> The rate mask value is changed from 0xff to oxffff (u8 to u32) >>> in the firmware for the legacy fixed rate and peer fixed rate >>> setting in the set bitrate command. >>> Hence this patch is fixing the same in the driver. >>> >>> Signed-off-by: Maharaja Kennadyrajan >> >> Is this backwards compatible change? I'm not convinced about that. > > [Maha]: It won't break the backward compatibility as firmware is > taking care of it. Firmware is using 0xffff as mask value from the > beginning and this change is not added recently in the firmware. Good, thanks for the clarification. -- Kalle Valo _______________________________________________ ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k