From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:43406) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDNLL-00043L-JH for qemu-devel@nongnu.org; Mon, 08 Apr 2019 02:01:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDNDq-0004W7-Ic for qemu-devel@nongnu.org; Mon, 08 Apr 2019 01:53:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52882) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hDNDq-0004TE-0o for qemu-devel@nongnu.org; Mon, 08 Apr 2019 01:53:34 -0400 From: Markus Armbruster References: <20190322134447.14831-1-jfreimann@redhat.com> <20190404082933.ke7tvryocpdd2h54@jenstp.localdomain> <20190405085628.GA2819@work-vm> <20190405092010.2hnwu36w4ited4rl@jenstp.localdomain> Date: Mon, 08 Apr 2019 07:53:21 +0200 In-Reply-To: <20190405092010.2hnwu36w4ited4rl@jenstp.localdomain> (Jens Freimann's message of "Fri, 5 Apr 2019 11:20:10 +0200") Message-ID: <87imvpjb5a.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [RFC PATCH 0/2] implement the failover feature for assigned network devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jens Freimann Cc: "Dr. David Alan Gilbert" , pkrempa@redhat.com, ehabkost@redhat.com, mst@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, armbru@redhat.com, liran.alon@oracle.com, laine@redhat.com, ogerlitz@mellanox.com, ailan@redhat.com Jens Freimann writes: > On Fri, Apr 05, 2019 at 09:56:29AM +0100, Dr. David Alan Gilbert wrote: >>* Jens Freimann (jfreimann@redhat.com) wrote: > [...] >>> > Commandline: There is a dependency between vfio-pci and virtio-net >>> > devices. One points to the other via new parameters >>> > primar= and standby=''. This means >>> > that the primary device needs to be specified after standby device on >>> > the qemu command line. Not sure how to solve this. >>> > >>> > Error handling: Patches don't cover all possible error scenarios yet. >>> > >>> > I have tested this with a mlx5 NIC and was able to migrate the VM with >>> > above mentioned workarounds for open problems. >>> > >>> > Command line example: >>> > >>> > qemu-system-x86_64 -enable-kvm -m 3072 -smp 3 \ >>> > -machine q35,kernel-irqchip=split -cpu host \ >>> > -k fr \ >>> > -serial stdio \ >>> > -net none \ >>> > -qmp unix:/tmp/qmp.socket,server,nowait \ >>> > -monitor telnet:127.0.0.1:5555,server,nowait \ >>> > -device pcie-root-port,id=root0,multifunction=on,chassis=0,addr=0xa \ >>> > -device pcie-root-port,id=root1,bus=pcie.0,chassis=1 \ >>> > -device pcie-root-port,id=root2,bus=pcie.0,chassis=2 \ >>> > -netdev tap,script=/root/bin/bridge.sh,downscript=no,id=hostnet1,vhost=on \ >>> > -device virtio-net-pci,netdev=hostnet1,id=net1,mac=52:54:00:6f:55:cc,bus=root2,primary=hostdev0 \ >>> > -device vfio-pci,host=5e:00.2,id=hostdev0,bus=root1,standby=net1 \ >> >>Yes, that's a bit grim; it's circular dependency on the 'hostdev0' and >>'net1' id's. cc'ing in Markus. > > Dan had an idea how to avoid having to specify the id for the > virtio-net device. I'm currently looking into it, but it seems like it > should work. Excellent. A circular dependency between -device could only lead to trouble. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB9F6C282CE for ; Mon, 8 Apr 2019 06:04:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE0EA20870 for ; Mon, 8 Apr 2019 06:04:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE0EA20870 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:47942 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDNNx-0005dB-4E for qemu-devel@archiver.kernel.org; Mon, 08 Apr 2019 02:04:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43406) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDNLL-00043L-JH for qemu-devel@nongnu.org; Mon, 08 Apr 2019 02:01:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDNDq-0004W7-Ic for qemu-devel@nongnu.org; Mon, 08 Apr 2019 01:53:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52882) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hDNDq-0004TE-0o for qemu-devel@nongnu.org; Mon, 08 Apr 2019 01:53:34 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CF9F7C0B615A; Mon, 8 Apr 2019 05:53:31 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-116.ams2.redhat.com [10.36.116.116]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1815E5D719; Mon, 8 Apr 2019 05:53:23 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 5504D1138648; Mon, 8 Apr 2019 07:53:21 +0200 (CEST) From: Markus Armbruster To: Jens Freimann References: <20190322134447.14831-1-jfreimann@redhat.com> <20190404082933.ke7tvryocpdd2h54@jenstp.localdomain> <20190405085628.GA2819@work-vm> <20190405092010.2hnwu36w4ited4rl@jenstp.localdomain> Date: Mon, 08 Apr 2019 07:53:21 +0200 In-Reply-To: <20190405092010.2hnwu36w4ited4rl@jenstp.localdomain> (Jens Freimann's message of "Fri, 5 Apr 2019 11:20:10 +0200") Message-ID: <87imvpjb5a.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Mon, 08 Apr 2019 05:53:32 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [RFC PATCH 0/2] implement the failover feature for assigned network devices X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pkrempa@redhat.com, ehabkost@redhat.com, mst@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, liran.alon@oracle.com, laine@redhat.com, ogerlitz@mellanox.com, ailan@redhat.com, "Dr. David Alan Gilbert" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190408055321.fdJb9hdbFYHs8HJsfgwz3UUwFGKuH7tj624_hKbCRvw@z> Jens Freimann writes: > On Fri, Apr 05, 2019 at 09:56:29AM +0100, Dr. David Alan Gilbert wrote: >>* Jens Freimann (jfreimann@redhat.com) wrote: > [...] >>> > Commandline: There is a dependency between vfio-pci and virtio-net >>> > devices. One points to the other via new parameters >>> > primar= and standby=''. This means >>> > that the primary device needs to be specified after standby device on >>> > the qemu command line. Not sure how to solve this. >>> > >>> > Error handling: Patches don't cover all possible error scenarios yet. >>> > >>> > I have tested this with a mlx5 NIC and was able to migrate the VM with >>> > above mentioned workarounds for open problems. >>> > >>> > Command line example: >>> > >>> > qemu-system-x86_64 -enable-kvm -m 3072 -smp 3 \ >>> > -machine q35,kernel-irqchip=split -cpu host \ >>> > -k fr \ >>> > -serial stdio \ >>> > -net none \ >>> > -qmp unix:/tmp/qmp.socket,server,nowait \ >>> > -monitor telnet:127.0.0.1:5555,server,nowait \ >>> > -device pcie-root-port,id=root0,multifunction=on,chassis=0,addr=0xa \ >>> > -device pcie-root-port,id=root1,bus=pcie.0,chassis=1 \ >>> > -device pcie-root-port,id=root2,bus=pcie.0,chassis=2 \ >>> > -netdev tap,script=/root/bin/bridge.sh,downscript=no,id=hostnet1,vhost=on \ >>> > -device virtio-net-pci,netdev=hostnet1,id=net1,mac=52:54:00:6f:55:cc,bus=root2,primary=hostdev0 \ >>> > -device vfio-pci,host=5e:00.2,id=hostdev0,bus=root1,standby=net1 \ >> >>Yes, that's a bit grim; it's circular dependency on the 'hostdev0' and >>'net1' id's. cc'ing in Markus. > > Dan had an idea how to avoid having to specify the id for the > virtio-net device. I'm currently looking into it, but it seems like it > should work. Excellent. A circular dependency between -device could only lead to trouble.