From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v3 3/3] drm/i915: use REG_FIELD_PREP() to define register bitfield values Date: Thu, 28 Feb 2019 12:24:53 +0200 Message-ID: <87imx4nrbe.fsf@intel.com> References: <3f787052750840935689ac2fa8f3fa44cfbf1119.1551286447.git.jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2AE986E15A for ; Thu, 28 Feb 2019 10:22:54 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Michal Wajdeczko , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAyOCBGZWIgMjAxOSwgTWljaGFsIFdhamRlY3prbyA8bWljaGFsLndhamRlY3prb0Bp bnRlbC5jb20+IHdyb3RlOgo+IE9uIFdlZCwgMjcgRmViIDIwMTkgMTg6MDI6MzggKzAxMDAsIEph bmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+ICAKPiB3cm90ZToKPgo+PiBAQCAtMTA4 LDkgKzEwOCw5IEBACj4+ICAgKiAgI2RlZmluZSBGT08ocGlwZSkgICAgICAgICAgICAgICAgICAg X01NSU9fUElQRShwaXBlLCBfRk9PX0EsIF9GT09fQikKPj4gICAqICAjZGVmaW5lICAgRk9PX0VO QUJMRSAgICAgICAgICAgICAgICBSRUdfQklUKDMxKQo+PiAgICogICNkZWZpbmUgICBGT09fTU9E RV9NQVNLICAgICAgICAgICAgIFJFR19HRU5NQVNLKDE5LCAxNikKPj4gLSAqICAjZGVmaW5lICAg Rk9PX01PREVfQkFSICAgICAgICAgICAgICAoMCA8PCAxNikKPj4gLSAqICAjZGVmaW5lICAgRk9P X01PREVfQkFaICAgICAgICAgICAgICAoMSA8PCAxNikKPj4gLSAqICAjZGVmaW5lICAgRk9PX01P REVfUVVYX1NOQiAgICAgICAgICAoMiA8PCAxNikKPj4gKyAqICAjZGVmaW5lICAgRk9PX01PREVf QkFSICAgICAgICAgICAgICBSRUdfRklFTERfUFJFUChGT09fTU9ERV9NQVNLLCAwKQo+PiArICog ICNkZWZpbmUgICBGT09fTU9ERV9CQVogICAgICAgICAgICAgIFJFR19GSUVMRF9QUkVQKEZPT19N T0RFX01BU0ssIDEpCj4+ICsgKiAgI2RlZmluZSAgIEZPT19NT0RFX1FVWF9TTkIgICAgICAgICAg UkVHX0ZJRUxEX1BSRVAoRk9PX01PREVfTUFTSywgMikKPgo+IGhtbSwgc2hvdWxkbid0IHdlIGRl ZmluZSB0aGVzZSB2YWx1ZXMgYXM6Cj4KPiAjZGVmaW5lICAgRk9PX01PREVfQkFSICAgICAgICAg ICAgICAoMCkKPiAjZGVmaW5lICAgRk9PX01PREVfQkFaICAgICAgICAgICAgICAoMSkKPiAjZGVm aW5lICAgRk9PX01PREVfUVVYX1NOQiAgICAgICAgICAoMikKPgo+IHRvIGFsbG93IHVzaW5nIHRo ZW0gbmF0aXZlbHkgd2l0aCBSRUdfRklFTERfR0VUL1BSRVBBUkUoKSA/Cj4gbWF5YmUgd2Ugc2hv dWxkIGFsc28gY29uc2lkZXIgZHJvcHBpbmcgX01BU0sgc3VmZml4Pwo+Cj4gTU1JT19XUklURSgu Li4sCj4gICAgICAgICAgICAgUkVHX0ZJRUxEX1BSRVBBUkUoRk9PX0VOQUJMRSwgdHJ1ZSkgfAo+ ICAgICAgICAgICAgIFJFR19GSUVMRF9QUkVQQVJFKEZPT19NT0RFLCBGT09fTU9ERV9CQVIpKQo+ Cj4gbW9kZSA9IFJFR19GSUVMRF9HRVQoRk9PX01PREUsIE1NSU9fUkVBRCguLi4pKTsKPiBlbmFi bGVkID0gUkVHX0ZJRUxEX0dFVChGT09fRU5BQkxFLCBNTUlPX1JFQUQoLi4uKSk7CgpJIHdvdWxk IGhhdmUgdG8gYWdyZWUgd2l0aCB5b3UgKmlmKiB3ZSB3ZXJlIHdyaXRpbmcgYWxsIHRoaXMgZnJv bQpzY3JhdGNoLiBCdXQgYWxtb3N0IGFsbCBvZiB0aGUgZXhpc3RpbmcgYml0ZmllbGQgdmFsdWVz IGFyZSBkZWZpbmVkCnNoaWZ0ZWQgaW4gcGxhY2UsIHNvIHlvdSBjYW4gT1IgdGhlbSBpbiBwbGFj ZSBkaXJlY3RseS4gSSB3YW50IHRvIGtlZXAKaXQgdGhhdCB3YXkgaW5zdGVhZCBvZiBjcmVhdGlu ZyBhIG1peC4gQW5kIHdlIGhhdmUgYWJvdXQgMWsgbWFjcm9zIHdpdGgKX01BU0sgc3VmZml4IHRv by4KClNvLCB5ZWFoLCBpdCdzIGdvaW5nIHRvIGJlIHNsaWdodGx5IHByb2JsZW1hdGljIHRvIFJF R19GSUVMRF9HRVQoKSBhCmZpZWxkIGFuZCBjb21wYXJlIGl0IGFnYWluc3QgYSBkZWZpbmVkIHZh bHVlIGZvciB0aGF0IGZpZWxkLiBJIGV4cGVjdCB1cwp0byBrZWVwIHVzaW5nIHRoaW5ncyBsaWtl OgoKCWlmICgodmFsICYgRk9PX01PREVfTUFTSykgPT0gRk9PX01PREVfQkFSKQoKSW5kZWVkLCBv bmUgb2YgdGhlIHJlYXNvbnMgZm9yIHRoZSBsb2NhbCBpbnRlZ2VyIGNvbnN0YW50IGV4cHJlc3Np b24KdmVyc2lvbiBvZiBSRUdfRklFTERfUFJFUCgpIGlzIHRvIGFsbG93IGl0IGluIGNhc2UgbGFi ZWxzOgoKCXN3aXRjaCAodmFsICYgRk9PX01PREVfTUFTSykgewogICAgICAgIGNhc2UgRk9PX01P REVfQkFSOiAvKiBkZWZpbmVkIHVzaW5nIFJFR19GSUVMRF9QUkVQKCkgKi8KICAgICAgICAJLyog Li4uICovCiAgICAgICAgfQoKSSBkb24ndCB3YW50IHRvIGhhdmUgdG8gc3RhcnQgY2hhbmdpbmcg dGhlc2UgY29tbW9uIGV4aXN0aW5nIGNvbnZlbnRpb25zCnRocm91Z2hvdXQgdGhlIGRyaXZlci4g V2l0aCB0aGUgcHJvcG9zZWQgYXBwcm9hY2gsIHdlIGNhbiBkZWZpbmUgdGhlCnJlZ2lzdGVycyBp biB0aGUgbmV3IHN0eWxlIGFuZCBub3QgY2hhbmdlIGFueXRoaW5nLiBXZSBjYW4gZHJvcCBfU0hJ RlQKY2FzZSBieSBjYXNlIGlmIHdlIG1vdmUgdG8gUkVHX0ZJRUxEX1BSRVAvR0VUIHVzYWdlLgoK CkJSLApKYW5pLgoKCj4KPiBUaGFua3MsCj4gTWljaGFsCj4KCi0tIApKYW5pIE5pa3VsYSwgSW50 ZWwgT3BlbiBTb3VyY2UgR3JhcGhpY3MgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeA==