From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.toke.dk ([2a00:7660:6da:2001::664]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gxB3o-0002GT-Ek for ath10k@lists.infradead.org; Fri, 22 Feb 2019 13:40:19 +0000 From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= Subject: Re: [PATCH] mac80211: Change default tx_sk_pacing_shift to 7 In-Reply-To: References: <20190221172936.21816-1-toke@redhat.com> <87lg28vup0.fsf@toke.dk> Date: Fri, 22 Feb 2019 14:40:12 +0100 Message-ID: <87imxcvt4z.fsf@toke.dk> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Johannes Berg Cc: Kan Yan , wgong@qti.qualcomm.com, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, Grant Grundler , wgong@codeaurora.org, Ben Greear , Kalle Valo Sm9oYW5uZXMgQmVyZyA8am9oYW5uZXNAc2lwc29sdXRpb25zLm5ldD4gd3JpdGVzOgoKPiBPbiBG cmksIDIwMTktMDItMjIgYXQgMTQ6MDYgKzAxMDAsIFRva2UgSMO4aWxhbmQtSsO4cmdlbnNlbiB3 cm90ZToKPj4gSm9oYW5uZXMgQmVyZyA8am9oYW5uZXNAc2lwc29sdXRpb25zLm5ldD4gd3JpdGVz Ogo+PiAKPj4gPiBUb2tlIEjDuGlsYW5kLUrDuHJnZW5zZW4gd3JvdGU6Cj4+ID4gCj4+ID4gPiBX aGVuIHdlIGRpZCB0aGUgb3JpZ2luYWwgdGVzdHMgZm9yIHRoZSBvcHRpbWFsIHZhbHVlIG9mIHNr X3BhY2luZ19zaGlmdCwgd2UKPj4gPiA+IGNhbWUgdXAgd2l0aCA2IG1zIG9mIGJ1ZmZlcmluZyBh cyB0aGUgZGVmYXVsdC4gU2FkbHksIDYgaXMgbm90IGEgcG93ZXIgb2YKPj4gPiA+IHR3bywgc28g d2hlbiBwaWNraW5nIHRoZSBzaGlmdCB2YWx1ZSBJIGVycmVkIG9uIHRoZSBzaXplIG9mIGxlc3Mg YnVmZmVyaW5nCj4+ID4gPiBhbmQgcGlja2VkIDQgbXMgaW5zdGVhZCBvZiA4LiBUaGlzIHdhcyBw cm9iYWJseSB3cm9uZzsgdGhvc2UgMiBtcyBvZiBleHRyYQo+PiA+ID4gYnVmZmVyaW5nIG1ha2Vz IGEgbGFyZ2VyIGRpZmZlcmVuY2UgdGhhbiBJIHRob3VnaHQuCj4+ID4gPiAKPj4gPiA+IFNvLCBj aGFuZ2UgdGhlIGRlZmF1bHQgcGFjaW5nIHNoaWZ0IHRvIDcsIHdoaWNoIGNvcnJlc3BvbmRzIHRv IDggbXMgb2YKPj4gPiA+IGJ1ZmZlcmluZy4gVGhlIHBvaW50IG9mIGRpbWluaXNoaW5nIHJldHVy bnMgcmVhbGx5IGtpY2tzIGluIGFmdGVyIDggbXMsIGFuZAo+PiA+ID4gc28gaGF2aW5nIHRoaXMg YXMgYSBkZWZhdWx0IHNob3VsZCBjdXQgZG93biBvbiB0aGUgbmVlZCBmb3IgZXh0ZW5zaXZlCj4+ ID4gPiBwZXItZGV2aWNlIHRlc3RpbmcgYW5kIG92ZXJyaWRlcyBuZWVkZWQgaW4gdGhlIGRyaXZl cnMuCj4+ID4gPiAKPj4gPiA+IFNpZ25lZC1vZmYtYnk6IFRva2UgSMO4aWxhbmQtSsO4cmdlbnNl biA8dG9rZUByZWRoYXQuY29tPgo+PiA+IAo+PiA+IFBhdGNoIGFwcGxpZWQgdG8gd2lyZWxlc3Mu Z2l0LCB0aGFua3MuCj4+ID4gCj4+ID4gYTQxZjU2YjlhMTdhIChIRUFEIC0+IG1hYzgwMjExKSBt YWM4MDIxMTogQ2hhbmdlIGRlZmF1bHQKPj4gPiB0eF9za19wYWNpbmdfc2hpZnQgdG8gNwo+Cj4g VGhpcyBtZXNzIGNhbWUgZnJvbSBLYWxsZSdzIHRvb2wgYnR3LCBzbyBJIGNhbid0IHJlYWxseSB1 c2UgaXQgeWV0IDotKQo+Cj4+IENvb2wsIHRoYW5rcyEgV2hhdCdzIHRoZSBlYXNpZXN0IHdheSB0 byBiYWNrcG9ydCB0aGlzPyBJIGZpZ3VyZSBpdCdzCj4+IGVhc2llciB0byBqdXN0IHVwZGF0ZSBz a19wYWNpbmdfc2hpZnRfdXBkYXRlKCkgaW4gdHguYyBmb3IgNC4xOSAod2hpY2gKPj4gcHJlZGF0 ZXMgdGhlIGFkZGl0aW9uIG9mIHRoZSBkcml2ZXIgb3ZlcnJpZGUgaG9vayk7IHNoYWxsIEkganVz dCBzZW5kIGEKPj4gc2VwYXJhdGUgcGF0Y2ggdG8gc3RhYmxlIGZvciB0aGF0PyBPciBkbyB3ZSBu ZWVkIHRvIGJhY2twb3J0IHRoZSBkcml2ZXIKPj4gb3ZlcnJpZGUgaG9vayBhcyB3ZWxsPwo+Cj4g SnVzdCB1cGRhdGUgdGhlIHZhbHVlLCBubyBuZWVkIHRvIGJhY2twb3J0IHRoZSBob29rLgoKQW5k IHNlbmQgaXQgZGlyZWN0bHkgdG8gc3RhYmxlLCBvciBkb2VzIGl0IG5lZWQgdG8gZ28gdGhyb3Vn aCB5b3U/CgotVG9rZQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KYXRoMTBrIG1haWxpbmcgbGlzdAphdGgxMGtAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2F0aDEwawo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41855C43381 for ; Fri, 22 Feb 2019 13:40:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 093222075A for ; Fri, 22 Feb 2019 13:40:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=toke.dk header.i=@toke.dk header.b="HYKF4Hx9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726376AbfBVNkP (ORCPT ); Fri, 22 Feb 2019 08:40:15 -0500 Received: from mail.toke.dk ([52.28.52.200]:51773 "EHLO mail.toke.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726090AbfBVNkP (ORCPT ); Fri, 22 Feb 2019 08:40:15 -0500 From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1550842813; bh=H6iIspkFhBFfQtKWrzTUwRJ2+ZN734gWWFeMNNp2YrY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=HYKF4Hx9wHNPwVE//MCDwd65slvfY3JLdfbJ/IInhIXgrs4bbJ+KMzZZN9kmfqKQg 1g4tMPCUP6BrK6tE1aPhyny3vYnNjR6WCAIJdHvh+FIK722V5DVemOF8hKTmQWH9Ia v0/NO88PfYm5Jky6QxqEUqrvXbeoQxSUGRMpXoES2FCEWgQN0oxREisjqLGI+omj4n BXfJABX8wrZ4n9QX8nU3Yo/WtQh5+93UVBqrhoPqRqlwdNDcXSF3Yxsq8Qp9LmCoVG pnLlCsme1tY6bC983YlmZ2w9H0PQie2Md+eI7lQ1FBLT3Yj4Y+n8kElZkM0D7Kap/+ KUis4R4sbisAA== To: Johannes Berg Cc: linux-wireless@vger.kernel.org, Ben Greear , Grant Grundler , Kalle Valo , wgong@qti.qualcomm.com, ath10k@lists.infradead.org, wgong@codeaurora.org, Kan Yan Subject: Re: [PATCH] mac80211: Change default tx_sk_pacing_shift to 7 In-Reply-To: References: <20190221172936.21816-1-toke@redhat.com> <87lg28vup0.fsf@toke.dk> Date: Fri, 22 Feb 2019 14:40:12 +0100 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87imxcvt4z.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Johannes Berg writes: > On Fri, 2019-02-22 at 14:06 +0100, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >> Johannes Berg writes: >>=20 >> > Toke H=C3=B8iland-J=C3=B8rgensen wrote: >> >=20 >> > > When we did the original tests for the optimal value of sk_pacing_sh= ift, we >> > > came up with 6 ms of buffering as the default. Sadly, 6 is not a pow= er of >> > > two, so when picking the shift value I erred on the size of less buf= fering >> > > and picked 4 ms instead of 8. This was probably wrong; those 2 ms of= extra >> > > buffering makes a larger difference than I thought. >> > >=20 >> > > So, change the default pacing shift to 7, which corresponds to 8 ms = of >> > > buffering. The point of diminishing returns really kicks in after 8 = ms, and >> > > so having this as a default should cut down on the need for extensive >> > > per-device testing and overrides needed in the drivers. >> > >=20 >> > > Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen >> >=20 >> > Patch applied to wireless.git, thanks. >> >=20 >> > a41f56b9a17a (HEAD -> mac80211) mac80211: Change default >> > tx_sk_pacing_shift to 7 > > This mess came from Kalle's tool btw, so I can't really use it yet :-) > >> Cool, thanks! What's the easiest way to backport this? I figure it's >> easier to just update sk_pacing_shift_update() in tx.c for 4.19 (which >> predates the addition of the driver override hook); shall I just send a >> separate patch to stable for that? Or do we need to backport the driver >> override hook as well? > > Just update the value, no need to backport the hook. And send it directly to stable, or does it need to go through you? -Toke