From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vincent Bernat <vincent@bernat.ch>
Subject: Re: [next] bonding: pass link-local packets to bonding master also.
Date: Sun, 23 Dec 2018 14:16:57 +0100
Message-ID: <87imzkcrhy.fsf@bernat.ch>
References: <20180716011246.225647-1-mahesh@bandewar.net>
        <m3d0qmfe0d.fsf@bernat.ch>
        <120845b4-3828-4473-19bc-ec3ab0b49d4c@ziu.info>
        <87ftuseo7y.fsf@bernat.ch>
        <a252f12d-783f-2455-570d-fe4ea622fc5c@ziu.info>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: Mahesh Bandewar <mahesh@bandewar.net>,
        Jay Vosburgh <j.vosburgh@gmail.com>,
        Andy Gospodarek <andy@greyhouse.net>,
        Veaceslav Falico <vfalico@gmail.com>,
        David Miller <davem@davemloft.net>,
        Netdev <netdev@vger.kernel.org>,
        Mahesh Bandewar <maheshb@google.com>,
        Chonggang Li <chonggangli@google.com>
To: Michal Soltys <soltys@ziu.info>
Return-path: <netdev-owner@vger.kernel.org>
Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:46841 "EHLO
        wout2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1728305AbeLWNRD (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sun, 23 Dec 2018 08:17:03 -0500
In-Reply-To: <a252f12d-783f-2455-570d-fe4ea622fc5c@ziu.info> (Michal Soltys's
        message of "Sun, 23 Dec 2018 14:06:57 +0100")
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

 =E2=9D=A6 23 d=C3=A9cembre 2018 14:06 +01, Michal Soltys <soltys@ziu.info>:

>>> Basing on what you wrote below, it seems that everything was already
>>> possible before the Chonggang Li's commit ?
>>>
>>> If I understand correctly:
>>>
>>> - if listening on master, you could get both slave interface
>>> (PACKET_ORIGDEV) as well as bonding master
>>> - if listening on slave, you would just get the slave interface
>>>
>>> Right ?
>>=20
>> Yes. This has been this way since 2.6.27.
>
> In the earlier thread, the author of the original patch
> said that:
>
>> The exact problem that was fixed is, when a LLDP/CDP packet is
>> received, we want to know which exact interface did it come from,
>> instead of the bonding master.
>>=20
>> Thanks,
>> Chonggang
>
> But if PACKET_ORIGDEV provided it (and this functionally is now broken,
> so counts as another regression - earlier bridging issues aside), maybe
> it should be just reverted ?

I think this would be better. Once fixed, I can push a change for
packet(7) to document this option as it is currently not present.
--=20
The last thing one knows in constructing a work is what to put first.
		-- Blaise Pascal