From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/weston: bump to version 5.0.0
Date: Mon, 10 Dec 2018 13:55:39 +0200 [thread overview]
Message-ID: <87in017g04.fsf@tkos.co.il> (raw)
In-Reply-To: <CADvTj4qZHeBQ=wpC6JKO4h+DsvZNkTGO5Jwcik2FO_TMi5FsPg@mail.gmail.com>
Hi James,
James Hilliard writes:
> The patch I removed was just a backport of this
> https://github.com/wayland-project/weston/commit/029583e56e6eaad4139e39b4cf908158ab8cc91a
> which is now included in 5.0.0.
This is great (and should appear in the commit log). But besides that
there are these lines in weston.mk:
# 0002-rdp-compositor-fix-compilation-against-FreeRDP-2.0.0.patch
WESTON_AUTORECONF = YES
The comment is clearly wrong once you remove the patch. Moreover,
autoreconf itself might not be needed anymore. In that case you should
remove it.
baruch
> On Mon, Dec 10, 2018 at 4:29 AM Baruch Siach <baruch@tkos.co.il> wrote:
>> james.hilliard1 at gmail.com writes:
>> > From: James Hilliard <james.hilliard1@gmail.com>
>> >
>> > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
>> > ---
>> > ...tor-fix-compilation-against-FreeRDP-2.0.0.patch | 181 ---------------------
>> > package/weston/weston.hash | 10 +-
>> > package/weston/weston.mk | 2 +-
>> > 3 files changed, 6 insertions(+), 187 deletions(-)
>> > delete mode 100644 package/weston/0002-rdp-compositor-fix-compilation-against-FreeRDP-2.0.0.patch
>>
>> As you remove the configure.ac patch, is autoreconf still needed? If it
>> is, please update the autoreconf comment.
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
next prev parent reply other threads:[~2018-12-10 11:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 11:06 [Buildroot] [PATCH 1/1] package/weston: bump to version 5.0.0 james.hilliard1 at gmail.com
2018-12-10 11:29 ` Baruch Siach
2018-12-10 11:49 ` James Hilliard
2018-12-10 11:55 ` Baruch Siach [this message]
2018-12-10 12:05 ` James Hilliard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87in017g04.fsf@tkos.co.il \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.