From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: Simplify has_sagv Date: Tue, 23 Oct 2018 10:23:39 +0300 Message-ID: <87in1tdt38.fsf@intel.com> References: <874ldeh4vi.fsf@intel.com> <20181022165744.11788-1-rodrigo.vivi@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id DAEDF89255 for ; Tue, 23 Oct 2018 07:24:03 +0000 (UTC) In-Reply-To: <20181022165744.11788-1-rodrigo.vivi@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org Cc: Lucas De Marchi , Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAyMiBPY3QgMjAxOCwgUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29t PiB3cm90ZToKPiBMZXQncyBhZGQgYSBwbGF0Zm9ybSBoYXNfc2FndiBpbnN0ZWFkIG9mIGhhdmlu ZyBhIGZ1bGwKPiBmdW5jdGlvbiB0aGF0IGhhbmRsZSBwbGF0Zm9ybSBieSBwbGF0Zm9ybS4KPgo+ IFRoZSBzcGVjaWFsbHkgY2FzZSBmb3IgU0tMIGZvciBub3QgY29udHJvbGxlZCBzYWd2Cj4gaXMg YWxyZWFkeSB0YWtlbiBjYXJlIGluc2lkZSBpbnRlbF9lbmFibGVfc2Fndiwgc28gdGhlcmUncwo+ IG5vIG5lZWQgdG8gZHVwbGljYXRlIHRoZSBjaGVjayBoZXJlLgo+Cj4gdjI6IEdvIG9uZSBzdGVw IGZ1cnRoZXIgYW5kIHJlbW92ZSBza2wgc3BlY2lhbCBjYXNlLiAoSmFuaSkKPgo+IHYzOiBTZXBh cmF0ZSBydW50aW1lIHN0YXR1cyBoYW5kbGUgZnJvbSBoYXNfc2FndiBmbGFnLiAoSmFuaSkKPgo+ IENjOiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+IENjOiBMdWNhcyBEZSBN YXJjaGkgPGx1Y2FzLmRlbWFyY2hpQGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBSb2RyaWdv IFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZHJ2LmggICAgICAgICAgfCAgMSArCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfcGNpLmMgICAgICAgICAgfCAgMSArCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rl dmljZV9pbmZvLmggfCAgMSArCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMgICAg ICAgICAgfCAyOSArKysrKysrKy0tLS0tLS0tLS0tLS0tLS0KPiAgNCBmaWxlcyBjaGFuZ2VkLCAx MyBpbnNlcnRpb25zKCspLCAxOSBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYu aAo+IGluZGV4IDMwMTdlZjAzN2ZlZC4uOWI5OGNlYjJkMDI5IDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2Rydi5oCj4gQEAgLTI2NTAsNiArMjY1MCw3IEBAIGludGVsX2luZm8oY29uc3Qgc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAjZGVmaW5lIEhBU19EREkoZGV2X3ByaXYp CQkgKChkZXZfcHJpdiktPmluZm8uaGFzX2RkaSkKPiAgI2RlZmluZSBIQVNfRlBHQV9EQkdfVU5D TEFJTUVEKGRldl9wcml2KSAoKGRldl9wcml2KS0+aW5mby5oYXNfZnBnYV9kYmcpCj4gICNkZWZp bmUgSEFTX1BTUihkZXZfcHJpdikJCSAoKGRldl9wcml2KS0+aW5mby5oYXNfcHNyKQo+ICsjZGVm aW5lIEhBU19TQUdWKGRldl9wcml2KQkJICgoZGV2X3ByaXYpLT5pbmZvLmhhc19zYWd2KQo+ICAK PiAgI2RlZmluZSBIQVNfUkM2KGRldl9wcml2KQkJICgoZGV2X3ByaXYpLT5pbmZvLmhhc19yYzYp Cj4gICNkZWZpbmUgSEFTX1JDNnAoZGV2X3ByaXYpCQkgKChkZXZfcHJpdiktPmluZm8uaGFzX3Jj NnApCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcGNpLmMgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BjaS5jCj4gaW5kZXggNDRlNzQ1OTIxYWMxLi4wYjA5MTU1 ZWFiNjIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wY2kuYwo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcGNpLmMKPiBAQCAtNDY1LDYgKzQ2NSw3IEBA IHN0YXRpYyBjb25zdCBzdHJ1Y3QgaW50ZWxfZGV2aWNlX2luZm8gaW50ZWxfY2hlcnJ5dmlld19p bmZvID0gewo+ICAJLmhhc19jc3IgPSAxLCBcCj4gIAkuaGFzX2d1YyA9IDEsIFwKPiAgCS5oYXNf aXBjID0gMSwgXAo+ICsJLmhhc19zYWd2ID0gMSwgXAo+ICAJLmRkYl9zaXplID0gODk2Cj4gIAo+ ICAjZGVmaW5lIFNLTF9QTEFURk9STSBcCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2RldmljZV9pbmZvLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZXZp Y2VfaW5mby5oCj4gaW5kZXggYWY3MDAyNjQwY2RmLi5lNzdjOGI2Mjc4M2YgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGV2aWNlX2luZm8uaAo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2RldmljZV9pbmZvLmgKPiBAQCAtMTE3LDYgKzExNyw3IEBA IGVudW0gaW50ZWxfcHBndHQgewo+ICAJZnVuYyhod3NfbmVlZHNfcGh5c2ljYWwpOyBcCj4gIAlm dW5jKG92ZXJsYXlfbmVlZHNfcGh5c2ljYWwpOyBcCj4gIAlmdW5jKHN1cHBvcnRzX3R2KTsgXAo+ ICsJZnVuYyhoYXNfc2Fndik7IFwKPiAgCWZ1bmMoaGFzX2lwYyk7Cj4gIAo+ICAjZGVmaW5lIEdF Tl9NQVhfU0xJQ0VTCQkoNikgLyogQ05MIHVwcGVyIGJvdW5kICovCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9wbS5jCj4gaW5kZXggNjdhNGQwNzM1MjkxLi43ZTM4ZWQ4NDIxYzcgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3BtLmMKPiBAQCAtMzYwOSwyMCArMzYwOSw2IEBAIHN0YXRpYyBib29sIHNrbF9u ZWVkc19tZW1vcnlfYndfd2Eoc3RydWN0IGludGVsX2F0b21pY19zdGF0ZSAqc3RhdGUpCj4gIAly ZXR1cm4gZmFsc2U7Cj4gIH0KPiAgCj4gLXN0YXRpYyBib29sCj4gLWludGVsX2hhc19zYWd2KHN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAtewo+IC0JaWYgKElTX0tBQllMQUtF KGRldl9wcml2KSB8fCBJU19DT0ZGRUVMQUtFKGRldl9wcml2KSB8fAo+IC0JICAgIElTX0NBTk5P TkxBS0UoZGV2X3ByaXYpIHx8IElTX0lDRUxBS0UoZGV2X3ByaXYpKQo+IC0JCXJldHVybiB0cnVl Owo+IC0KPiAtCWlmIChJU19TS1lMQUtFKGRldl9wcml2KSAmJgo+IC0JICAgIGRldl9wcml2LT5z YWd2X3N0YXR1cyAhPSBJOTE1X1NBR1ZfTk9UX0NPTlRST0xMRUQpCj4gLQkJcmV0dXJuIHRydWU7 Cj4gLQo+IC0JcmV0dXJuIGZhbHNlOwo+IC19CgpBcmdoLiBBbGwgSSBldmVyIHdhbnRlZCB3YXMg YSB2ZXJzaW9uIG9mIFsxXSB0aGF0IHJlbW92ZWQgdGhlIFNreWxha2UKc3BlY2lhbCBjYXNpbmcg Zm9yIEk5MTVfU0FHVl9OT1RfQ09OVFJPTExFRC4gSSBldmVuIHdyb3RlIHdoYXQgdGhlCmZ1bmN0 aW9uIGNvdWxkIGJlIGluIGl0cyBlbnRpcmV0eToKCgkgIHJldHVybiAoSVNfR0VOOV9CQyhkZXZf cHJpdikgfHwgSU5URUxfR0VOKGRldl9wcml2KSA+PSAxMCkgJiYgCgkJICBkZXZfcHJpdi0+c2Fn dl9zdGF0dXMgIT0gSTkxNV9TQUdWX05PVF9DT05UUk9MTEVEOwoKSU1PIGFsbCBpdGVyYXRpb25z IHNpbmNlIGhhdmUgYmVlbiB3b3JzZS4KCkJSLApKYW5pLgoKClsxXSBodHRwOi8vcGF0Y2h3b3Jr LmZyZWVkZXNrdG9wLm9yZy9wYXRjaC9tc2dpZC8yMDE4MTAxODIzMzQ0Ny41MTg3LTktcm9kcmln by52aXZpQGludGVsLmNvbQoKCgo+IC0KPiAgLyoKPiAgICogU0FHViBkeW5hbWljYWxseSBhZGp1 c3RzIHRoZSBzeXN0ZW0gYWdlbnQgdm9sdGFnZSBhbmQgY2xvY2sgZnJlcXVlbmNpZXMKPiAgICog ZGVwZW5kaW5nIG9uIHBvd2VyIGFuZCBwZXJmb3JtYW5jZSByZXF1aXJlbWVudHMuIFRoZSBkaXNw bGF5IGVuZ2luZSBhY2Nlc3MKPiBAQCAtMzYzOSwxMCArMzYyNSwxMSBAQCBpbnRlbF9lbmFibGVf c2FndihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIHsKPiAgCWludCByZXQ7 Cj4gIAo+IC0JaWYgKCFpbnRlbF9oYXNfc2FndihkZXZfcHJpdikpCj4gKwlpZiAoIUhBU19TQUdW KGRldl9wcml2KSkKPiAgCQlyZXR1cm4gMDsKPiAgCj4gLQlpZiAoZGV2X3ByaXYtPnNhZ3Zfc3Rh dHVzID09IEk5MTVfU0FHVl9FTkFCTEVEKQo+ICsJaWYgKGRldl9wcml2LT5zYWd2X3N0YXR1cyA9 PSBJOTE1X1NBR1ZfRU5BQkxFRCB8fAo+ICsJICAgIGRldl9wcml2LT5zYWd2X3N0YXR1cyA9PSBJ OTE1X1NBR1ZfTk9UX0NPTlRST0xMRUQpCj4gIAkJcmV0dXJuIDA7Cj4gIAo+ICAJRFJNX0RFQlVH X0tNUygiRW5hYmxpbmcgdGhlIFNBR1ZcbiIpOwo+IEBAIC0zNjc2LDEwICszNjYzLDExIEBAIGlu dGVsX2Rpc2FibGVfc2FndihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIHsK PiAgCWludCByZXQ7Cj4gIAo+IC0JaWYgKCFpbnRlbF9oYXNfc2FndihkZXZfcHJpdikpCj4gKwlp ZiAoIUhBU19TQUdWKGRldl9wcml2KSkKPiAgCQlyZXR1cm4gMDsKPiAgCj4gLQlpZiAoZGV2X3By aXYtPnNhZ3Zfc3RhdHVzID09IEk5MTVfU0FHVl9ESVNBQkxFRCkKPiArCWlmIChkZXZfcHJpdi0+ c2Fndl9zdGF0dXMgPT0gSTkxNV9TQUdWX0RJU0FCTEVEIHx8Cj4gKwkgICAgZGV2X3ByaXYtPnNh Z3Zfc3RhdHVzID09IEk5MTVfU0FHVl9OT1RfQ09OVFJPTExFRCkKPiAgCQlyZXR1cm4gMDsKPiAg Cj4gIAlEUk1fREVCVUdfS01TKCJEaXNhYmxpbmcgdGhlIFNBR1ZcbiIpOwo+IEBAIC0zNzIxLDcg KzM3MDksMTAgQEAgYm9vbCBpbnRlbF9jYW5fZW5hYmxlX3NhZ3Yoc3RydWN0IGRybV9hdG9taWNf c3RhdGUgKnN0YXRlKQo+ICAJaW50IGxldmVsLCBsYXRlbmN5Owo+ICAJaW50IHNhZ3ZfYmxvY2tf dGltZV91czsKPiAgCj4gLQlpZiAoIWludGVsX2hhc19zYWd2KGRldl9wcml2KSkKPiArCWlmICgh SEFTX1NBR1YoZGV2X3ByaXYpKQo+ICsJCXJldHVybiBmYWxzZTsKPiArCj4gKwlpZiAoZGV2X3By aXYtPnNhZ3Zfc3RhdHVzID09IEk5MTVfU0FHVl9OT1RfQ09OVFJPTExFRCkKPiAgCQlyZXR1cm4g ZmFsc2U7Cj4gIAo+ICAJaWYgKElTX0dFTjkoZGV2X3ByaXYpKQoKLS0gCkphbmkgTmlrdWxhLCBJ bnRlbCBPcGVuIFNvdXJjZSBHcmFwaGljcyBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==