From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [02/31] usb: usbssp: Added some decoding functions. From: Felipe Balbi Message-Id: <87in3c1t50.fsf@linux.intel.com> Date: Tue, 11 Sep 2018 08:48:43 +0300 To: Greg Kroah-Hartman , Pawel Laszczak Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, ltyrala@cadence.com, adouglas@cadence.com List-ID: SGksCgpHcmVnIEtyb2FoLUhhcnRtYW4gPGdyZWdraEBsaW51eGZvdW5kYXRpb24ub3JnPiB3cml0 ZXM6Cj4gT24gVGh1LCBKdWwgMTksIDIwMTggYXQgMDY6NTc6MzVQTSArMDEwMCwgUGF3ZWwgTGFz emN6YWsgd3JvdGU6Cj4+IFRoaXMgcGF0Y2ggYWRkIGFkZGl0aW9uYWwgZnVuY3Rpb25zIHRoYXQg Y29udmVydHMgc29tZSBmaWVsZHMgdG8gc3RyaW5nLgo+PiAKPj4gRm9yIGV4YW1wbGUgZnVuY3Rp b24gdXNic3NwX3RyYl9jb21wX2NvZGVfc3RyaW5nIHRha2UgY29tcGxldGlvbgo+PiBjb2RlIHZh bHVlIGFuZCByZXR1cm4gc3RyaW5nIGRlc2NyaWJpbmcgY29tcGxldGlvbiBjb2RlLgo+PiAKPj4g U2lnbmVkLW9mZi1ieTogUGF3ZWwgTGFzemN6YWsgPHBhd2VsbEBjYWRlbmNlLmNvbT4KPj4gLS0t Cj4+ICBkcml2ZXJzL3VzYi91c2Jzc3AvZ2FkZ2V0LmggfCA1ODAgKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrCj4+ICAxIGZpbGUgY2hhbmdlZCwgNTgwIGluc2VydGlvbnMoKykK Pj4gCj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3VzYi91c2Jzc3AvZ2FkZ2V0LmggYi9kcml2ZXJz L3VzYi91c2Jzc3AvZ2FkZ2V0LmgKPj4gaW5kZXggNDllNzI3MTE4N2NjLi5iNWMxNzYwM2FmNzgg MTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvdXNiL3VzYnNzcC9nYWRnZXQuaAo+PiArKysgYi9kcml2 ZXJzL3VzYi91c2Jzc3AvZ2FkZ2V0LmgKPj4gQEAgLTkzMCw2ICs5MzAsNzMgQEAgc3RydWN0IHVz YnNzcF90cmFuc2Zlcl9ldmVudCB7Cj4+ICAjZGVmaW5lIENPTVBfVU5ERUZJTkVEX0VSUk9SCQkJ MzMKPj4gICNkZWZpbmUgQ09NUF9JTlZBTElEX1NUUkVBTV9JRF9FUlJPUgkJMzQKPj4gIAo+PiAr c3RhdGljIGlubGluZSBjb25zdCBjaGFyICp1c2Jzc3BfdHJiX2NvbXBfY29kZV9zdHJpbmcodTgg c3RhdHVzKQo+Cj4gPHNuaXA+Cj4KPgo+IFlvdSBoYXZlIF9naWFudF8gaW5saW5lIGZ1bmN0aW9u cyBoZXJlLCB3aHk/Cj4KPiBQbGVhc2UganVzdCBwdXQgdGhpcyBhbGwgaW4gYSAuYyBmaWxlIGFu ZCBsZXQgdGhlIGxpbmtlciBwcm9wZXJseSBoYW5kbGUKPiB0aGluZ3MuICBZb3UgZG8gbm90IHdh bnQgdG8gZHVwbGljYXRlIGFsbCBvZiB0aGVzZSBjcmF6eSBzdHJpbmdzIGFsbAo+IG92ZXIgdGhl IHBsYWNlIHdoZXJlIGV2ZXIgeW91IGNhbGwgdGhlc2UgZnVuY3Rpb25zLgo+Cj4gQW5kIEkgYW0g Z3Vlc3NpbmcgdGhpcyBpcyBvbmx5IGZvciBzb21lIHNvcnQgb2YgImRlYnVnZ2luZyIgbW9kZT8g IElmCj4gc28sIHNob3VsZG4ndCB0aGVyZSBiZSBhIHdheSB0byBub3QgZXZlbiBidWlsZCB0aGlz IGluPyAgU29tZSBzeXN0ZW1zCj4gYXJlIHZlcnkgc3BhY2UgY29uc3RyYWluZWQuLi4KCm1hbnkg b2YgdGhlbSBzZWVtIHRvIGJlIGEgc3RyYWlnaHQgY29weSBmcm9tIHhoY2kuCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2D7CC04ABB for ; Tue, 11 Sep 2018 05:49:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7FBB820854 for ; Tue, 11 Sep 2018 05:49:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7FBB820854 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726511AbeIKKqx (ORCPT ); Tue, 11 Sep 2018 06:46:53 -0400 Received: from mga18.intel.com ([134.134.136.126]:57939 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726301AbeIKKqx (ORCPT ); Tue, 11 Sep 2018 06:46:53 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Sep 2018 22:49:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,359,1531810800"; d="scan'208";a="88930395" Received: from pipin.fi.intel.com (HELO localhost) ([10.237.72.128]) by fmsmga001.fm.intel.com with ESMTP; 10 Sep 2018 22:48:44 -0700 From: Felipe Balbi To: Greg Kroah-Hartman , Pawel Laszczak Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, ltyrala@cadence.com, adouglas@cadence.com Subject: Re: [PATCH 02/31] usb: usbssp: Added some decoding functions. In-Reply-To: <20180910181856.GB6019@kroah.com> References: <1532023084-28083-1-git-send-email-pawell@cadence.com> <1532023084-28083-3-git-send-email-pawell@cadence.com> <20180910181856.GB6019@kroah.com> Date: Tue, 11 Sep 2018 08:48:43 +0300 Message-ID: <87in3c1t50.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Greg Kroah-Hartman writes: > On Thu, Jul 19, 2018 at 06:57:35PM +0100, Pawel Laszczak wrote: >> This patch add additional functions that converts some fields to string. >> >> For example function usbssp_trb_comp_code_string take completion >> code value and return string describing completion code. >> >> Signed-off-by: Pawel Laszczak >> --- >> drivers/usb/usbssp/gadget.h | 580 ++++++++++++++++++++++++++++++++++++ >> 1 file changed, 580 insertions(+) >> >> diff --git a/drivers/usb/usbssp/gadget.h b/drivers/usb/usbssp/gadget.h >> index 49e7271187cc..b5c17603af78 100644 >> --- a/drivers/usb/usbssp/gadget.h >> +++ b/drivers/usb/usbssp/gadget.h >> @@ -930,6 +930,73 @@ struct usbssp_transfer_event { >> #define COMP_UNDEFINED_ERROR 33 >> #define COMP_INVALID_STREAM_ID_ERROR 34 >> >> +static inline const char *usbssp_trb_comp_code_string(u8 status) > > > > > You have _giant_ inline functions here, why? > > Please just put this all in a .c file and let the linker properly handle > things. You do not want to duplicate all of these crazy strings all > over the place where ever you call these functions. > > And I am guessing this is only for some sort of "debugging" mode? If > so, shouldn't there be a way to not even build this in? Some systems > are very space constrained... many of them seem to be a straight copy from xhci. -- balbi