From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Ben Greear <greearb@candelatech.com>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>
Subject: Re: use-after free bug in hacked 4.16 kernel, related to fq_flow_dequeue
Date: Thu, 02 Aug 2018 21:45:55 +0200 [thread overview]
Message-ID: <87in4sy2ks.fsf@toke.dk> (raw)
In-Reply-To: <a5e579a2-5c20-5438-83c6-1eb5ae3e5630@candelatech.com>
Ben Greear <greearb@candelatech.com> writes:
> This is from my hacked kernel, could be my fault. I thought the fq
> guys might want to know however...
Hmm, nothing obvious comes to mind; fq_flow_dequeue() just dequeues a
packet from the queue; it only has two memory derefs, to fq->lock and
flow->queue. Don't see why either of those should be freed at this
point.
Unless fq_adjust_removal() is being inlined, perhaps? Then I suppose the
flow->tin reference could be the problem, if the txq_info struct was
already freed; did you change anything around the handling of TXQs?
-Toke
next prev parent reply other threads:[~2018-08-02 21:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 20:06 use-after free bug in hacked 4.16 kernel, related to fq_flow_dequeue Ben Greear
2018-08-02 19:45 ` Toke Høiland-Jørgensen [this message]
2018-08-02 19:54 ` Ben Greear
2018-08-02 20:20 ` Toke Høiland-Jørgensen
2018-08-12 21:07 ` Ben Greear
2018-08-13 12:07 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87in4sy2ks.fsf@toke.dk \
--to=toke@toke.dk \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.