From mboxrd@z Thu Jan  1 00:00:00 1970
From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
Subject: Re: [PATCH net-next v3] Add Common Applications Kept Enhanced (cake) qdisc
Date: Wed, 25 Apr 2018 20:35:37 +0200
Message-ID: <87in8f5e2u.fsf@toke.dk>
References: <20180425134249.21300-1-toke@toke.dk> <e27a6618-3a68-fa60-53a0-109b4df70482@gmail.com> <878t9b5n0q.fsf@toke.dk> <fd92ddfd-e2a6-6ea9-ccf6-d7eef3a5f207@gmail.com> <87zi1r5kgx.fsf@toke.dk> <c3412b75-156d-3e2c-0f3f-781f2f8bb042@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: cake@lists.bufferbloat.net, Dave Taht <dave.taht@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>, netdev@vger.kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail.toke.dk ([52.28.52.200]:44991 "EHLO mail.toke.dk"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1755867AbeDYSfj (ORCPT <rfc822;netdev@vger.kernel.org>);
        Wed, 25 Apr 2018 14:35:39 -0400
In-Reply-To: <c3412b75-156d-3e2c-0f3f-781f2f8bb042@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Eric Dumazet <eric.dumazet@gmail.com> writes:

> On 04/25/2018 09:17 AM, Toke H=C3=B8iland-J=C3=B8rgensen wrote:
>
>> Or am I to interpret that as a hard NAK on having this feature in CAKE
>> (even if we fix the issues you pointed out)?
>
> No strong NACK, as long as the current code is fixed.
>
> Right now, a malicious packet will kill the box or something bad like
> that.

Yeah, that's not good, obviously. I may just pull it out for now and add
it back in a separate patch once we've had time to fix it :)

-Toke