From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: fix intel_dvo_dev_ops::mode_valid's return type Date: Tue, 24 Apr 2018 18:11:47 +0300 Message-ID: <87in8gvdu4.fsf@intel.com> References: <20180424131500.2110-1-luc.vanoostenryck@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180424131500.2110-1-luc.vanoostenryck@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: linux-kernel@vger.kernel.org Cc: David Airlie , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Rodrigo Vivi , Luc Van Oostenryck List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCAyNCBBcHIgMjAxOCwgTHVjIFZhbiBPb3N0ZW5yeWNrIDxsdWMudmFub29zdGVucnlj a0BnbWFpbC5jb20+IHdyb3RlOgo+IEFsbCBpbXBsZW1lbnRhdGlvbnMgb2YgdGhlIG1ldGhvZCBp bnRlbF9kdm9fZGV2X29wczo6bW9kZV92YWxpZCgpLCBhcwo+IHdlbGwgYXMgdGhlIHVuZGVybHlp bmcgc3RydWN0IGRybV9jb25uZWN0b3JfaGVscGVyX2Z1bmNzOjptb2RlX3ZhbGlkKCkKPiB1c2Ug J2VudW0gZHJtX21vZGVfc3RhdHVzJyBmb3IgdGhlIG1ldGhvZCdzIHJldHVybiB0eXBlIGJ1dCB0 aGUKPiBkZWNsYXJhdGlvbiBvZiBpbnRlbF9kdm9fZGV2X29wczo6bW9kZV92YWxpZCgpIHVzZXMg YW4gJ2ludCcgZm9yIGl0Lgo+Cj4gRml4IHRoaXMgYnkgdXNpbmcgJ2VudW0gZHJtX21vZGVfc3Rh dHVzJyBmb3IgdGhlIGRlY2xhcmF0aW9uIHRvby4KPgo+IFNpZ25lZC1vZmYtYnk6IEx1YyBWYW4g T29zdGVucnljayA8bHVjLnZhbm9vc3RlbnJ5Y2tAZ21haWwuY29tPgo+IC0tLQo+ICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9kdm8uaCB8IDIgKy0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9u KCspLCAxIGRlbGV0aW9uKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv ZHZvLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kdm8uaAo+IGluZGV4IDVlNmEzMDEzZC4uYjZl MTQzZWJjIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2R2by5oCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvZHZvLmgKPiBAQCAtNzQsNyArNzQsNyBAQCBzdHJ1Y3QgaW50 ZWxfZHZvX2Rldl9vcHMgewo+ICAJICoKPiAgCSAqIFxyZXR1cm4gTU9ERV9PSyBpZiB0aGUgbW9k ZSBpcyB2YWxpZCwgb3IgYW5vdGhlciBNT0RFXyogb3RoZXJ3aXNlLgo+ICAJICovCj4gLQlpbnQg KCptb2RlX3ZhbGlkKShzdHJ1Y3QgaW50ZWxfZHZvX2RldmljZSAqZHZvLAo+ICsJZW51bSBkcm1f bW9kZV9zdGF0dXMgKCptb2RlX3ZhbGlkKShzdHJ1Y3QgaW50ZWxfZHZvX2RldmljZSAqZHZvLAo+ ICAJCQkgIHN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICptb2RlKTsKClBsZWFzZSBhZGp1c3QgdGhl IGFsaWdubWVudCBoZXJlIGFzIHdlbGwuIFdpdGggdGhhdCwKClJldmlld2VkLWJ5OiBKYW5pIE5p a3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgoKT2gsIGFuZCBhcyBmYXIgYXMgbGlzdHMgZ28s IGludGVsLWdmeCBpcyBzdWZmaWNpZW50LgoKCj4gIAo+ICAJLyoKCi0tIApKYW5pIE5pa3VsYSwg SW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751780AbeDXPLw (ORCPT ); Tue, 24 Apr 2018 11:11:52 -0400 Received: from mga07.intel.com ([134.134.136.100]:41047 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750943AbeDXPLw (ORCPT ); Tue, 24 Apr 2018 11:11:52 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,323,1520924400"; d="scan'208";a="49535183" From: Jani Nikula To: Luc Van Oostenryck , linux-kernel@vger.kernel.org Cc: Luc Van Oostenryck , Joonas Lahtinen , Rodrigo Vivi , David Airlie , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/i915: fix intel_dvo_dev_ops::mode_valid's return type In-Reply-To: <20180424131500.2110-1-luc.vanoostenryck@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20180424131500.2110-1-luc.vanoostenryck@gmail.com> Date: Tue, 24 Apr 2018 18:11:47 +0300 Message-ID: <87in8gvdu4.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 Apr 2018, Luc Van Oostenryck wrote: > All implementations of the method intel_dvo_dev_ops::mode_valid(), as > well as the underlying struct drm_connector_helper_funcs::mode_valid() > use 'enum drm_mode_status' for the method's return type but the > declaration of intel_dvo_dev_ops::mode_valid() uses an 'int' for it. > > Fix this by using 'enum drm_mode_status' for the declaration too. > > Signed-off-by: Luc Van Oostenryck > --- > drivers/gpu/drm/i915/dvo.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/dvo.h b/drivers/gpu/drm/i915/dvo.h > index 5e6a3013d..b6e143ebc 100644 > --- a/drivers/gpu/drm/i915/dvo.h > +++ b/drivers/gpu/drm/i915/dvo.h > @@ -74,7 +74,7 @@ struct intel_dvo_dev_ops { > * > * \return MODE_OK if the mode is valid, or another MODE_* otherwise. > */ > - int (*mode_valid)(struct intel_dvo_device *dvo, > + enum drm_mode_status (*mode_valid)(struct intel_dvo_device *dvo, > struct drm_display_mode *mode); Please adjust the alignment here as well. With that, Reviewed-by: Jani Nikula Oh, and as far as lists go, intel-gfx is sufficient. > > /* -- Jani Nikula, Intel Open Source Technology Center