From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [PATCH 01/14] drm/i915: Clean up ADPA pipe select
 bits
Date: Tue, 20 Mar 2018 08:27:02 +0200
Message-ID: <87in9rz2h5.fsf@intel.com>
References: <20180302095512.19329-1-ville.syrjala@linux.intel.com>
 <20180302095512.19329-2-ville.syrjala@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by gabe.freedesktop.org (Postfix) with ESMTPS id E67FC89E03
 for <intel-gfx@lists.freedesktop.org>; Tue, 20 Mar 2018 06:27:16 +0000 (UTC)
In-Reply-To: <20180302095512.19329-2-ville.syrjala@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ville Syrjala <ville.syrjala@linux.intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCAwMiBNYXIgMjAxOCwgVmlsbGUgU3lyamFsYSA8dmlsbGUuc3lyamFsYUBsaW51eC5p
bnRlbC5jb20+IHdyb3RlOgo+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBs
aW51eC5pbnRlbC5jb20+Cj4KPiBDbGVhbiB1cCB0aGUgQURQQSBwaXBlIHNlbGVjdCBiaXRzLiBU
byBtYWtlIHRoZSB3aG9sZSBzaXR1YXRpb24gYSBiaXQKPiBsZXNzIHVnbHkgd2UnbGwgc3RhcnQg
dG8gc2hhcmUgdGhlIHNhbWUgY29kZSBiZXR3ZWVuIC5nZXRfaHdfc3RhdGUoKQo+IGFuZCB0aGUg
cG9ydCBzdGF0ZSBhc3NlcnRzLgo+Cj4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2
aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KClJldmlld2VkLWJ5OiBKYW5pIE5pa3VsYSA8
amFuaS5uaWt1bGFAaW50ZWwuY29tPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx
NV9yZWcuaCAgICAgIHwgMTEgKysrKystLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl
bF9jcnQuYyAgICAgfCA0MCArKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0KPiAg
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgMjQgKysrKystLS0tLS0tLS0t
LS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaCAgICAgfCAgMiArKwo+
ICA0IGZpbGVzIGNoYW5nZWQsIDMzIGluc2VydGlvbnMoKyksIDQ0IGRlbGV0aW9ucygtKQo+Cj4g
ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmggYi9kcml2ZXJzL2dw
dS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gaW5kZXggOTVhMmU1MWVjYmIwLi5mNTczMDk1ZDYwYzIg
MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+ICsrKyBiL2Ry
aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiBAQCAtNDE5OSwxMSArNDE5OSwxMiBAQCBl
bnVtIHsKPiAgCj4gICNkZWZpbmUgICBBRFBBX0RBQ19FTkFCTEUJKDE8PDMxKQo+ICAjZGVmaW5l
ICAgQURQQV9EQUNfRElTQUJMRQkwCj4gLSNkZWZpbmUgICBBRFBBX1BJUEVfU0VMRUNUX01BU0sJ
KDE8PDMwKQo+IC0jZGVmaW5lICAgQURQQV9QSVBFX0FfU0VMRUNUCTAKPiAtI2RlZmluZSAgIEFE
UEFfUElQRV9CX1NFTEVDVAkoMTw8MzApCj4gLSNkZWZpbmUgICBBRFBBX1BJUEVfU0VMRUNUKHBp
cGUpICgocGlwZSkgPDwgMzApCj4gLS8qIENQVCB1c2VzIGJpdHMgMjk6MzAgZm9yIHBjaCB0cmFu
c2NvZGVyIHNlbGVjdCAqLwo+ICsjZGVmaW5lICAgQURQQV9QSVBFX1NFTF9NQVNLCQkoMTw8MzAp
Cj4gKyNkZWZpbmUgICBBRFBBX1BJUEVfU0VMX1NISUZUCQkzMAo+ICsjZGVmaW5lICAgQURQQV9Q
SVBFX1NFTChwaXBlKQkJKChwaXBlKSA8PCAzMCkKPiArI2RlZmluZSAgIEFEUEFfUElQRV9TRUxf
TUFTS19DUFQJKDM8PDI5KQo+ICsjZGVmaW5lICAgQURQQV9QSVBFX1NFTF9TSElGVF9DUFQJMjkK
PiArI2RlZmluZSAgIEFEUEFfUElQRV9TRUxfQ1BUKHBpcGUpCSgocGlwZSkgPDwgMjkpCj4gICNk
ZWZpbmUgICBBRFBBX0NSVF9IT1RQTFVHX01BU0sgIDB4MDNmZjAwMDAgLyogYml0IDI1LTE2ICov
Cj4gICNkZWZpbmUgICBBRFBBX0NSVF9IT1RQTFVHX01PTklUT1JfTk9ORSAgKDA8PDI0KQo+ICAj
ZGVmaW5lICAgQURQQV9DUlRfSE9UUExVR19NT05JVE9SX01BU0sgICgzPDwyNCkKPiBkaWZmIC0t
Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY3J0LmMgYi9kcml2ZXJzL2dwdS9kcm0v
aTkxNS9pbnRlbF9jcnQuYwo+IGluZGV4IDM5MWRkNjlhZTBhNC4uODg4ODlhZjQ0NjA4IDEwMDY0
NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NydC5jCj4gKysrIGIvZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaW50ZWxfY3J0LmMKPiBAQCAtNjMsMzMgKzYzLDM1IEBAIHN0YXRpYyBz
dHJ1Y3QgaW50ZWxfY3J0ICppbnRlbF9hdHRhY2hlZF9jcnQoc3RydWN0IGRybV9jb25uZWN0b3Ig
KmNvbm5lY3RvcikKPiAgCXJldHVybiBpbnRlbF9lbmNvZGVyX3RvX2NydChpbnRlbF9hdHRhY2hl
ZF9lbmNvZGVyKGNvbm5lY3RvcikpOwo+ICB9Cj4gIAo+ICtib29sIGludGVsX2NydF9wb3J0X2Vu
YWJsZWQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICsJCQkgICAgaTkxNV9y
ZWdfdCBhZHBhX3JlZywgZW51bSBwaXBlICpwaXBlKQo+ICt7Cj4gKwl1MzIgdmFsOwo+ICsKPiAr
CXZhbCA9IEk5MTVfUkVBRChhZHBhX3JlZyk7Cj4gKwo+ICsJLyogYXNzZXJ0cyB3YW50IHRvIGtu
b3cgdGhlIHBpcGUgZXZlbiBpZiB0aGUgcG9ydCBpcyBkaXNhYmxlZCAqLwo+ICsJaWYgKEhBU19Q
Q0hfQ1BUKGRldl9wcml2KSkKPiArCQkqcGlwZSA9ICh2YWwgJiBBRFBBX1BJUEVfU0VMX01BU0tf
Q1BUKSA+PiBBRFBBX1BJUEVfU0VMX1NISUZUX0NQVDsKPiArCWVsc2UKPiArCQkqcGlwZSA9ICh2
YWwgJiBBRFBBX1BJUEVfU0VMX01BU0spID4+IEFEUEFfUElQRV9TRUxfU0hJRlQ7Cj4gKwo+ICsJ
cmV0dXJuIHZhbCAmIEFEUEFfREFDX0VOQUJMRTsKPiArfQo+ICsKPiAgc3RhdGljIGJvb2wgaW50
ZWxfY3J0X2dldF9od19zdGF0ZShzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiAgCQkJ
CSAgIGVudW0gcGlwZSAqcGlwZSkKPiAgewo+IC0Jc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGVu
Y29kZXItPmJhc2UuZGV2Owo+IC0Jc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0g
dG9faTkxNShkZXYpOwo+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9f
aTkxNShlbmNvZGVyLT5iYXNlLmRldik7Cj4gIAlzdHJ1Y3QgaW50ZWxfY3J0ICpjcnQgPSBpbnRl
bF9lbmNvZGVyX3RvX2NydChlbmNvZGVyKTsKPiAtCXUzMiB0bXA7Cj4gIAlib29sIHJldDsKPiAg
Cj4gIAlpZiAoIWludGVsX2Rpc3BsYXlfcG93ZXJfZ2V0X2lmX2VuYWJsZWQoZGV2X3ByaXYsCj4g
IAkJCQkJCWVuY29kZXItPnBvd2VyX2RvbWFpbikpCj4gIAkJcmV0dXJuIGZhbHNlOwo+ICAKPiAt
CXJldCA9IGZhbHNlOwo+IC0KPiAtCXRtcCA9IEk5MTVfUkVBRChjcnQtPmFkcGFfcmVnKTsKPiAt
Cj4gLQlpZiAoISh0bXAgJiBBRFBBX0RBQ19FTkFCTEUpKQo+IC0JCWdvdG8gb3V0Owo+ICsJcmV0
ID0gaW50ZWxfY3J0X3BvcnRfZW5hYmxlZChkZXZfcHJpdiwgY3J0LT5hZHBhX3JlZywgcGlwZSk7
Cj4gIAo+IC0JaWYgKEhBU19QQ0hfQ1BUKGRldl9wcml2KSkKPiAtCQkqcGlwZSA9IFBPUlRfVE9f
UElQRV9DUFQodG1wKTsKPiAtCWVsc2UKPiAtCQkqcGlwZSA9IFBPUlRfVE9fUElQRSh0bXApOwo+
IC0KPiAtCXJldCA9IHRydWU7Cj4gLW91dDoKPiAgCWludGVsX2Rpc3BsYXlfcG93ZXJfcHV0KGRl
dl9wcml2LCBlbmNvZGVyLT5wb3dlcl9kb21haW4pOwo+ICAKPiAgCXJldHVybiByZXQ7Cj4gQEAg
LTE2OCwxMSArMTcwLDkgQEAgc3RhdGljIHZvaWQgaW50ZWxfY3J0X3NldF9kcG1zKHN0cnVjdCBp
bnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ICAJaWYgKEhBU19QQ0hfTFBUKGRldl9wcml2KSkKPiAg
CQk7IC8qIFRob3NlIGJpdHMgZG9uJ3QgZXhpc3QgaGVyZSAqLwo+ICAJZWxzZSBpZiAoSEFTX1BD
SF9DUFQoZGV2X3ByaXYpKQo+IC0JCWFkcGEgfD0gUE9SVF9UUkFOU19TRUxfQ1BUKGNydGMtPnBp
cGUpOwo+IC0JZWxzZSBpZiAoY3J0Yy0+cGlwZSA9PSAwKQo+IC0JCWFkcGEgfD0gQURQQV9QSVBF
X0FfU0VMRUNUOwo+ICsJCWFkcGEgfD0gQURQQV9QSVBFX1NFTF9DUFQoY3J0Yy0+cGlwZSk7Cj4g
IAllbHNlCj4gLQkJYWRwYSB8PSBBRFBBX1BJUEVfQl9TRUxFQ1Q7Cj4gKwkJYWRwYSB8PSBBRFBB
X1BJUEVfU0VMKGNydGMtPnBpcGUpOwo+ICAKPiAgCWlmICghSEFTX1BDSF9TUExJVChkZXZfcHJp
dikpCj4gIAkJSTkxNV9XUklURShCQ0xSUEFUKGNydGMtPnBpcGUpLCAwKTsKPiBkaWZmIC0tZ2l0
IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJt
L2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXggNzQwYTkxOGVlNTc4Li41NDVkODkxNTJlOWIg
MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysr
IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTEzMTcsMjEgKzEz
MTcsNiBAQCBzdGF0aWMgYm9vbCBsdmRzX3BpcGVfZW5hYmxlZChzdHJ1Y3QgZHJtX2k5MTVfcHJp
dmF0ZSAqZGV2X3ByaXYsCj4gIAlyZXR1cm4gdHJ1ZTsKPiAgfQo+ICAKPiAtc3RhdGljIGJvb2wg
YWRwYV9waXBlX2VuYWJsZWQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+IC0J
CQkgICAgICBlbnVtIHBpcGUgcGlwZSwgdTMyIHZhbCkKPiAtewo+IC0JaWYgKCh2YWwgJiBBRFBB
X0RBQ19FTkFCTEUpID09IDApCj4gLQkJcmV0dXJuIGZhbHNlOwo+IC0JaWYgKEhBU19QQ0hfQ1BU
KGRldl9wcml2KSkgewo+IC0JCWlmICgodmFsICYgUE9SVF9UUkFOU19TRUxfTUFTSykgIT0gUE9S
VF9UUkFOU19TRUxfQ1BUKHBpcGUpKQo+IC0JCQlyZXR1cm4gZmFsc2U7Cj4gLQl9IGVsc2Ugewo+
IC0JCWlmICgodmFsICYgQURQQV9QSVBFX1NFTEVDVF9NQVNLKSAhPSBBRFBBX1BJUEVfU0VMRUNU
KHBpcGUpKQo+IC0JCQlyZXR1cm4gZmFsc2U7Cj4gLQl9Cj4gLQlyZXR1cm4gdHJ1ZTsKPiAtfQo+
IC0KPiAgc3RhdGljIHZvaWQgYXNzZXJ0X3BjaF9kcF9kaXNhYmxlZChzdHJ1Y3QgZHJtX2k5MTVf
cHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAkJCQkgICBlbnVtIHBpcGUgcGlwZSwgaTkxNV9yZWdfdCBy
ZWcsCj4gIAkJCQkgICB1MzIgcG9ydF9zZWwpCj4gQEAgLTEzNjIsMTYgKzEzNDcsMTcgQEAgc3Rh
dGljIHZvaWQgYXNzZXJ0X3BjaF9oZG1pX2Rpc2FibGVkKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl
ICpkZXZfcHJpdiwKPiAgc3RhdGljIHZvaWQgYXNzZXJ0X3BjaF9wb3J0c19kaXNhYmxlZChzdHJ1
Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAkJCQkgICAgICBlbnVtIHBpcGUgcGlw
ZSkKPiAgewo+ICsJZW51bSBwaXBlIHBvcnRfcGlwZTsKPiAgCXUzMiB2YWw7Cj4gIAo+ICAJYXNz
ZXJ0X3BjaF9kcF9kaXNhYmxlZChkZXZfcHJpdiwgcGlwZSwgUENIX0RQX0IsIFRSQU5TX0RQX1BP
UlRfU0VMX0IpOwo+ICAJYXNzZXJ0X3BjaF9kcF9kaXNhYmxlZChkZXZfcHJpdiwgcGlwZSwgUENI
X0RQX0MsIFRSQU5TX0RQX1BPUlRfU0VMX0MpOwo+ICAJYXNzZXJ0X3BjaF9kcF9kaXNhYmxlZChk
ZXZfcHJpdiwgcGlwZSwgUENIX0RQX0QsIFRSQU5TX0RQX1BPUlRfU0VMX0QpOwo+ICAKPiAtCXZh
bCA9IEk5MTVfUkVBRChQQ0hfQURQQSk7Cj4gLQlJOTE1X1NUQVRFX1dBUk4oYWRwYV9waXBlX2Vu
YWJsZWQoZGV2X3ByaXYsIHBpcGUsIHZhbCksCj4gLQkgICAgICJQQ0ggVkdBIGVuYWJsZWQgb24g
dHJhbnNjb2RlciAlYywgc2hvdWxkIGJlIGRpc2FibGVkXG4iLAo+IC0JICAgICBwaXBlX25hbWUo
cGlwZSkpOwo+ICsJSTkxNV9TVEFURV9XQVJOKGludGVsX2NydF9wb3J0X2VuYWJsZWQoZGV2X3By
aXYsIFBDSF9BRFBBLCAmcG9ydF9waXBlKSAmJgo+ICsJCQlwb3J0X3BpcGUgPT0gcGlwZSwKPiAr
CQkJIlBDSCBWR0EgZW5hYmxlZCBvbiB0cmFuc2NvZGVyICVjLCBzaG91bGQgYmUgZGlzYWJsZWRc
biIsCj4gKwkJCXBpcGVfbmFtZShwaXBlKSk7Cj4gIAo+ICAJdmFsID0gSTkxNV9SRUFEKFBDSF9M
VkRTKTsKPiAgCUk5MTVfU1RBVEVfV0FSTihsdmRzX3BpcGVfZW5hYmxlZChkZXZfcHJpdiwgcGlw
ZSwgdmFsKSwKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2Lmgg
Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+IGluZGV4IDY1MmIxMWU3ODhjYy4u
NzllNzQxODQ1ZTE2IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Ry
di5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiBAQCAtMTM1NSw2
ICsxMzU1LDggQEAgdm9pZCBnZW45X2VuYWJsZV9ndWNfaW50ZXJydXB0cyhzdHJ1Y3QgZHJtX2k5
MTVfcHJpdmF0ZSAqZGV2X3ByaXYpOwo+ICB2b2lkIGdlbjlfZGlzYWJsZV9ndWNfaW50ZXJydXB0
cyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpOwo+ICAKPiAgLyogaW50ZWxfY3J0
LmMgKi8KPiArYm9vbCBpbnRlbF9jcnRfcG9ydF9lbmFibGVkKHN0cnVjdCBkcm1faTkxNV9wcml2
YXRlICpkZXZfcHJpdiwKPiArCQkJICAgIGk5MTVfcmVnX3QgYWRwYV9yZWcsIGVudW0gcGlwZSAq
cGlwZSk7Cj4gIHZvaWQgaW50ZWxfY3J0X2luaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl
dl9wcml2KTsKPiAgdm9pZCBpbnRlbF9jcnRfcmVzZXQoc3RydWN0IGRybV9lbmNvZGVyICplbmNv
ZGVyKTsKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50
ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt
Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v
bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==