Re: [PATCH] drm/i915/dp: Fix the order of platforms for setting DP source rates

[Jani Nikula <jani.nikula@linux.intel.com>]

On Mon, 26 Feb 2018, Manasi Navare <manasi.d.navare@intel.com> wrote:
> The usual if ladder order should be from newest to oldest
> platform. However the CNL conditional statement was misplaced.
> This patch sets the DP source for platforms starting from the newest
> to oldest.

Pushed to dinq, thanks for the patch.

BR,
Jani.

>
> Suggested-by: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_dp.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 56db518..1c0aeda 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -278,13 +278,13 @@ intel_dp_set_source_rates(struct intel_dp *intel_dp)
>  	/* This should only be done once */
>  	WARN_ON(intel_dp->source_rates || intel_dp->num_source_rates);
>  
> -	if (IS_GEN9_LP(dev_priv)) {
> -		source_rates = bxt_rates;
> -		size = ARRAY_SIZE(bxt_rates);
> -	} else if (IS_CANNONLAKE(dev_priv)) {
> +	if (IS_CANNONLAKE(dev_priv)) {
>  		source_rates = cnl_rates;
>  		size = ARRAY_SIZE(cnl_rates);
>  		max_rate = cnl_max_source_rate(intel_dp);
> +	} else if (IS_GEN9_LP(dev_priv)) {
> +		source_rates = bxt_rates;
> +		size = ARRAY_SIZE(bxt_rates);
>  	} else if (IS_GEN9_BC(dev_priv)) {
>  		source_rates = skl_rates;
>  		size = ARRAY_SIZE(skl_rates);

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx