From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Keith Packard" Subject: Re: [PATCH 07/21] vulkan: Add EXT_acquire_xlib_display Date: Thu, 15 Feb 2018 12:26:57 -0800 Message-ID: <87inayngmm.fsf@keithp.com> References: <20180214003134.1552-1-keithp@keithp.com> <20180214003134.1552-8-keithp@keithp.com> <20180214121355.qs6k3jx4gt7lgpr6@imgtec.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1331828248==" Return-path: In-Reply-To: <20180214121355.qs6k3jx4gt7lgpr6@imgtec.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: mesa-dev-bounces@lists.freedesktop.org Sender: "mesa-dev" To: Eric Engestrom Cc: mesa-dev@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1331828248== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Eric Engestrom writes: > Can be simplified a bit: > > _xlib_lease =3D get_option('xlib-lease') > if _xlib_lease =3D=3D 'auto' > with_xlib_lease =3D with_platform_x11 and with_platform_display > else > with_xlib_lease =3D _xlib_lease =3D=3D 'true' > endif > > (We also usually try to avoid changing the type of a var, and meson might > start being more strict with types in future releases) I wondered about that in the places I copied my code from. Good to know there's a better practice. I've switched to using this form. >> +if with_xlib_lease >> + vulkan_wsi_deps +=3D dep_xcb_xrandr >> + vulkan_wsi_args +=3D [ >> + '-DVK_USE_PLATFORM_XLIB_XRANDR_EXT', >> + ] > > vulkan_wsi_args +=3D '-DVK_USE_PLATFORM_XLIB_XRANDR_EXT' I switched all of the inappropriate usage to this form for six separate patches (three each for core/anv/radv by two extensions (DISPLAY and XLIB_X= RANDR). > with that, the meson part of this is > Reviewed-by: Eric Engestrom Awesome! Thanks for reviewing the build system bits; I'm just starting to use meson and every new change is a learning opportunity at this point. =2D-=20 =2Dkeith --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEw4O3eCVWE9/bQJ2R2yIaaQAAABEFAlqF7REACgkQ2yIaaQAA ABH4shAAg7ffw8k9reSM7V6R+ENBai4spcbPJAOoI/derByllms3jVSUYorWCjyS 8ZFjmE2Rm5HByAYyoFs440WiHwvpQ8C+cHmA2+p9Vuw0FunGtmMVVg4F6KUNXtGl RkCVUvnyEYExGpxl0ag8jucy040UwCeBl4T2kLzHa4v9vKgD/w5w7ntylv9Mz+BH jq4Go7f9+uA5dU5TMbs4bLabPJ+Fi2KJN/8a6waHqPGBjYXnNen4UFTMA3eVOt1C GxXyszldOjqnAtaPMXWI+8fqy1A9NwzOGz8xCdBWmT5V3UTo2N0jz2WCOQc6uef+ H/qlEBqzT8C/Vm22bnj0u2a3uyLRVLuz6MVUspUnj/dtWMelqEuWOEWBpFbPFaWu LVHZ/SaoDU+7q3QU/qHJHsu/aOww4EjiIcGxvMuPNDR/BpSDBmI/CuhEvPbwgP7s CRLR+jAa8zJmyQNlyOXqexzlkV7FZAXeL0wFqRwt7nW8MyD55ayzRkVOKXpv5lA1 3WkJ0QMoc1FK8tFqzughIjcKskD7BdmhvPfnzHSbFmZhp/eoZyoxdnrREZAb9FvV olKqme8+ULohfGvV5qURqnRjzu+jpu9urk+hPymw3MIRnU7Oemty6Y2dRoCjIWv8 gwcb5Ep+3x7P7Yl5nw2t5ob/VuLRYjCCvw+naflRVLc6thTMdAQ= =RMuV -----END PGP SIGNATURE----- --=-=-=-- --===============1331828248== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbWVzYS1kZXYg bWFpbGluZyBsaXN0Cm1lc2EtZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL21lc2EtZGV2Cg== --===============1331828248==--