From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: dwc3: core: Don't try to get PHYs during suspend/resume From: Felipe Balbi Message-Id: <87inc8yf7k.fsf@linux.intel.com> Date: Thu, 11 Jan 2018 10:25:35 +0200 To: Roger Quadros Cc: vigneshr@ti.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "linux-stable # = v4 . 13" List-ID: SGksCgpSb2dlciBRdWFkcm9zIDxyb2dlcnFAdGkuY29tPiB3cml0ZXM6Cj4+Pj4gLQlyZXQgPSBk d2MzX2NvcmVfc29mdF9yZXNldChkd2MpOwo+Pj4+ICsJcmV0ID0gZHdjM19jb3JlX2dldF9waHko ZHdjKTsKPj4+Cj4+PiB3ZSBjYW4gZ2V0X3BoeSBpbiBkd2MzX2NvcmVfaW5pdCgpIGFzIGl0IHdp bGwgZ2V0IGNhbGxlZCBvbiByZXN1bWUoKS4KPj4+IFRoaXMgd2FzIHRoZSAkc3ViamVjdCBvZiB0 aGlzIHBhdGNoLgo+PiAKPj4gaW5kZWVkLiB0aGFua3MgOi0pCj4+IAo+Cj4gb29wcyBzb3JyeS4g SSBtZWFudCB3ZSBjYW4ndCBjYWxsIGR3YzNfY29yZV9nZXRfcGh5KCkgaW4gZHdjM19jb3JlX2lu aXQoKS4gOlAKCmJpdCBvZiBhIGNoaWNrZW4tYW5kLWVnZyBwcm9ibGVtLiBXZSBuZWVkIHRvIHNl dHVwIHRoZSBQSFkgaW50ZXJmYWNlCmJlZm9yZSBnZXR0aW5nIHRoZSBQSFlzLCBidXQgY2FuJ3Qg Z2V0IFBIWSBkdXJpbmcgcmVzdW1lLiBNYXliZSB0aGUgYmVzdAp3YXkgaGVyZSB3b3VsZCBiZSB0 byBjaGVjayBmb3IgdGhlIHBvaW50ZXJzIGJlaW5nIHZhbGlkLiBTb21ldGhpbmcgbGlrZToKCmlm ICghcGh5KQoJZ2V0X3BoeSgpOwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932412AbeAKIZx (ORCPT + 1 other); Thu, 11 Jan 2018 03:25:53 -0500 Received: from mga02.intel.com ([134.134.136.20]:13751 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932180AbeAKIZv (ORCPT ); Thu, 11 Jan 2018 03:25:51 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,343,1511856000"; d="asc'?scan'208";a="26288827" From: Felipe Balbi To: Roger Quadros Cc: vigneshr@ti.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "linux-stable # \= v4 . 13" Subject: Re: [PATCH] usb: dwc3: core: Don't try to get PHYs during suspend/resume In-Reply-To: <610c35d0-31b9-0c51-81e4-9f0d1daf5c51@ti.com> References: <1515589914-23460-1-git-send-email-rogerq@ti.com> <0c2c7e45-9324-316a-d44b-dd17a3a2c68b@ti.com> <87373dzvmi.fsf@linux.intel.com> <327eac7d-80e2-bbd6-4fb4-98d947335698@ti.com> <87wp0pyfmo.fsf@linux.intel.com> <610c35d0-31b9-0c51-81e4-9f0d1daf5c51@ti.com> Date: Thu, 11 Jan 2018 10:25:35 +0200 Message-ID: <87inc8yf7k.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Roger Quadros writes: >>>> - ret =3D dwc3_core_soft_reset(dwc); >>>> + ret =3D dwc3_core_get_phy(dwc); >>> >>> we can get_phy in dwc3_core_init() as it will get called on resume(). >>> This was the $subject of this patch. >>=20 >> indeed. thanks :-) >>=20 > > oops sorry. I meant we can't call dwc3_core_get_phy() in dwc3_core_init()= . :P bit of a chicken-and-egg problem. We need to setup the PHY interface before getting the PHYs, but can't get PHY during resume. Maybe the best way here would be to check for the pointers being valid. Something like: if (!phy) get_phy(); =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlpXH38ACgkQzL64meEa mQbOSxAAqpUaWP6nvhFJLAEtsyP2V3dP9vOLMJRPwd7W0jPzQfl7AFje+iKlmlk6 RAFt/QTLE4TKobn+7+YybtXdYtZO5Z8gZ6G6cCVfyEgjAUx6vATQzXuomjajNK2v 5H3vXK2ZSoPv7/rTXVbW8+yqtbXWUHo0WNQw2bHOO9sUjBvh8qMGCTPG44Y3+k+t SSoayGiPHEvFAEBmiOfbqFeTKKy4LnSBpDbE3XWhgLDvN9v/1+knTn45b7iAyC9/ letD2zR+Uw73Z4kAawCJpCB90piY5TDKuBwdAGoGcO3y7w4fjBoOtpDBw5OlxQyn jnK7NutlEHlsTybqcJ9I8hMb4hM0ghwhZj32xhH4P8kYqG9Kg++OPe+moqd1WONI J2XQa9vuHh3eUgwvt/vh+OxECIXonejb8UHcjhjyVtHNbgqIgQCbRFRgg3h+jWvB /VHagKtqDxbSKMAlTeif+GZOjKaTry5IWEIav/NS5Fcrxli5lMMS8E7PCdedXuc4 YAy8nZvqv0cBUidI6+b2p9zXUpbjzlLNUtMR1rRFOi8DHJtMjM1/to/BmHYCwZre ZY1grofnN/NNn3W2+whg3WdHrsOiahJcyFjb/hZQ9hn+FjiDXdagTyOYBhNlVt8Z ICqJT7MBlz/dV9RRL2Eg1RI0mBM7oNu3hGJXx+ZRoCRompXGbxY= =UySk -----END PGP SIGNATURE----- --=-=-=--