From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6470705412124442624 X-Received: by 10.99.126.90 with SMTP id o26mr247064pgn.154.1506937636410; Mon, 02 Oct 2017 02:47:16 -0700 (PDT) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.99.7.69 with SMTP id 66ls2861132pgh.1.gmail; Mon, 02 Oct 2017 02:47:15 -0700 (PDT) X-Google-Smtp-Source: AOwi7QDAOl0LQszywzGKyLL+JD2b6fLzR6OkAFs8KPtUC183BGdKH89FJlc+ZG/NZbFP8usS/70m X-Received: by 10.101.65.141 with SMTP id a13mr762681pgq.149.1506937635445; Mon, 02 Oct 2017 02:47:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1506937635; cv=none; d=google.com; s=arc-20160816; b=u7fjLqEluLX3j8LEftpenP2vUFY/UltCytnFdi6lUSRqq2UWg8siK05cAY9dOD1M4h k4ZcJgmA3YUjJpIfoVwUSQ6DHOG4p/2NhJSWFoInYbR6dTh5TFJtLciqGS3GwlRIp9T6 /eNbtAS0JIL8c20ncnjZXfHiY7WY5LIbuOLiyDT+B9P1XFf8RC9RTTyaLAKbxhWCzmeD PyBwe19XGco4da5pzvX+sp21KRjaiqpo1ACPHDX15xsEKJg7BqcFwlENSlEQ7jZ440iS 311FiCXoN0D+Yyt8jddwgMSa3+YgJwPiPBAvba/8e4lmB8R2kb/N17AjrVt8MOERjCi6 P7ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:message-id:date:references:organization:in-reply-to :subject:to:from:arc-authentication-results; bh=YQymzjO8OwlchZLhQXN5kA4jusonGm0zQcr3z1yZjOc=; b=Aier+111kN9MQoqMMmGdPgnRSarwuNJDlv/0E6gexamhzo4bFC8g4kheZ37NXEN2Lh gEpyHGFMNXJCK/apR5lMJ/wPsvENcne9HzPHvZ8Nny4c6cldyZNoSfkNFwxaaCCYcOXk OuvUH+d+auAdfNtQ4Pzitf8CNLJaWhSkuxK92zuL2yJcqDXjfuyCdKzq3+HFcmygW2fD vzv+UTG4zDw/sZx5HiVKok95vC8YJSjO6Iz3Co1gx3jKWNqW99FAnEUYgeI1jm6IYG1r NljtOQM9/i5jl6iZGz1Idr6uxvnY5hGvH50GtNVkfFRzVjK2OvwuHFgCo77dSOgylAKu KFFQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jani.nikula@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=jani.nikula@intel.com Return-Path: Received: from mga02.intel.com (mga02.intel.com. [134.134.136.20]) by gmr-mx.google.com with ESMTPS id t77si1001750pfi.13.2017.10.02.02.47.15 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Oct 2017 02:47:15 -0700 (PDT) Received-SPF: pass (google.com: domain of jani.nikula@intel.com designates 134.134.136.20 as permitted sender) client-ip=134.134.136.20; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jani.nikula@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=jani.nikula@intel.com Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Oct 2017 02:47:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,468,1500966000"; d="scan'208";a="905808569" Received: from jnikula-mobl2.fi.intel.com (HELO localhost) ([10.237.72.62]) by FMSMGA003.fm.intel.com with ESMTP; 02 Oct 2017 02:47:12 -0700 From: Jani Nikula To: Daniel Thompson , Meghana Madhyastha , daniel@ffwll.ch, noralf@tronnes.org, outreachy-kernel@googlegroups.com, dri-devel@lists.freedesktop.org, Lee Jones Subject: Re: [PATCH v7 1/3] backlight: Add IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE) In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <7a6311819f8eea0b2845c25cca72324b25e63e13.1506878301.git.meghana.madhyastha@gmail.com> <527a54b8-d67a-651c-3326-4780b9f3cfc4@linaro.org> <87r2um53zj.fsf@intel.com> Date: Mon, 02 Oct 2017 12:46:44 +0300 Message-ID: <87infx6fwb.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain On Mon, 02 Oct 2017, Daniel Thompson wrote: > On 02/10/17 09:49, Jani Nikula wrote: >> On Mon, 02 Oct 2017, Daniel Thompson wrote: >>> On 01/10/17 18:26, Meghana Madhyastha wrote: >>>> -#ifdef CONFIG_OF >>>> +#if defined CONFIG_OF && IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE) >>> >>> The above comments are more important but why does this mix defined and >>> IS_ENABLED? Couldn't they both use defined (and preferably with the >>> optional brackets around the CONFIG_ symbol). >> >> No, always use IS_ENABLED() for tristates when you want to match 'y' or >> 'm'. > > Oops. > > Actually it was the mis-match in the original code that attracted my > attention (defined on one side, IS_ENABLED() on the other)... I'd be > happier if both used the same approach. Agreed. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v7 1/3] backlight: Add IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE) Date: Mon, 02 Oct 2017 12:46:44 +0300 Message-ID: <87infx6fwb.fsf@intel.com> References: <7a6311819f8eea0b2845c25cca72324b25e63e13.1506878301.git.meghana.madhyastha@gmail.com> <527a54b8-d67a-651c-3326-4780b9f3cfc4@linaro.org> <87r2um53zj.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9F47F6E2E2 for ; Mon, 2 Oct 2017 09:47:15 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Thompson , Meghana Madhyastha , daniel@ffwll.ch, noralf@tronnes.org, outreachy-kernel@googlegroups.com, dri-devel@lists.freedesktop.org, Lee Jones List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCAwMiBPY3QgMjAxNywgRGFuaWVsIFRob21wc29uIDxkYW5pZWwudGhvbXBzb25AbGlu YXJvLm9yZz4gd3JvdGU6Cj4gT24gMDIvMTAvMTcgMDk6NDksIEphbmkgTmlrdWxhIHdyb3RlOgo+ PiBPbiBNb24sIDAyIE9jdCAyMDE3LCBEYW5pZWwgVGhvbXBzb24gPGRhbmllbC50aG9tcHNvbkBs aW5hcm8ub3JnPiB3cm90ZToKPj4+IE9uIDAxLzEwLzE3IDE4OjI2LCBNZWdoYW5hIE1hZGh5YXN0 aGEgd3JvdGU6Cj4+Pj4gLSNpZmRlZiBDT05GSUdfT0YKPj4+PiArI2lmIGRlZmluZWQgQ09ORklH X09GICYmIElTX0VOQUJMRUQoQ09ORklHX0JBQ0tMSUdIVF9DTEFTU19ERVZJQ0UpCj4+Pgo+Pj4g VGhlIGFib3ZlIGNvbW1lbnRzIGFyZSBtb3JlIGltcG9ydGFudCBidXQgd2h5IGRvZXMgdGhpcyBt aXggZGVmaW5lZCBhbmQKPj4+IElTX0VOQUJMRUQ/IENvdWxkbid0IHRoZXkgYm90aCB1c2UgZGVm aW5lZCAoYW5kIHByZWZlcmFibHkgd2l0aCB0aGUKPj4+IG9wdGlvbmFsIGJyYWNrZXRzIGFyb3Vu ZCB0aGUgQ09ORklHXyBzeW1ib2wpLgo+PiAKPj4gTm8sIGFsd2F5cyB1c2UgSVNfRU5BQkxFRCgp IGZvciB0cmlzdGF0ZXMgd2hlbiB5b3Ugd2FudCB0byBtYXRjaCAneScgb3IKPj4gJ20nLgo+Cj4g T29wcy4KPgo+IEFjdHVhbGx5IGl0IHdhcyB0aGUgbWlzLW1hdGNoIGluIHRoZSBvcmlnaW5hbCBj b2RlIHRoYXQgYXR0cmFjdGVkIG15IAo+IGF0dGVudGlvbiAoZGVmaW5lZCBvbiBvbmUgc2lkZSwg SVNfRU5BQkxFRCgpIG9uIHRoZSBvdGhlcikuLi4gSSdkIGJlIAo+IGhhcHBpZXIgaWYgYm90aCB1 c2VkIHRoZSBzYW1lIGFwcHJvYWNoLgoKQWdyZWVkLgoKQlIsCkphbmkuCgoKLS0gCkphbmkgTmlr dWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRy aS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK