All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org, rth@twiddle.net,
	pbonzini@redhat.com, crosthwaite.peter@gmail.com,
	david@gibson.dropbear.id.au
Subject: Re: [Qemu-devel] [PATCH fix for-2.9] cpus: fix wrong define name
Date: Mon, 10 Apr 2017 08:56:52 +0100	[thread overview]
Message-ID: <87inmck857.fsf@linaro.org> (raw)
In-Reply-To: <20170410060655.32289-1-nikunj@linux.vnet.ibm.com>


Nikunj A Dadhania <nikunj@linux.vnet.ibm.com> writes:

> While the configure script generates TARGET_SUPPORTS_MTTCG define, one
> of the define is cpus.c is checking wrong name: TARGET_SUPPORT_MTTCG
>
> Signed-off-by: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
> ---
>  cpus.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/cpus.c b/cpus.c
> index 68fdbc4..58d90aa 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -202,7 +202,7 @@ void qemu_tcg_configure(QemuOpts *opts, Error **errp)
>              } else if (use_icount) {
>                  error_setg(errp, "No MTTCG when icount is enabled");
>              } else {
> -#ifndef TARGET_SUPPORT_MTTCG
> +#ifndef TARGET_SUPPORTS_MTTCG
>                  error_report("Guest not yet converted to MTTCG - "
>                               "you may get unexpected results");
>  #endif

Opps that's embarrassing.

Applied to my tree, I'll be sending a pullreq today

--
Alex Bennée

  reply	other threads:[~2017-04-10  7:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-10  6:06 [Qemu-devel] [PATCH fix for-2.9] cpus: fix wrong define name Nikunj A Dadhania
2017-04-10  7:56 ` Alex Bennée [this message]
2017-04-10 17:26 ` Richard Henderson
2017-04-10 17:29   ` Peter Maydell
2017-04-10 17:31     ` Richard Henderson
2017-04-10 17:44     ` Greg Kurz
2017-04-10 17:49       ` Richard Henderson
2017-04-10 22:13         ` Greg Kurz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87inmck857.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=crosthwaite.peter@gmail.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=nikunj@linux.vnet.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.