From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35718)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1ctciu-0001jU-Ac
	for qemu-devel@nongnu.org; Thu, 30 Mar 2017 12:14:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1ctcip-0000wU-4n
	for qemu-devel@nongnu.org; Thu, 30 Mar 2017 12:14:56 -0400
Received: from mail-wr0-x22b.google.com ([2a00:1450:400c:c0c::22b]:33158)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <alex.bennee@linaro.org>)
	id 1ctcio-0000vU-Sb
	for qemu-devel@nongnu.org; Thu, 30 Mar 2017 12:14:51 -0400
Received: by mail-wr0-x22b.google.com with SMTP id w43so67146520wrb.0
	for <qemu-devel@nongnu.org>; Thu, 30 Mar 2017 09:14:50 -0700 (PDT)
References: <20170330164657.50c75e8c@nial.brq.redhat.com>
	<87k2764xex.fsf@linaro.org>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
In-reply-to: <87k2764xex.fsf@linaro.org>
Date: Thu, 30 Mar 2017 17:14:47 +0100
Message-ID: <87inmq4u88.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] qemu-2.9 crashes in tcg_handle_interrupt() during
 winx64 boot
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org, Jan Kiszka <jan.kiszka@siemens.com>, KONRAD Frederic <fred.konrad@greensocs.com>, "Emilio G. Cota" <cota@braap.org>, Richard Henderson <rth@twiddle.net>, Pranith Kumar <bobby.prani@gmail.com>, Peter Maydell <peter.maydell@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>


Alex Bennée <alex.bennee@linaro.org> writes:

> Igor Mammedov <imammedo@redhat.com> writes:
>
>> (PS: resend due to wrong qemu-devel mail list address in original
>> email)
>
> Le *sigh* another way of x86 generating IRQs ;-)
>
> Could you test this please?

Sorry I missed you'll also need a:

#include "qemu/main-loop.h"

At the top of misc_helper.c

>
> target/i386/misc_helper: wrap BQL around another IRQ generator
>
> Anything that calls into HW emulation must be protected by the BQL.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>
> 1 file changed, 2 insertions(+)
> target/i386/misc_helper.c | 2 ++
>
> modified   target/i386/misc_helper.c
> @@ -156,7 +156,9 @@ void helper_write_crN(CPUX86State *env, int reg, target_ulong t0)
>          break;
>      case 8:
>          if (!(env->hflags2 & HF2_VINTR_MASK)) {
> +            qemu_mutex_lock_iothread();
>              cpu_set_apic_tpr(x86_env_get_cpu(env)->apic_state, t0);
> +            qemu_mutex_unlock_iothread();
>          }
>          env->v_tpr = t0 & 0x0f;
>          break;


--
Alex Bennée