diff for duplicates of <87innfq2gp.fsf@qca.qualcomm.com> diff --git a/a/1.txt b/N1/1.txt index 346e453..4b6eef5 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,28 +1,30 @@ Erik Stromdahl <erik.stromdahl@gmail.com> writes: ->> You are right, there is definitely a memory leak (and there are similar problems +>> You are right, there is definitely a memory leak (and there are similar = +problems >> in a couple of other functions as well as you have pointed out). >> >> This was introduced in version 3 of the ->> RFC when I removed the bounce buffer from ath6kl. Instead I introduced a bunch of ->> local "bounce" buffers in order to make sure that the buffers passed to the sdio +>> RFC when I removed the bounce buffer from ath6kl. Instead I introduced a= + bunch of +>> local "bounce" buffers in order to make sure that the buffers passed to = +the sdio >> subsystem is dma-able (malloc'ed buffer instead of stack allocated). >> ->> Regarding endianess: That particular code construct is an artifact from ath6kl. +>> Regarding endianess: That particular code construct is an artifact from = +ath6kl. >> I am not sure it makes any sense to use a u32 in that particular case. >> A u8 array is most likely more convenient. >> >> It is really nice you have found some time to review the patches! > -> After doing some reviewing myself I have found some more endianess related issues. -> I will fix those (and the memory leaks) and submit v5 some time next week. +> After doing some reviewing myself I have found some more endianess relate= +d issues. +> I will fix those (and the memory leaks) and submit v5 some time next week= +. Actually let me send v5 (for the sdio part, I'm ignoring usb for now). I have made some small changes while looking at the patches. --- -Kalle Valo -_______________________________________________ -ath10k mailing list -ath10k@lists.infradead.org -http://lists.infradead.org/mailman/listinfo/ath10k +--=20 +Kalle Valo= diff --git a/a/content_digest b/N1/content_digest index 860f1b8..d4ee6a0 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -14,31 +14,33 @@ "b\0" "Erik Stromdahl <erik.stromdahl@gmail.com> writes:\n" "\n" - ">> You are right, there is definitely a memory leak (and there are similar problems\n" + ">> You are right, there is definitely a memory leak (and there are similar =\n" + "problems\n" ">> in a couple of other functions as well as you have pointed out).\n" ">>\n" ">> This was introduced in version 3 of the\n" - ">> RFC when I removed the bounce buffer from ath6kl. Instead I introduced a bunch of\n" - ">> local \"bounce\" buffers in order to make sure that the buffers passed to the sdio\n" + ">> RFC when I removed the bounce buffer from ath6kl. Instead I introduced a=\n" + " bunch of\n" + ">> local \"bounce\" buffers in order to make sure that the buffers passed to =\n" + "the sdio\n" ">> subsystem is dma-able (malloc'ed buffer instead of stack allocated).\n" ">>\n" - ">> Regarding endianess: That particular code construct is an artifact from ath6kl.\n" + ">> Regarding endianess: That particular code construct is an artifact from =\n" + "ath6kl.\n" ">> I am not sure it makes any sense to use a u32 in that particular case.\n" ">> A u8 array is most likely more convenient.\n" ">>\n" ">> It is really nice you have found some time to review the patches!\n" ">\n" - "> After doing some reviewing myself I have found some more endianess related issues.\n" - "> I will fix those (and the memory leaks) and submit v5 some time next week.\n" + "> After doing some reviewing myself I have found some more endianess relate=\n" + "d issues.\n" + "> I will fix those (and the memory leaks) and submit v5 some time next week=\n" + ".\n" "\n" "Actually let me send v5 (for the sdio part, I'm ignoring usb for now). I\n" "have made some small changes while looking at the patches.\n" "\n" - "-- \n" - "Kalle Valo\n" - "_______________________________________________\n" - "ath10k mailing list\n" - "ath10k@lists.infradead.org\n" - http://lists.infradead.org/mailman/listinfo/ath10k + "--=20\n" + Kalle Valo= -5a674e3ad028fae1e2edd407600c691d07e0c5f97d266f69a2d278e8afa7545d +acb71c76c8f49737031febbccdbfa1a3f7fbe3a099044168009e53183911180c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.