From: "Lluís Vilanova" <vilanova@ac.upc.edu>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] Makefile: Make "install" depend on "trace-events-all"
Date: Sun, 05 Feb 2017 00:39:45 +0200 [thread overview]
Message-ID: <87inop8tse.fsf@frigg.lan> (raw)
In-Reply-To: <20170204143245.15974-1-famz@redhat.com> (Fam Zheng's message of "Sat, 4 Feb 2017 22:32:45 +0800")
Fam Zheng writes:
> We install this file to data dir but since 0ab8ed18 it's no longer
> required by any objects during "make". List it explicitly as a depended
> target of install and fix the broken "make install" command.
I'm probably wrong, but I remember someone worked on making traces
self-descriptive, so that simpletrace would no longer need access to the
generated trace-events-all file.
If the file is really never used, then all stray rules to generate it should be
removed, as well as its installation.
Cheers,
Lluis
next prev parent reply other threads:[~2017-02-04 22:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-04 14:32 [Qemu-devel] [PATCH] Makefile: Make "install" depend on "trace-events-all" Fam Zheng
2017-02-04 22:39 ` Lluís Vilanova [this message]
2017-02-06 10:36 ` Daniel P. Berrange
2017-02-06 10:35 ` Daniel P. Berrange
2017-02-07 10:17 ` Christian Borntraeger
2017-02-07 15:14 ` Stefan Hajnoczi
2017-02-07 22:25 ` Doug Gilmore
2017-02-13 14:04 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87inop8tse.fsf@frigg.lan \
--to=vilanova@ac.upc.edu \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.