From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Schwab Subject: Re: [PATCH] ASoC : fsl_ssi : Correct the condition to check AC97 mode Date: Wed, 28 Dec 2016 15:50:57 +0100 Message-ID: <87inq4f6pa.fsf@linux-m68k.org> References: <20161228110636.GA14768@ubuntu> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20161228110636.GA14768@ubuntu> (Sharvari Harisangam's message of "Wed, 28 Dec 2016 11:06:44 +0000") Sender: linux-kernel-owner@vger.kernel.org To: "Harisangam, Sharvari (S.)" Cc: Timur Tabi , Nicolin Chen , Xiubo Li , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , "alsa-devel@alsa-project.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" List-Id: alsa-devel@alsa-project.org On Dez 28 2016, "Harisangam, Sharvari (S.)" wrote: > + return !!(ssi_private->dai_fmt & SND_SOC_DAIFMT_AC97) == > + SND_SOC_DAIFMT_AC97; This is never true. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3tpbRN1KqCzDq8G for ; Thu, 29 Dec 2016 01:56:47 +1100 (AEDT) From: Andreas Schwab To: "Harisangam\, Sharvari \(S.\)" Cc: Timur Tabi , Nicolin Chen , "Xiubo Li" , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , "alsa-devel\@alsa-project.org" , "linuxppc-dev\@lists.ozlabs.org" , "linux-kernel\@vger.kernel.org" Subject: Re: [PATCH] ASoC : fsl_ssi : Correct the condition to check AC97 mode References: <20161228110636.GA14768@ubuntu> Date: Wed, 28 Dec 2016 15:50:57 +0100 In-Reply-To: <20161228110636.GA14768@ubuntu> (Sharvari Harisangam's message of "Wed, 28 Dec 2016 11:06:44 +0000") Message-ID: <87inq4f6pa.fsf@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Dez 28 2016, "Harisangam, Sharvari (S.)" wrote: > + return !!(ssi_private->dai_fmt & SND_SOC_DAIFMT_AC97) == > + SND_SOC_DAIFMT_AC97; This is never true. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751280AbcL1Ovj (ORCPT ); Wed, 28 Dec 2016 09:51:39 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:41044 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751013AbcL1Ovh (ORCPT ); Wed, 28 Dec 2016 09:51:37 -0500 X-Auth-Info: Gqn5C+6i1Y7U1kpuN+8PJsT9HExHhpkru8eep4S/LwZsrxi11FETVT6EfexSYa2t From: Andreas Schwab To: "Harisangam\, Sharvari \(S.\)" Cc: Timur Tabi , Nicolin Chen , "Xiubo Li" , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , "alsa-devel\@alsa-project.org" , "linuxppc-dev\@lists.ozlabs.org" , "linux-kernel\@vger.kernel.org" Subject: Re: [PATCH] ASoC : fsl_ssi : Correct the condition to check AC97 mode References: <20161228110636.GA14768@ubuntu> X-Yow: Yow! We're going to a new disco! Date: Wed, 28 Dec 2016 15:50:57 +0100 In-Reply-To: <20161228110636.GA14768@ubuntu> (Sharvari Harisangam's message of "Wed, 28 Dec 2016 11:06:44 +0000") Message-ID: <87inq4f6pa.fsf@linux-m68k.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Dez 28 2016, "Harisangam, Sharvari (S.)" wrote: > + return !!(ssi_private->dai_fmt & SND_SOC_DAIFMT_AC97) == > + SND_SOC_DAIFMT_AC97; This is never true. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."