From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: Remove instructions to file a bug report. Date: Sat, 03 Dec 2016 11:52:49 +0200 Message-ID: <87inr1qqz2.fsf@intel.com> References: <1480726985-12762-1-git-send-email-mattst88@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 62A9F6E064 for ; Sat, 3 Dec 2016 09:53:08 +0000 (UTC) In-Reply-To: <1480726985-12762-1-git-send-email-mattst88@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Turner , intel-gfx@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, Kenneth Graunke , Daniel Vetter , Mika Kuoppala List-Id: intel-gfx@lists.freedesktop.org T24gU2F0LCAwMyBEZWMgMjAxNiwgTWF0dCBUdXJuZXIgPG1hdHRzdDg4QGdtYWlsLmNvbT4gd3Jv dGU6Cj4gRnJvbSB0aGVzZSBpbnN0cnVjdGlvbnMsIHVzZXJzIGFzc3VtZSB0aGF0IC9zeXMvY2xh c3MvZHJtL2NhcmQwL2Vycm9yCj4gY29udGFpbnMgYWxsIHRoZSBpbmZvcm1hdGlvbiBhIGRldmVs b3BlciBuZWVkcyB0byBkaWFnbm9zZSBhbmQgZml4IGEgR1BVCj4gaGFuZy4KPgo+IEluIGZhY3Qg aXQgZG9lc24ndCwgYW5kIHdlIGhhdmUgbm8gdG9vbHMgZm9yIHNvbHZpbmcgdGhlbSAob3RoZXIg dGhhbgo+IHN0YWJiaW5nIGluIHRoZSBkYXJrKS4gTW9zdCBvZiB0aGUgdGltZSB0aGUgZXJyb3Ig c3RhdGUgaXRzZWxmIGlzbid0Cj4gZXZlbiB1c2VmdWwgYmVjYXVzZSBpdCBqdXN0IHNob3dzIGEg aGFuZyBvbiBhIFBJUEVfQ09OVFJPTCBvciBzaW1pbGFyLgo+Cj4gVW50aWwgYSB0aW1lIHdoZW4g dGhlIGVycm9yIHN0YXRlIGNvbnRhaW5zIGVub3VnaCBpbmZvcm1hdGlvbiB0bwo+IGFjdHVhbGx5 IHNvbHZlIGEgaGFuZywgc3RvcCB0ZWxsaW5nIHVzZXJzIHRvIGZpbGUgdW5zb2x2YWJsZSBidWdz LCBhbmQKPiBpbnN0ZWFkIHJlbHkgb24gdXNlcnMgd2hvIGtub3cgd2hlcmUgYW5kIGhvdyB0byBm aWxlIGEgZ29vZCBidWcgcmVwb3J0Cj4gdG8gZmluZCB0aGVpciBvd24gd2F5IHRoZXJlLgo+Cj4g U2lnbmVkLW9mZi1ieTogTWF0dCBUdXJuZXIgPG1hdHRzdDg4QGdtYWlsLmNvbT4KPiAtLS0KPiBN YXliZSBub3cncyBhIGdvb2QgdGltZSB0byBkaXNjdXNzIHdoYXQgKndvdWxkKiBiZSB1c2VmdWwg dG8gcHV0IGluIHRoZQo+IGVycm9yIHN0YXRlIGZvciBkZWJ1Z2dpbmcgaGFuZ3MuIFRoZSBjdXJy ZW50bHkgZXhlY3V0aW5nIHNoYWRlciBwcm9ncmFtCj4gd291bGQgYmUgYSBncmVhdCBwbGFjZSB0 byBzdGFydC4KCkknbSB3b25kZXJpbmcgd2h5IHdlJ3JlIGdldHRpbmcgdGhpcyBwYXRjaCBub3cs IGFuZCBteSBndWVzcyBpcyB0aGF0Cml0J3MgYmVjYXVzZSB3ZSBoYXZlIGJlZW4gcmVhc3NpZ25p bmcgdGhlIHJlbGF0ZWQgYnVncyB0byBNZXNhIG1vcmUKYWN0aXZlbHkgbGF0ZWx5LiBJcyB0aGF0 IHRoZSBjYXNlPwoKSUlVQyB0aGUgYnVnIHJlcG9ydHMgYXJlIHVzZWZ1bCBmb3IgdXMgd2hlbiBp dCdzIGEga2VybmVsIGJ1ZywgYnV0IGxlc3MKdXNlZnVsIGZvciB5b3Ugd2hlbiBpdCdzIGEgTWVz YSBidWcuIEFuZCB5b3UnZCByYXRoZXIgaGF2ZSBmZXdlcgppbmNvbWluZyBidWdzIHRoYXQgeW91 IHRoaW5rIGFyZSB1bnNvbHZhYmxlIHdpdGggdGhlIGluZm9ybWF0aW9uIGF0CmhhbmQuCgpTb3Vu ZHMgbGlrZSBhIGJ1ZyB3b3JrZmxvdyBpc3N1ZSBiZXR3ZWVuIGRybS9pOTE1IGFuZCBNZXNhIHRv IGJlIGlyb25lZApvdXQuCgoKQlIsCkphbmkuCgoKPgo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2dwdV9lcnJvci5jIHwgMTEgLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDExIGRl bGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3B1 X2Vycm9yLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dwdV9lcnJvci5jCj4gaW5kZXgg MzM0ZjE1ZC4uOGRkY2E3YiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2dwdV9lcnJvci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ncHVfZXJyb3Iu Ywo+IEBAIC0xNDMxLDcgKzE0MzEsNiBAQCB2b2lkIGk5MTVfY2FwdHVyZV9lcnJvcl9zdGF0ZShz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAkJCSAgICAgIHUzMiBlbmdpbmVf bWFzaywKPiAgCQkJICAgICAgY29uc3QgY2hhciAqZXJyb3JfbXNnKQo+ICB7Cj4gLQlzdGF0aWMg Ym9vbCB3YXJuZWQ7Cj4gIAlzdHJ1Y3QgZHJtX2k5MTVfZXJyb3Jfc3RhdGUgKmVycm9yOwo+ICAJ dW5zaWduZWQgbG9uZyBmbGFnczsKPiAgCj4gQEAgLTE0NzUsMTYgKzE0NzQsNiBAQCB2b2lkIGk5 MTVfY2FwdHVyZV9lcnJvcl9zdGF0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYs Cj4gIAkJaTkxNV9lcnJvcl9zdGF0ZV9mcmVlKCZlcnJvci0+cmVmKTsKPiAgCQlyZXR1cm47Cj4g IAl9Cj4gLQo+IC0JaWYgKCF3YXJuZWQpIHsKPiAtCQlEUk1fSU5GTygiR1BVIGhhbmdzIGNhbiBp bmRpY2F0ZSBhIGJ1ZyBhbnl3aGVyZSBpbiB0aGUgZW50aXJlIGdmeCBzdGFjaywgaW5jbHVkaW5n IHVzZXJzcGFjZS5cbiIpOwo+IC0JCURSTV9JTkZPKCJQbGVhc2UgZmlsZSBhIF9uZXdfIGJ1ZyBy ZXBvcnQgb24gYnVncy5mcmVlZGVza3RvcC5vcmcgYWdhaW5zdCBEUkkgLT4gRFJNL0ludGVsXG4i KTsKPiAtCQlEUk1fSU5GTygiZHJtL2k5MTUgZGV2ZWxvcGVycyBjYW4gdGhlbiByZWFzc2lnbiB0 byB0aGUgcmlnaHQgY29tcG9uZW50IGlmIGl0J3Mgbm90IGEga2VybmVsIGlzc3VlLlxuIik7Cj4g LQkJRFJNX0lORk8oIlRoZSBncHUgY3Jhc2ggZHVtcCBpcyByZXF1aXJlZCB0byBhbmFseXplIGdw dSBoYW5ncywgc28gcGxlYXNlIGFsd2F5cyBhdHRhY2ggaXQuXG4iKTsKPiAtCQlEUk1fSU5GTygi R1BVIGNyYXNoIGR1bXAgc2F2ZWQgdG8gL3N5cy9jbGFzcy9kcm0vY2FyZCVkL2Vycm9yXG4iLAo+ IC0JCQkgZGV2X3ByaXYtPmRybS5wcmltYXJ5LT5pbmRleCk7Cj4gLQkJd2FybmVkID0gdHJ1ZTsK PiAtCX0KPiAgfQo+ICAKPiAgdm9pZCBpOTE1X2Vycm9yX3N0YXRlX2dldChzdHJ1Y3QgZHJtX2Rl dmljZSAqZGV2LAoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5 IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751388AbcLCJxy (ORCPT ); Sat, 3 Dec 2016 04:53:54 -0500 Received: from mga04.intel.com ([192.55.52.120]:25170 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750828AbcLCJxw (ORCPT ); Sat, 3 Dec 2016 04:53:52 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,291,1477983600"; d="scan'208";a="793759668" From: Jani Nikula To: Matt Turner , intel-gfx@lists.freedesktop.org Cc: Daniel Vetter , Mika Kuoppala , Kenneth Graunke , Mark Janes , linux-kernel@vger.kernel.org, Matt Turner , "Argotti\, Yann" , Chris Wilson Subject: Re: [PATCH] drm/i915: Remove instructions to file a bug report. In-Reply-To: <1480726985-12762-1-git-send-email-mattst88@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1480726985-12762-1-git-send-email-mattst88@gmail.com> Date: Sat, 03 Dec 2016 11:52:49 +0200 Message-ID: <87inr1qqz2.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 03 Dec 2016, Matt Turner wrote: > From these instructions, users assume that /sys/class/drm/card0/error > contains all the information a developer needs to diagnose and fix a GPU > hang. > > In fact it doesn't, and we have no tools for solving them (other than > stabbing in the dark). Most of the time the error state itself isn't > even useful because it just shows a hang on a PIPE_CONTROL or similar. > > Until a time when the error state contains enough information to > actually solve a hang, stop telling users to file unsolvable bugs, and > instead rely on users who know where and how to file a good bug report > to find their own way there. > > Signed-off-by: Matt Turner > --- > Maybe now's a good time to discuss what *would* be useful to put in the > error state for debugging hangs. The currently executing shader program > would be a great place to start. I'm wondering why we're getting this patch now, and my guess is that it's because we have been reassigning the related bugs to Mesa more actively lately. Is that the case? IIUC the bug reports are useful for us when it's a kernel bug, but less useful for you when it's a Mesa bug. And you'd rather have fewer incoming bugs that you think are unsolvable with the information at hand. Sounds like a bug workflow issue between drm/i915 and Mesa to be ironed out. BR, Jani. > > drivers/gpu/drm/i915/i915_gpu_error.c | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c > index 334f15d..8ddca7b 100644 > --- a/drivers/gpu/drm/i915/i915_gpu_error.c > +++ b/drivers/gpu/drm/i915/i915_gpu_error.c > @@ -1431,7 +1431,6 @@ void i915_capture_error_state(struct drm_i915_private *dev_priv, > u32 engine_mask, > const char *error_msg) > { > - static bool warned; > struct drm_i915_error_state *error; > unsigned long flags; > > @@ -1475,16 +1474,6 @@ void i915_capture_error_state(struct drm_i915_private *dev_priv, > i915_error_state_free(&error->ref); > return; > } > - > - if (!warned) { > - DRM_INFO("GPU hangs can indicate a bug anywhere in the entire gfx stack, including userspace.\n"); > - DRM_INFO("Please file a _new_ bug report on bugs.freedesktop.org against DRI -> DRM/Intel\n"); > - DRM_INFO("drm/i915 developers can then reassign to the right component if it's not a kernel issue.\n"); > - DRM_INFO("The gpu crash dump is required to analyze gpu hangs, so please always attach it.\n"); > - DRM_INFO("GPU crash dump saved to /sys/class/drm/card%d/error\n", > - dev_priv->drm.primary->index); > - warned = true; > - } > } > > void i915_error_state_get(struct drm_device *dev, -- Jani Nikula, Intel Open Source Technology Center