All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>, Zhenyu Wang <zhenyuw@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	intel-gfx@lists.freedesktop.org, "Lv,
	Zhiyuan" <zhiyuan.lv@intel.com>,
	igvt-g-dev@lists.01.org, Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PULL] GVT-g device model core
Date: Tue, 18 Oct 2016 14:59:14 +0300	[thread overview]
Message-ID: <87inspx3zh.fsf@intel.com> (raw)
In-Reply-To: <87vawrrrx8.fsf@intel.com>

On Mon, 17 Oct 2016, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Mon, 17 Oct 2016, Daniel Vetter <daniel@ffwll.ch> wrote:
>> Ok applied, but a few things to keep in mind before your next pull
>> request:
>>
>> - Dont rebase everything 5 seconds before sending out the pull request.
>>   That just invalidates all the testing you've done, so not a good idea.
>>   In general try to avoid rebases as much as possible, and only rebase to
>>   take out a truly embarassing mistake. And then only rebase up to the
>>   patch that needs a hotfix, not your entire tree.
>
> CONFIG_DRM_I915_GVT=y
>
> drivers/gpu/drm/i915/gvt/handlers.c: In function ‘render_mmio_to_ring_id’:
> drivers/gpu/drm/i915/gvt/handlers.c:137:31: error: request for member ‘mmio_base’ in something not a structure or union
>    if (gvt->dev_priv->engine[i].mmio_base == reg)

This is now fixed, thanks, but there's still a load of sparse warnings
coming from gvt. Please install sparse, and run e.g.

$ make
$ rm drivers/gpu/drm/i915/gvt/*.o
$ make C=1

Below is a list of current warnings.

BR,
Jani.


  CHECK   drivers/gpu/drm/i915/gvt/firmware.c
drivers/gpu/drm/i915/gvt/firmware.c:54:9: warning: incorrect type in argument 2 (different address spaces)
drivers/gpu/drm/i915/gvt/firmware.c:54:9:    expected void volatile [noderef] <asn:2>*addr
drivers/gpu/drm/i915/gvt/firmware.c:54:9:    got void *
drivers/gpu/drm/i915/gvt/firmware.c:56:9: warning: incorrect type in argument 1 (different address spaces)
drivers/gpu/drm/i915/gvt/firmware.c:56:9:    expected void const volatile [noderef] <asn:2>*addr
drivers/gpu/drm/i915/gvt/firmware.c:56:9:    got void *
drivers/gpu/drm/i915/gvt/firmware.c:58:13: warning: incorrect type in argument 1 (different address spaces)
drivers/gpu/drm/i915/gvt/firmware.c:58:13:    expected void const volatile [noderef] <asn:2>*addr
drivers/gpu/drm/i915/gvt/firmware.c:58:13:    got void *
drivers/gpu/drm/i915/gvt/firmware.c:61:9: warning: incorrect type in argument 2 (different address spaces)
drivers/gpu/drm/i915/gvt/firmware.c:61:9:    expected void volatile [noderef] <asn:2>*addr
drivers/gpu/drm/i915/gvt/firmware.c:61:9:    got void *
drivers/gpu/drm/i915/gvt/firmware.c:63:13: warning: incorrect type in argument 1 (different address spaces)
drivers/gpu/drm/i915/gvt/firmware.c:63:13:    expected void const volatile [noderef] <asn:2>*addr
drivers/gpu/drm/i915/gvt/firmware.c:63:13:    got void *
drivers/gpu/drm/i915/gvt/firmware.c:66:13: warning: incorrect type in argument 1 (different address spaces)
drivers/gpu/drm/i915/gvt/firmware.c:66:13:    expected void const volatile [noderef] <asn:2>*addr
drivers/gpu/drm/i915/gvt/firmware.c:66:13:    got void *
drivers/gpu/drm/i915/gvt/firmware.c:132:56: warning: incorrect type in argument 1 (different address spaces)
drivers/gpu/drm/i915/gvt/firmware.c:132:56:    expected void const volatile [noderef] <asn:2>*addr
drivers/gpu/drm/i915/gvt/firmware.c:132:56:    got void *
drivers/gpu/drm/i915/gvt/firmware.c:259:14: warning: incorrect type in assignment (different address spaces)
drivers/gpu/drm/i915/gvt/firmware.c:259:14:    expected void *mmio
drivers/gpu/drm/i915/gvt/firmware.c:259:14:    got void [noderef] <asn:2>*
drivers/gpu/drm/i915/gvt/firmware.c:299:27: warning: incorrect type in argument 2 (different address spaces)
drivers/gpu/drm/i915/gvt/firmware.c:299:27:    expected void [noderef] <asn:2>*<noident>
drivers/gpu/drm/i915/gvt/firmware.c:299:27:    got void *mmio
drivers/gpu/drm/i915/gvt/firmware.c:306:27: warning: incorrect type in argument 2 (different address spaces)
drivers/gpu/drm/i915/gvt/firmware.c:306:27:    expected void [noderef] <asn:2>*<noident>
drivers/gpu/drm/i915/gvt/firmware.c:306:27:    got void *mmio
  CC [M]  drivers/gpu/drm/i915/gvt/firmware.o
  CHECK   drivers/gpu/drm/i915/gvt/interrupt.c
drivers/gpu/drm/i915/gvt/interrupt.c:52:12: warning: symbol 'irq_name' was not declared. Should it be static?
  CC [M]  drivers/gpu/drm/i915/gvt/interrupt.o
  CHECK   drivers/gpu/drm/i915/gvt/gtt.c
drivers/gpu/drm/i915/gvt/gtt.c:270:23: warning: cast removes address space of expression
drivers/gpu/drm/i915/gvt/gtt.c:274:21: warning: incorrect type in argument 1 (different address spaces)
drivers/gpu/drm/i915/gvt/gtt.c:274:21:    expected void const volatile [noderef] <asn:2>*addr
drivers/gpu/drm/i915/gvt/gtt.c:274:21:    got void *addr
drivers/gpu/drm/i915/gvt/gtt.c:285:23: warning: cast removes address space of expression
drivers/gpu/drm/i915/gvt/gtt.c:288:21: warning: incorrect type in argument 2 (different address spaces)
drivers/gpu/drm/i915/gvt/gtt.c:288:21:    expected void volatile [noderef] <asn:2>*addr
drivers/gpu/drm/i915/gvt/gtt.c:288:21:    got void *addr
drivers/gpu/drm/i915/gvt/gtt.c:1922:6: warning: symbol 'intel_gvt_create_scratch_page' was not declared. Should it be static?
drivers/gpu/drm/i915/gvt/gtt.c:1956:6: warning: symbol 'intel_gvt_release_scratch_page' was not declared. Should it be static?
drivers/gpu/drm/i915/gvt/gtt.c:1932:24: warning: odd constant _Bool cast (fffffffffffffff4 becomes 1)
drivers/gpu/drm/i915/gvt/gtt.c:1948:24: warning: odd constant _Bool cast (fffffffffffffffa becomes 1)
  CC [M]  drivers/gpu/drm/i915/gvt/gtt.o
  CHECK   drivers/gpu/drm/i915/gvt/cfg_space.c
  CC [M]  drivers/gpu/drm/i915/gvt/cfg_space.o
  CHECK   drivers/gpu/drm/i915/gvt/opregion.c
drivers/gpu/drm/i915/gvt/opregion.c:45:48: warning: incorrect type in argument 2 (different address spaces)
drivers/gpu/drm/i915/gvt/opregion.c:45:48:    expected void const volatile [noderef] <asn:2>*src
drivers/gpu/drm/i915/gvt/opregion.c:45:48:    got void *host_va
drivers/gpu/drm/i915/gvt/opregion.c:165:30: warning: incorrect type in argument 1 (different address spaces)
drivers/gpu/drm/i915/gvt/opregion.c:165:30:    expected void volatile [noderef] <asn:2>*addr
drivers/gpu/drm/i915/gvt/opregion.c:165:30:    got void *opregion_va
drivers/gpu/drm/i915/gvt/opregion.c:183:35: warning: incorrect type in assignment (different address spaces)
drivers/gpu/drm/i915/gvt/opregion.c:183:35:    expected void *opregion_va
drivers/gpu/drm/i915/gvt/opregion.c:183:35:    got void [noderef] <asn:2>*
  CC [M]  drivers/gpu/drm/i915/gvt/opregion.o
  CHECK   drivers/gpu/drm/i915/gvt/mmio.c
  CC [M]  drivers/gpu/drm/i915/gvt/mmio.o
  CHECK   drivers/gpu/drm/i915/gvt/display.c
drivers/gpu/drm/i915/gvt/display.c:122:4: warning: symbol 'dpcd_fix_data' was not declared. Should it be static?
  CC [M]  drivers/gpu/drm/i915/gvt/display.o
  CHECK   drivers/gpu/drm/i915/gvt/edid.c
  CC [M]  drivers/gpu/drm/i915/gvt/edid.o
  CHECK   drivers/gpu/drm/i915/gvt/execlist.c
drivers/gpu/drm/i915/gvt/execlist.c:619:6: warning: symbol 'submit_context' was not declared. Should it be static?
drivers/gpu/drm/i915/gvt/execlist.c:634:24: warning: odd constant _Bool cast (ffffffffffffffea becomes 1)
drivers/gpu/drm/i915/gvt/execlist.c:661:24: warning: odd constant _Bool cast (fffffffffffffff4 becomes 1)
  CC [M]  drivers/gpu/drm/i915/gvt/execlist.o
drivers/gpu/drm/i915/gvt/execlist.c: In function ‘release_shadow_batch_buffer’:
drivers/gpu/drm/i915/gvt/execlist.c:501:4: warning: ‘drm_gem_object_unreference’ is deprecated (declared at drivers/gpu/drm/i915/i915_drv.h:2344) [-Wdeprecated-declarations]
    drm_gem_object_unreference(&(entry_obj->obj->base));
    ^
drivers/gpu/drm/i915/gvt/execlist.c: In function ‘release_shadow_wa_ctx’:
drivers/gpu/drm/i915/gvt/execlist.c:514:2: warning: ‘drm_gem_object_unreference’ is deprecated (declared at drivers/gpu/drm/i915/i915_drv.h:2344) [-Wdeprecated-declarations]
  drm_gem_object_unreference(&(wa_ctx->indirect_ctx.obj->base));
  ^
  CHECK   drivers/gpu/drm/i915/gvt/scheduler.c
drivers/gpu/drm/i915/gvt/scheduler.c:43:6: warning: symbol 'set_context_pdp_root_pointer' was not declared. Should it be static?
  CC [M]  drivers/gpu/drm/i915/gvt/scheduler.o
  CHECK   drivers/gpu/drm/i915/gvt/sched_policy.c
drivers/gpu/drm/i915/gvt/sched_policy.c:236:35: warning: symbol 'tbs_schedule_ops' was not declared. Should it be static?
  CC [M]  drivers/gpu/drm/i915/gvt/sched_policy.o
  CHECK   drivers/gpu/drm/i915/gvt/render.c
  CC [M]  drivers/gpu/drm/i915/gvt/render.o
  CHECK   drivers/gpu/drm/i915/gvt/cmd_parser.c
drivers/gpu/drm/i915/gvt/cmd_parser.c:481:15: warning: symbol 'bypass_scan_mask' was not declared. Should it be static?
drivers/gpu/drm/i915/gvt/cmd_parser.c:482:6: warning: symbol 'bypass_batch_buffer_scan' was not declared. Should it be static?
drivers/gpu/drm/i915/gvt/cmd_parser.c:961:28: warning: symbol 'cmd_interrupt_events' was not declared. Should it be static?




-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-10-18 11:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-14 10:30 [PULL] GVT-g device model core Zhenyu Wang
2016-10-17  7:30 ` Daniel Vetter
2016-10-17  7:33   ` Daniel Vetter
2016-10-17  7:45     ` Zhenyu Wang
2016-10-17 14:07       ` Daniel Vetter
2016-10-18  1:45         ` Zhenyu Wang
2016-10-17 14:06   ` Jani Nikula
2016-10-18 11:59     ` Jani Nikula [this message]
2016-10-19  1:52       ` Zhenyu Wang
2016-10-18 14:43 ` Chris Wilson
2016-10-19  7:50 ` Chris Wilson
2016-10-19  7:58   ` Zhenyu Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87inspx3zh.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=daniel.vetter@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=igvt-g-dev@lists.01.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=zhenyuw@linux.intel.com \
    --cc=zhiyuan.lv@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.