From: Markus Armbruster <armbru@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: "Daniel P. Berrange" <berrange@redhat.com>,
Luiz Capitulino <lcapitulino@redhat.com>,
Pavel Dovgalyuk <dovgaluk@ispras.ru>,
qemu-devel <qemu-devel@nongnu.org>,
Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>,
Felipe Franciosi <felipe@nutanix.com>
Subject: Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result
Date: Fri, 23 Sep 2016 10:15:28 +0200 [thread overview]
Message-ID: <87intnxc9r.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <bda9de43-d6e4-4542-f736-912d335dd229@redhat.com> (Eric Blake's message of "Thu, 22 Sep 2016 08:30:09 -0500")
Eric Blake <eblake@redhat.com> writes:
> On 09/22/2016 06:51 AM, Markus Armbruster wrote:
>>>
>>> I think the file probably should not have been listed as public domain
>>> in the first place, as its initial contents were copied from qemu-common.h
>>> which is not public domain.
>>
>> Ewww! Needs fixing.
>
> Indeed. Commit 5c02632 shows the initial file creation, but Luiz used a
> different email address at that time. What would be the best line to
> list as a copyright holder on both qemu-common.h and on compiler.h?
Since qemu-common.h carried no licence notice back then[*], adding the
line "/* public domain */" was to compiler.h was wrong, and is probably
legally void. The immediate fix is therefore dropping that line. Then
the project-wide license applies: GPLv2+.
We can always copy the standard GPLv2+ licence notice to files that
don't have one, if we think that's useful.
>> Since qemu-common.h carries no license, GPLv2+ applies.
[*] It still doesn't, but that's immaterial.
next prev parent reply other threads:[~2016-09-23 8:15 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 17:08 [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result Felipe Franciosi
2016-09-21 5:17 ` Pavel Dovgalyuk
2016-09-21 6:24 ` Markus Armbruster
2016-09-21 10:00 ` Felipe Franciosi
2016-09-21 10:03 ` Pavel Dovgalyuk
2016-09-21 10:07 ` Daniel P. Berrange
2016-09-21 10:12 ` Felipe Franciosi
2016-09-21 12:28 ` Felipe Franciosi
2016-09-21 12:31 ` Markus Armbruster
2016-09-21 13:55 ` Eric Blake
2016-09-21 14:26 ` Felipe Franciosi
2016-09-21 14:35 ` Daniel P. Berrange
2016-09-21 14:38 ` Felipe Franciosi
2016-09-21 14:44 ` Eric Blake
2016-09-21 15:28 ` Markus Armbruster
2016-09-21 18:18 ` Eric Blake
2016-09-22 8:00 ` Daniel P. Berrange
2016-09-22 11:51 ` Markus Armbruster
2016-09-22 13:30 ` Eric Blake
2016-09-23 8:15 ` Markus Armbruster [this message]
2016-09-23 13:02 ` Felipe Franciosi
2016-09-21 14:42 ` Eric Blake
2016-09-21 9:17 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87intnxc9r.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=Pavel.Dovgaluk@ispras.ru \
--cc=berrange@redhat.com \
--cc=dovgaluk@ispras.ru \
--cc=eblake@redhat.com \
--cc=felipe@nutanix.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.