From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43651)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bnLdw-0005bF-4w
	for qemu-devel@nongnu.org; Fri, 23 Sep 2016 04:15:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bnLdr-00078Q-To
	for qemu-devel@nongnu.org; Fri, 23 Sep 2016 04:15:35 -0400
Received: from mx1.redhat.com ([209.132.183.28]:57638)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bnLdr-00078F-Mq
	for qemu-devel@nongnu.org; Fri, 23 Sep 2016 04:15:31 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <000301d213c7$7142f980$53c8ec80$@ru>
	<87y42l93dr.fsf@dusky.pond.sub.org>
	<F2184EE4-2A52-4609-8681-E7D22F33735D@nutanix.com>
	<20160921100718.GO15535@redhat.com>
	<87mvj11ljr.fsf@dusky.pond.sub.org>
	<ead4f524-9281-e80b-e42d-325d39ee8b43@redhat.com>
	<7500849B-8BCC-4743-92A6-5DBD4D8575E8@nutanix.com>
	<20160921143546.GS15535@redhat.com>
	<87zin1w9v4.fsf@dusky.pond.sub.org>
	<bd059b3e-bb2f-fd15-a7cb-588f075bdab9@redhat.com>
	<20160922080004.GB352@redhat.com> <87r38cjgon.fsf@dusky.pond.sub.org>
	<bda9de43-d6e4-4542-f736-912d335dd229@redhat.com>
Date: Fri, 23 Sep 2016 10:15:28 +0200
In-Reply-To: <bda9de43-d6e4-4542-f736-912d335dd229@redhat.com> (Eric Blake's
	message of "Thu, 22 Sep 2016 08:30:09 -0500")
Message-ID: <87intnxc9r.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH] replay: Fix build with
 -Werror=unused-result
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: "Daniel P. Berrange" <berrange@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>, Pavel Dovgalyuk <dovgaluk@ispras.ru>, qemu-devel <qemu-devel@nongnu.org>, Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>, Felipe Franciosi <felipe@nutanix.com>

Eric Blake <eblake@redhat.com> writes:

> On 09/22/2016 06:51 AM, Markus Armbruster wrote:
>>>
>>> I think the file probably should not have been listed as public domain
>>> in the first place, as its initial contents were copied from qemu-common.h
>>> which is not public domain.
>> 
>> Ewww!  Needs fixing.
>
> Indeed.  Commit 5c02632 shows the initial file creation, but Luiz used a
> different email address at that time.  What would be the best line to
> list as a copyright holder on both qemu-common.h and on compiler.h?

Since qemu-common.h carried no licence notice back then[*], adding the
line "/* public domain */" was to compiler.h was wrong, and is probably
legally void.  The immediate fix is therefore dropping that line.  Then
the project-wide license applies: GPLv2+.

We can always copy the standard GPLv2+ licence notice to files that
don't have one, if we think that's useful.

>> Since qemu-common.h carries no license, GPLv2+ applies.


[*] It still doesn't, but that's immaterial.