From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60663)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bFz9T-00033N-8S
	for qemu-devel@nongnu.org; Thu, 23 Jun 2016 03:34:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bFz9N-0002do-8j
	for qemu-devel@nongnu.org; Thu, 23 Jun 2016 03:34:14 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55381)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bFz9N-0002dk-2t
	for qemu-devel@nongnu.org; Thu, 23 Jun 2016 03:34:09 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1466634202-24616-1-git-send-email-samuel.thibault@ens-lyon.org>
	<1466634202-24616-5-git-send-email-samuel.thibault@ens-lyon.org>
Date: Thu, 23 Jun 2016 09:34:03 +0200
In-Reply-To: <1466634202-24616-5-git-send-email-samuel.thibault@ens-lyon.org>
	(Samuel Thibault's message of "Thu, 23 Jun 2016 00:23:21 +0200")
Message-ID: <87inx0740k.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 4/5] curses: add option to specify VGA font
 encoding
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: qemu-devel@nongnu.org, kraxel@redhat.com, pbonzini@redhat.com, berrange@redhat.com, peter.maydell@linaro.org, mjt@tls.msk.ru

Samuel Thibault <samuel.thibault@ens-lyon.org> writes:

> This detects and uses iconv to convert glyphs from the specified VGA font
> encoding to unicode.
>
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
[...]
> diff --git a/qemu-options.hx b/qemu-options.hx
> index ce535a9..2187886 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -321,6 +321,26 @@ The default is @code{en-us}.
>  ETEXI
>  
>  
> +DEF("f", HAS_ARG, QEMU_OPTION_f,
> +    "-f encoding     use font encoding (for example 'CP850' for IBM CP850 encoding)\n",
> +    QEMU_ARCH_ALL)
> +STEXI
> +@item -h @var{encoding}
> +@findex -h
> +Use font encoding @var{encoding} (for example @code{CP850} for
> +IBM CP/850 encoding). This option is only needed where output is text-only, i.e.
> +with the curses display, to convert from text-mode output from the guest to
> +proper text glyphs.
> +
> +The available encoding are provided by the libc, the full list can be obtained by
> +@example
> +iconv -l
> +@end example
> +
> +The default is @code{CP437}.
> +ETEXI
> +
> +

Since this option applies only to the curses display, it should be a
-display curses parameter, like this: -display curses,charset=CP850.

>  DEF("audio-help", 0, QEMU_OPTION_audio_help,
>      "-audio-help     print list of audio drivers and their options\n",
>      QEMU_ARCH_ALL)
[...]