* [PATCH net] net: dsa: mv88e6xxx: Fix port forwarding mask
@ 2016-05-30 9:35 Wojciech Dubowik
2016-05-30 14:17 ` Vivien Didelot
0 siblings, 1 reply; 2+ messages in thread
From: Wojciech Dubowik @ 2016-05-30 9:35 UTC (permalink / raw)
To: davem; +Cc: netdev, Wojciech Dubowik
Port's vlan table is specified by bit mask and not by number.
Only 4.4.x kernels are affected.
Signed-off-by: Wojciech Dubowik <Wojciech.Dubowik@neratec.com>
---
drivers/net/dsa/mv88e6xxx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c
index 2dea39b..3e074d4 100644
--- a/drivers/net/dsa/mv88e6xxx.c
+++ b/drivers/net/dsa/mv88e6xxx.c
@@ -2150,7 +2150,7 @@ static int mv88e6xxx_setup_port(struct dsa_switch *ds, int port)
* database, and allow every port to egress frames on all other ports.
*/
reg = BIT(ps->num_ports) - 1; /* all ports */
- ret = _mv88e6xxx_port_vlan_map_set(ds, port, reg & ~port);
+ ret = _mv88e6xxx_port_vlan_map_set(ds, port, reg & ~BIT(port));
if (ret)
goto abort;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] net: dsa: mv88e6xxx: Fix port forwarding mask
2016-05-30 9:35 [PATCH net] net: dsa: mv88e6xxx: Fix port forwarding mask Wojciech Dubowik
@ 2016-05-30 14:17 ` Vivien Didelot
0 siblings, 0 replies; 2+ messages in thread
From: Vivien Didelot @ 2016-05-30 14:17 UTC (permalink / raw)
To: Wojciech Dubowik, davem; +Cc: netdev, Wojciech Dubowik
Hi Wojciech, David,
Wojciech Dubowik <Wojciech.Dubowik@neratec.com> writes:
> Port's vlan table is specified by bit mask and not by number.
> Only 4.4.x kernels are affected.
>
> Signed-off-by: Wojciech Dubowik <Wojciech.Dubowik@neratec.com>
> ---
> drivers/net/dsa/mv88e6xxx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c
> index 2dea39b..3e074d4 100644
> --- a/drivers/net/dsa/mv88e6xxx.c
> +++ b/drivers/net/dsa/mv88e6xxx.c
> @@ -2150,7 +2150,7 @@ static int mv88e6xxx_setup_port(struct dsa_switch *ds, int port)
> * database, and allow every port to egress frames on all other ports.
> */
> reg = BIT(ps->num_ports) - 1; /* all ports */
> - ret = _mv88e6xxx_port_vlan_map_set(ds, port, reg & ~port);
> + ret = _mv88e6xxx_port_vlan_map_set(ds, port, reg & ~BIT(port));
> if (ret)
> goto abort;
Commit be1faa92e83b ("net: dsa: mv88e6xxx: fix port VLAN maps") in
net/master already fixes this.
But indeed v4.5 contains be1faa92e83b but not v4.4.
Thanks,
Vivien
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-30 14:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-30 9:35 [PATCH net] net: dsa: mv88e6xxx: Fix port forwarding mask Wojciech Dubowik
2016-05-30 14:17 ` Vivien Didelot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.